From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74DAFC6FD19 for ; Thu, 16 Mar 2023 14:30:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B8B9E900003; Thu, 16 Mar 2023 10:30:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B147D900002; Thu, 16 Mar 2023 10:30:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9DC33900003; Thu, 16 Mar 2023 10:30:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8FC9A900002 for ; Thu, 16 Mar 2023 10:30:12 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 66A56C142B for ; Thu, 16 Mar 2023 14:30:12 +0000 (UTC) X-FDA: 80574996264.14.7B52F2C Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by imf11.hostedemail.com (Postfix) with ESMTP id 3AEBA40007 for ; Thu, 16 Mar 2023 14:30:10 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=C+GP8Lpv; spf=pass (imf11.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.178 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678977010; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8tJ4I9ZiOnVv27V/2pSQJ0BPsYXHXaREO6k8Y5ACwnI=; b=bkX9fr1ZR8iH1eb3RKwMKoTc61e91RyBocAv2dZ022EAcWynNsA/K++1Nz2EeuW7bKVMD2 daxNEpFgSUSOUwsDLy209kmX9yEWugk2/XvT072NE4fMLdrvLrBg4wy7AYy5DdLCsn5NR8 EFJXAUnLK90LNVrWv5K9g6Sxn3szf+c= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=C+GP8Lpv; spf=pass (imf11.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.178 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678977010; a=rsa-sha256; cv=none; b=7DEIP1F41wpkZIUzwPhS+3YDcBcxL64cudH4U9EoVaxvzefeX6my9pafOafX+yiGWiY9Wk ZClmIaGc+58njs00RT/cMBg8P+/O/hh6Y8iZ3rCoviM3tEzpmTvlAQK8Sc1vuNPgkzzUgA C++KdAahklp/JBpROwsdRYPjMUrTLfI= Received: by mail-qt1-f178.google.com with SMTP id s12so1852275qtq.11 for ; Thu, 16 Mar 2023 07:30:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; t=1678977009; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8tJ4I9ZiOnVv27V/2pSQJ0BPsYXHXaREO6k8Y5ACwnI=; b=C+GP8LpvlQRSMcbmjE1Y6jbjYNh1r7qtieyvqkJoRE2fZrv4fxBngweL8yB8gOs1Ci zRvDHr/tRnfo2MmcZ9KsA4EWcAuIA6KNIJ46jeumdomZhqO+JPBYDuGsJImNbLmHQ+YO R1J82Py99kVbPp7Q3s544BRgJzU+pcTLtEbbSBeY3LHM76IwbWGd/o4Bj5/tYfhjs9XJ xR/jnaagQFIlM+2tN7TbpuWfhCVv8YSiTG2WdWNtqFpYxyEYK25387s0OgpG3b1ygloP wcBWHm1rKSTh1Blq0AzNp7H4oW5r19VmC3AQARxVycJOuFkNnXXc1ITEaUIexiqy2Ymc VVaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678977009; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8tJ4I9ZiOnVv27V/2pSQJ0BPsYXHXaREO6k8Y5ACwnI=; b=H+hAtXQJccxT+zsQBvx2FD/Y1PkduCY9SE30ywiiSicIrLRhjbbK8VS/tZyVxRASF5 f4pjDquJsf0Ix4P7U3ygQhJancAK9164Y0Mz27M/T66H4LXT1vvT6r9XhP6EyMSvMyc2 a17V4m8cSQhbXYGR7Y4Lzi/m+A3qCYngZA7+EjhaatLxkNHtl9DoXzJVd9kq7aNNhI+N ZkgPYk54kSz2FE5NQlVQU0MNdp2vY4A+mAoHBZuiWZImcXqBip8liKtXhKIz/zr+CzmR JP9AsLgDL76N2F54hP5aqO2iFzfv9qAJCNHF2u+zQkRVQDSr/WTNJavtLKEFWtH8gwnO j9TA== X-Gm-Message-State: AO0yUKVKb9E5zObz7LBToKzpNZgqt1NUrY2cgRSSl/9lLr7XLHcumI0G J1sK5zSyfLMV4RvcAY7Kq4sOqDf1A8QioHa9LvA= X-Google-Smtp-Source: AK7set8SZHeDkSTpgT1aKVMpmUum/pCP5ZIxkPGNliu26fh7kkQe3PBQ/sCZGqX8TPWJpRG9Bd+6IA== X-Received: by 2002:ac8:4e92:0:b0:3bf:c423:c384 with SMTP id 18-20020ac84e92000000b003bfc423c384mr6287097qtp.15.1678977008742; Thu, 16 Mar 2023 07:30:08 -0700 (PDT) Received: from localhost ([2620:10d:c091:400::5:62db]) by smtp.gmail.com with ESMTPSA id l19-20020a37f913000000b0073b3316bbd0sm6023764qkj.29.2023.03.16.07.30.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Mar 2023 07:30:08 -0700 (PDT) Date: Thu, 16 Mar 2023 10:30:07 -0400 From: Johannes Weiner To: yang.yang29@zte.com.cn Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, iamjoonsoo.kim@lge.com, willy@infradead.org Subject: Re: =?iso-8859-1?Q?=A0=5BPATCH_linux-next?= =?iso-8859-1?Q?=5D_mm=3A_workingset=3A_simplify_the=A0calculatio?= =?iso-8859-1?Q?n?= of workingset size Message-ID: <20230316143007.GC116016@cmpxchg.org> References: <202303161723055514455@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202303161723055514455@zte.com.cn> X-Rspamd-Queue-Id: 3AEBA40007 X-Stat-Signature: tgg64ajyrz93b8zfcnrwweuxyekzj89b X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1678977010-495136 X-HE-Meta: U2FsdGVkX18/cgeUss7mTbSSGZ0ewFKGqmdpb8iMn0CnNUcG8DwJ5yG2QEBkAxNG4er5Cy24QjaK/eqVHoSDlZ9oHLbnMZy8KGWYMPb74qnR4HsfpG+4hsmKNl8MvjxtAYmdPVduYnB9CDLlj751vwNZLKIAZjkX+k21/zDm2aEO+BmQiuPq31GaO+OOPhBn2MsNhn4JXmBV4yxIo8GXjqxpA7XjKPFRK5C0kwn4AQGEurjOHY93qI8ej1HP0B9GSAxNyiI6xspcWRJto3gWzVpZPb4RJk1KBHa/f6PqP0+77qQ/4bfwtsb9WSudeUke7RErADrje4JmJw36IhMfOlLjSVjyPvFnLdY+Tjy5m5bIm2jtmG6Yl75eV5vAnRo/g5dqKEPttfb9wG4Vm61WOQUQePHE/DxULUeU49RgUMZ0b+QLewoQTY8pi72yswdQXreU0qQDlBc4lY6V3ahmNjIONH9550sdrzW+AAgcsw/UZ+ZX7VafJwfIdMGRdP/LtJaMRA308vCmU+Ttww/yOVUhv2M3taN6kb2DaI203aCZnTuk166cKbC0fZh/PaT5K+1fhjVKj5OWNz7QWfWPPZhNJX5B4LGlnud/ibm5Vn0ujFNUOP7sKGcdsGpcsR+HBIVk/asRWRQR0rYWQsAm0dSlJn+lsumTGdaZkPyAIdSFAESHkg7dKGeNy9thosMQd9Sy5FiVhRNYv4YVGUOtiF797XNRC6/pIzVn7ue7lbaXj3BaXCbHOwBkq/M5C3vpF99ZJ7qXiHDGnJgnWgwutzQNFLDidmbPLJMPfoev8TemimeFwyNf34eDmoDrvrIFs9XfDUG5/eY/LIpJal06cNMlRgQofJVydwDG30XaR50o3Yw9ix+pSurdE4P/KBp344WJrhByZxLxmMkGgSDyHHrfLIPBdFXSmQGZRv9k6dC+gw7bD9ECXcS6pfm+aItEsVDHCvhF2DZQeZ3wgn9 dsxaIyre mfqY807BQPO/1e0BhFhaCuXuHoeqcOStNuOMMzclMyIwnQCg3O3+yLuJDohgHuu07JhkzzH1XfADVqoULsfBal99E3NofcYdIFFcWAKJQ3RpugvLiKqL/CqkQsqBtZeULie8FFhBxbQLSlRYBU1hiPlSIsHGnW9rygqMwm9GIG257Bz973a4HVDU4NyInh5rNz/jnPyDP2jtWn+U4HkyAcYiSMBPyqVYtjn2YCkJjIsAcreTcaLMRMebBBb0WTwNJsabIeumiVyWmVnE0mZywg3zVftiaOl80hraImnzrkOB6yjCdV4aM0Q99euLlQpepKiLcsEiQJjOspVGa8DgEEUYr3OvrzW6MYQVCk9eQBk3I8+yqzpVRY1rB+9aFiW5z8/k+jt1m6Tw59NPlpkeWo+a1CfjnHLKwhQPSKMwR3FwUpM7vLJbrFQmKUGGsPnQXkj7ws4tEglTc4kbc5QIdP08acR6W8UqxjXEhWwppz/l+bwp6wAz8M75ZIc9cHREeR16+aw0gQLrvBzo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 16, 2023 at 05:23:05PM +0800, yang.yang29@zte.com.cn wrote: > From: Yang Yang > > After we implemented workingset detection for anonymous LRU[1], > the calculation of workingset size is a little complex. Actually there is > no need to call mem_cgroup_get_nr_swap_pages() if refault page is > anonymous page, since we are doing swapping then should always > give pressure to NR_ACTIVE_ANON. This is false. (mem_cgroup_)get_nr_swap_pages() returns the *free swap slots*. There might be swap, but if it's full, reclaim stops scanning anonymous pages altogether. That means that refaults of either type can no longer displace existing anonymous pages, only cache. So yes, all refaults need to check free swap to determine how to act on the reuse frequency. > @@ -466,22 +466,23 @@ void workingset_refault(struct folio *folio, void *shadow) > /* > * Compare the distance to the existing workingset size. We > * don't activate pages that couldn't stay resident even if > - * all the memory was available to the workingset. Whether > - * workingset competition needs to consider anon or not depends > - * on having swap. > + * all the memory was available to the workingset. For page > + * cache whether workingset competition needs to consider > + * anon or not depends on having swap. No, it applies to all refaults, not just cache. What could help is changing the comment to "having free swap space".