From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEC38C6FD1F for ; Thu, 16 Mar 2023 10:51:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 660CC900004; Thu, 16 Mar 2023 06:51:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 610A9900002; Thu, 16 Mar 2023 06:51:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FF49900004; Thu, 16 Mar 2023 06:51:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 40DD4900002 for ; Thu, 16 Mar 2023 06:51:17 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0DD3E41430 for ; Thu, 16 Mar 2023 10:51:17 +0000 (UTC) X-FDA: 80574444594.19.9928122 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 5F2AB1C0006 for ; Thu, 16 Mar 2023 10:51:15 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Z6m+LgZx; spf=pass (imf18.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678963875; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iJ2J75uN7wPQg3j9Bp5LrICOTgGz//QXsSxGz12wSh8=; b=32sKO8hjP8sw/sTPNOcNn4u8qjOW4KacE9/ozf9F9MF7uny1KxgF7lF7xEuE7AU/jG9L19 c8vPL3u26DSQ5BhySU3fvkH/XGVsr6FggVWRo4KuZCp3BagveipRHUzxhY7CQVNRJZUA2B 6KVp5AGAdOiOOLARDE8kSTngDCJsPu4= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Z6m+LgZx; spf=pass (imf18.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678963875; a=rsa-sha256; cv=none; b=LPVykfc0ecv3SPL8RCphpaPM3ebJ7HK5I2ggXqyo+qFwmoRLOvK88qTKA6j48X2f4NsQrm dBE0rcVRNso/2kbQLPcK3jq+xEjG7OysFqWZ5HAK6zHQppr2Nbn+cTkodpdaqv+p7SC9L0 A4rhOtZOe95obiSJSg1VIjiCoM9/VmU= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6647761FAF; Thu, 16 Mar 2023 10:51:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8D23C433EF; Thu, 16 Mar 2023 10:51:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678963873; bh=o5wa1JMj2zzuoLzQAkHij/fz/01C48xRb+au5j5qJNM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z6m+LgZxyPxAv9EF0QM2ILFfjSGfBIs2q0m7UE/ox2P47WZ0IVDQkg3dTSnGKjT+S df3mIO7yB5DdnIXxeKDRagCzRKy4eAceaSzGVP82Dj6INOgp1E9vUpeHCCyWwCp0Ek CsP1C15KG2u79hUs+oj5wp3XpOoFIfZfagjTdNjLpRbpo7w5RPTcKjanjqpw7YTIAZ m9c4vzCjjwPiSzdOjh4uog3ibSebCMwFEARA/HHuui3y81y0E/Vt4+58VS65hjPgPK VTy4dj5G35wcUcdjocnS6mYptUQP/m3CTeMatassVYe+scqaZ4yt6M80ZrXWJW9b83 OoUzAKY/vg3Mw== Date: Thu, 16 Mar 2023 11:51:06 +0100 From: Christian Brauner To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard Subject: Re: [PATCH v19 09/15] iov_iter: Kill ITER_PIPE Message-ID: <20230316105106.cqo7equqxzw342rr@wittgenstein> References: <20230315163549.295454-1-dhowells@redhat.com> <20230315163549.295454-10-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230315163549.295454-10-dhowells@redhat.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 5F2AB1C0006 X-Rspam-User: X-Stat-Signature: 5ogay5gwknh7do15e7h6wp5kyskdazqr X-HE-Tag: 1678963875-206477 X-HE-Meta: U2FsdGVkX1+fFwEvRdjciyRuyyqhqit9fOUjmxBa08OQ+43Xs02U8FxEQjEuVO0HdH9xSp+w0vXA/2jDognbBwujVQnQY9JU47Aa+o4BVLUMW0MyJ4tMaZ238uFA+pNlgrFGGpk3ol3sRGiYW3083urjakY9oEgFKdTjgPwr2Ch1RrOct3Vq5nelwkMBTysuNsMmhe3ken/4ZkYTh2w3i4xyN5lIOL4uqfGzjk6Gydn5V/8qAf0JZzYkiZi6OrQ1+nUVeB7UTcCuevHJURjsyyDZXDpYAOpVmsPWbQMeoB50tcJFObWOTcHZb5D9mjYjUVxBeznVBTS017EozCmc+IzRhVfxwrRaGz5NHLvk3UQJL4pvSPPu5IXHWYAMiF3zKGU6LJqJHQnZ0LmelKAKPWn4Z99n5lGURRcSmNQpfcCzv+6Ha0XdFLzK/+QEsmKHPFWrY8O98xn7u8aYoCECtFrGfw6RL6W4cOXGkAI5gdzsjGNhYqgDozmCdkck6XMPSCWwyZ5G/HS+rbW6OYcOG1/kT8QAQt/O5eWB5aAOvABRQv0C8KoaL3iw+YXwrJ6/mouluudnoJpsCE/LKtYlEk/4/y3hm3MEFaIOC5evgnDEzfwwDpWLk/yg0Kplzxw0N7jqm2uKIfZX7IzoAV0ckEcpmQQeba5z9M8BTU3mSWiPmKvnlHglr2N/pPERIj10WVkL+4eVPzwWvLnz1ikvk4mrjxxfiFbK8cWtgGycapBZupDOekUrLwkFEh7J1j9ztlrjUKXSX3VpdCNdJi8NCoA5S0OMwSTjPwfvHq3k2dSPlbkdrpcGbJQxjwleN7uvBx/4AVe91iaraq4fO4Lg9g26pR1JQvVSDCGA7BUnPR3bq5RUOQVZyVa0LeZSIwpJJCXqNvdg3LladQfS4Pq16CEiX0kRR5mq313uBFycaFgmE7A8O4sZIY1YDc3JEwkc6/b1CZ7PaEtnSSOL2xa 7TnuNA43 ixbqezYG+XUxs5nbrBOhDAdlotAbjoeBey9ZanWlvcFhPzhpdzx4jxMjR+u+pSIrIvHt8l9dcEx4d6rONkYq1UYpZo8yyB8HvS7Ti1pO2fUssZ7Zx5Iwh5Z6AUR5/eJb75STIZ9dGeTq/tNLFVVuPHUj0/ZY6FH9f76+/ZqZ2kGQ6mdV0YtdbcJAPtYg+VGkGW2B76bgZB77FL1nJKoraNRBY9VlleT/CawI6+924Xt3pEZTv87eGXL9pg01d1L2wkAhViY+6duT2yA8jZ5Hz2I4cpI1mHwyZa+/QG/mUUTkPGnoASzb1Ov1V8abWZIvj4F9HYxzB37QVxABDlfKtihWtCFW732Gi8nal8cAGNqCOaYeNmKEl0Vwx5RO+7tBBYlJNCM7LAMG5imatS1QqQ/pPCqQYE51eRbkR7cWAGczcWnHoggA8a9SX5hC6LQWgdYxXHLCXeOcxabauwkuBSj5ewr1Up0zcVo/5Xov6eDJRMrH8/bITv/Sqf9YfcsVRCgd7XRDGRztVLU3EmmXqfJ3On/chTO9fu6LaABZiD/ZpBzWuuUmsYj0/2azJVq6LGIE5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 15, 2023 at 04:35:43PM +0000, David Howells wrote: > The ITER_PIPE-type iterator was only used for generic_file_splice_read(), > but that has now been switched to either pull pages directly from the > pagecache for buffered file splice-reads or to use ITER_BVEC instead for > O_DIRECT file splice-reads. This leaves ITER_PIPE unused - so remove it. > > Signed-off-by: David Howells > Reviewed-by: Christoph Hellwig > cc: Jens Axboe > cc: Al Viro > cc: David Hildenbrand > cc: John Hubbard > cc: linux-mm@kvack.org > cc: linux-block@vger.kernel.org > cc: linux-fsdevel@vger.kernel.org > --- That is a good simplification, Reviewed-by: Christian Brauner