From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E75CAC6FD1F for ; Thu, 16 Mar 2023 10:47:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5EEFD900004; Thu, 16 Mar 2023 06:47:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 59F15900002; Thu, 16 Mar 2023 06:47:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 465C0900004; Thu, 16 Mar 2023 06:47:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3490A900002 for ; Thu, 16 Mar 2023 06:47:55 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DD7DD806CA for ; Thu, 16 Mar 2023 10:47:54 +0000 (UTC) X-FDA: 80574436068.23.C568160 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf13.hostedemail.com (Postfix) with ESMTP id 28A2B20005 for ; Thu, 16 Mar 2023 10:47:51 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GHUYMytm; spf=pass (imf13.hostedemail.com: domain of brauner@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678963672; a=rsa-sha256; cv=none; b=jVoo7MWxEelA8O0TzjDrG1/7hAaKWpWVJYhw9bW0MaJHURV81xQMJOofG+SLrgR+PZgbv2 SBn7tPsZ/Rld9uDnrQiaR8jQ7vX65p2/5M7lT2SMhZeZVvox1wHQihhZG+qZqHqljapG8K oKgqz9x7yAI1x6EKWSUUAF+fhVSUVPM= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GHUYMytm; spf=pass (imf13.hostedemail.com: domain of brauner@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678963672; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XE5j5FAubuJKeneaijCn9U2TSAzDeYCx2pRluq0VN38=; b=naRmHMMVhjkjPpUw9onhSfPOgAJ4J6nJXDivwgkZG933geHUKRZL20MpyYqB4Wc+Dt0jsc /HWeR3tJE0TabtbvFwJb6jgvtIVc+hBl6adPbFrpgJV/SKAyYFCuW6jgnfd5Qa6JcCnb71 7rAIZxzN5yfDmCduCllTY74VHSSafCI= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B775FB820EC; Thu, 16 Mar 2023 10:47:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F5EDC433D2; Thu, 16 Mar 2023 10:47:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678963669; bh=adDp088lfsRx00jTnzbgcWozbhk6SX4/HzArAfWHhL8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GHUYMytmwKFfch6AOme8SGcvXM0XGlwVDta3+wv17+MoBHhMIZMmmzFaV0kOah6Kw WI/SOSOBeeznqsCWoXSVOz4ylZFi6ylsikplsJ+6EmqLQAHFzYNwKBDa9nnFt+q1kd cA/N1dhpg0heFYO9eZWsjphZq2knApXmNn4r5mFM4uAWCpE71ZaXk+8525L5BDWLyB gTI8WgYYRFT6xGidQidZNEQ4g0HIaEcM/dqrzhYXddqRchl5p359TBnas7gyYaVIMP B65H5dPF11JZbxY23Y6LDugpZl3OxMaGq0rDZU8NZvLx2ylfx1S5kTaFiO2agx7rZ1 j9rCZtThEheuA== Date: Thu, 16 Mar 2023 11:47:42 +0100 From: Christian Brauner To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard , Miklos Szeredi , linux-unionfs@vger.kernel.org Subject: Re: [PATCH v19 04/15] overlayfs: Implement splice-read Message-ID: <20230316104742.hstef2opz2atctl6@wittgenstein> References: <20230315163549.295454-1-dhowells@redhat.com> <20230315163549.295454-5-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230315163549.295454-5-dhowells@redhat.com> X-Rspam-User: X-Rspamd-Queue-Id: 28A2B20005 X-Rspamd-Server: rspam01 X-Stat-Signature: nue7ozg7naxta9zmss63obbyerpcw4ux X-HE-Tag: 1678963671-569351 X-HE-Meta: U2FsdGVkX18UbSZv7yBDMs9azyPp8lXc0ly2r+b1z+G8D959fW5QfShi81SUMmiMcxmRDdga27lzORkMRnDcA3KYVqU8zgqsGzVcb+YiiTFNOhyhtvIyXlmFFJRidcCoWhLI1nVbQqBj/EcC08tuA9C/VjznabJlSHFuXGNlwnj1DtKLtZcbMaDvoxTPvlK98ta1l//T4YlutLu3Z6R10BDZDF/cONV7DwLKYOB9AoyH0QbbxuPMC7f2DYvt01d6bZZEnFjRi7t9qwpB+HwUsY+ccLdOxFaopwPiOkNCOejwb+Bfo1+TQzm7iIkEC9bAD/Z2wEwHbknTYHKkBtxwQAarK9PlvJCANW78CG7w4GKuS9jQwj+m1GJRphQ1MxwA8kFSJ+/BGVl7jcZ/xfG+voWCNJ1bcs4MOTdX1j3LF3ZgmT9Hn86AU2JQFECmbzZw605/dSj3K9xfI546lDDxZFj65Gmg0maBKU6DphTJ6c6uhNm9B+A0lnC71GHT6s3Omdhbn/hcH5kE8oMQ4Q8BDDlChSqnSIq6/SqB73+Lh2VJ7Ev9mNWW0aoet8EzY97fgk+gd2moSqkp//sN5dQGL4hyjOnTwXbYdc/e9Ilax52QhVZf8OazYxHGM3BU/JPDaRkMqN2bc+SyjyGLILoWeoM7dJFayZDrMTX6bTQJhB71kBkHDYob0ddcHEOdpojZExZnFtsgroqjrFmpatcTURdQPCOTbIcLxxWJ1fliepZfIkPXpNGh/SPvNm3y0VaBaKYERR96+jfSOCsDtb/j0O4nDCeLn9ZbslMDrFlYrev0qTWDRQKKezl1Gk2vVILVgMvTnbzaQQ11SOqf3aKyE7VCxXvvQYEAEwmovtsTiHPSXGEspqaPGQuWNgUbsgCbp4+IbOxpElGqd+oBYy+2GSB47NoJ/P0CXIb3dD3YkvqAf4Z7qvsFXBTFw5WFhd0FU5T1/JHGYSYMuUIreoY YrGmq0+D xGGyOj7lYiqAl2d3CZmSlIHa3cMdE0PB2vIqxBI1PCCWb9chL8Eum9HjoCI4j5WkI/kO9QmjB81YXo1K3vgd9oTI0T0o1D+yTum0VruWFWt1u5Hob28+dA4LFb0uHN20+fxMlnO1S+6kBZuDPRy8wZN6xuQ/NqQOA+fLajAzr6p0MhPws29W0kEMHirfrBhhKie+n+fUX/Hz6O1dmEbP+4XdDKOI3kov+Ma+SyOeBF7q6c2MzOa+I8IJE5iUOhcip7Js0EFz8trzUwka+MPPzJQPpfZEXFljHrKUxOAOqArchFr63ATQvXN2pfjJmp/mJl0CHitxvVdxDC1CDAAsMKRdeqUjGY3BMooDFELjqPqtC5Qq9wflgkwMSNgfy7CtHHW32RYO3xFOOvYI6dJur1eWuwDS+4WowXzD96rdiDdbxISmIaI5ha11v/XhKtQ00wSdeJmbHaNiTYVyLS456Na92Pwv1Ka3jfIMH8MBqnk6J1e0ArVqaqCX1zw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 15, 2023 at 04:35:38PM +0000, David Howells wrote: > Implement splice-read for overlayfs by passing the request down a layer > rather than going through generic_file_splice_read() which is going to be > changed to assume that ->read_folio() is present on buffered files. > > Signed-off-by: David Howells > cc: Christoph Hellwig > cc: Jens Axboe > cc: Al Viro > cc: John Hubbard > cc: David Hildenbrand > cc: Matthew Wilcox > cc: Miklos Szeredi > cc: linux-unionfs@vger.kernel.org > cc: linux-block@vger.kernel.org > cc: linux-fsdevel@vger.kernel.org > cc: linux-mm@kvack.org > --- Looks good, Reviewed-by: Christian Brauner