From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20285C6FD1F for ; Thu, 16 Mar 2023 10:43:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41C21900003; Thu, 16 Mar 2023 06:43:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CC29900002; Thu, 16 Mar 2023 06:43:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BB8D900003; Thu, 16 Mar 2023 06:43:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 15F87900002 for ; Thu, 16 Mar 2023 06:43:55 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D9A6641430 for ; Thu, 16 Mar 2023 10:43:54 +0000 (UTC) X-FDA: 80574425988.10.0999E18 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf28.hostedemail.com (Postfix) with ESMTP id 18F8AC0007 for ; Thu, 16 Mar 2023 10:43:50 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="kRu/lN3r"; spf=pass (imf28.hostedemail.com: domain of brauner@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678963431; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v49nB383sVhIx4uVwllVZoCrERjgFXMmnou3//3InME=; b=X5gr85L49/mrmB12oiwVFEHJ3wJaPPx+qLutQn9b1bkLvods6O0bgbmiSzOyISzq7kccXi SWcIdHS4zSCsqT0RuaePwu15oJKy7w/gPhsFBt5NmRXJesar3YR/aTQ9qTDZIR+9ysOI6d hPB9dBe5bKmlI/92Lgnyddn1cSm/k1E= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="kRu/lN3r"; spf=pass (imf28.hostedemail.com: domain of brauner@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678963431; a=rsa-sha256; cv=none; b=fLxcFMgCVkWbIgHE2n8JQrBiJyj88CgxKcJqWADXygfWqCIWLLbRSt0mEOWsz+ilsb6HlY iSOmEEiQcolg7Tc4y6UDCm7BIlHK57TNLQMcMyAaWD4pvzxQ8XAmvAL5g2a/8dM2yMWcRs DyrgJWuGUGBnLpXPZ/61wFJW4P47IzM= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 26765B820D1; Thu, 16 Mar 2023 10:43:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F7B2C433EF; Thu, 16 Mar 2023 10:43:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678963427; bh=ivnRtF0Om5eiH05K2UCaWLsj37t/Ps4vxjDE7lmPdVQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kRu/lN3rrdr0jwR4HeZLvBm5trwz130o230jB/iSGYgR9L0ucM8d062SfHyGNV7kD gcQbh3aKnPbmEmTWU7Fv9Xl9IFbr/N+AaVGR313Tunu5+PE3Q9QdefBjjiz/kggBVJ HvxxXFbTekZCZPfI4pnxwbDYAh46aDTghGZ7gLixsJSEs+Yh94oLRGGZu0/vH7ZpI0 8sbQxfqd4d/V/PKUit+Nj47r/MDl3PvvzM675hBoNVbptp+ovSo9zsSdwIr6R9693e KKTU7wvoIopClpK1X6j38aAlAovuGoqutJjo7Djfwu314JAkoiZwsIk7mNe5ATNVwc RyThUK7axbBGg== Date: Thu, 16 Mar 2023 11:43:35 +0100 From: Christian Brauner To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Steve French , John Hubbard , linux-cifs@vger.kernel.org Subject: Re: [PATCH v19 07/15] splice: Do splice read from a file without using ITER_PIPE Message-ID: <20230316104335.gpgfeigrnvdipj52@wittgenstein> References: <20230315163549.295454-1-dhowells@redhat.com> <20230315163549.295454-8-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230315163549.295454-8-dhowells@redhat.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 18F8AC0007 X-Rspam-User: X-Stat-Signature: e8tzw1x4wsd8mxzkxhwuw58gfinykocn X-HE-Tag: 1678963430-655276 X-HE-Meta: U2FsdGVkX1/BZoM13fVRjfSkc16LQORL+dkwCOoDz202fQylf5XeqIwgJLFseEHTizPHw3AdedciAG3eC7Sf9y+lag2KvYpxoBR2hlckWOD9EwTdsPbKHD31VIwgkIjV3tAV3M6DHZnM94NYmAFIzn4WFwweyc5hS6eF1KIwnY/84CGekHtKc7aF27oKhUIkoOLnQuVZByXg8qcq9mbaTYi5Dv1oH8Zj0BZp7LrJaNuHFCjcJmUNWys/jH2CywnLkzwjRlIbi5kt3QRnOOk/+QU6SZ/zIpDlm/NbvEx+NWN/zhipXDiy0QmA3N/fxxd9PhRAjcTdFS3lqBeUqv0ZoAAtvEwppaHp58L++YLJzZWjEKZeMbMRT4UBitG8Ge10wlFGq88gPDytoU9tJQdYuMt7U6Mo+kUTxum6rZqJpCuQDGdSFcR66YUK5C95kCcGE+x8N6BGNZyY52079f+AJpikbWunjHSwzZiSloro3ozA6uUo9MjZn/DNwAIHpTfR7+adpHaJQ07AV6hKWiDR7M/DYKA/LnLcIbuyyKAuien3Mf4UC8BsqfxV4LaGHtRp2t+QPm2M7pGUR0C1vv5dwXGTi8JMXs8TjHWn8Tu2hoB6RePKs3rpvpwTIJaok06JExLwNVW20NsGQ0gpyvxRaj5D5B7HuGPY0lAaybyARkI0IDd4mcqsWhLq4aQpVhqDFi7hwfQP6asEGetVhqVKYBZtCgjp0LHeewqaWDTmGzNVSwaudEi+VicK0iHpZ4KZF+RlvggwnbumsxEgPVIqRdzk0l3RXwB1QUy2mYB4GqKf9nb8FbaHqEjwdsWMHotDW+5F/BovfzE6YlC41qX+WH9VGAq0134GarTwx+v+tUAY9f/IzLNm0asBTU26+gCa07Q2h/SDeWr2KmJbdQ8irPgZz2EfAeaN+V6N6vvxAu5CfTmEEMTynBSyGAp2r0XW/aZmDD29ao7T/H4Chsk gN0ZbEmi /+d78pQYcKtD1CbyziEfvnqT0g3kwrGgE8Lmux8fwa/4jSPeF9PfulZByEhaAuEVPCxtsaPzrlkB2ltcAKj2b+I4/EsdgY/mV9F+XwuwEIZoarAxAPOx5Gr3wtxF5M7BybS1AUdytpRDPA7ZAtY9qsBG9l+yQ6Uy0UDYu4aIzoB22RQVW6NemsbSS/dU3aYcw8dmtNbNwV96Hy3zbbXCsFFJFy/y/Ipxr4/cMHS0b+4Aw4hP6qrKYnV1HNXvsFheMAy6J38+cX+nNIFmb4GVWP5X18/1on+EHXwx0EBALfY71zALMyv4FVugXzTHSztpLPz9flIIVlgrod3nl4Hz4PQXeEmlUFMrP76c1ibU5GjflQ3WEXQq6qKuzF8/NtuZHDMuGhBMqE3WJ6SVNyAgd0v0rmQezOD5ISWLLYBvdtIWrMUDF1eUo2s2RbAC8A3Z91YIlI+069oSloyO9/aTGrhvJPAEvuDdo7AI4q4+nJVxo963BuYGElUeBReqS8DtlvIse+UGIk6FPLRaKCl3plt1KL9YiiqzUTyfcKb8ILyv7DYwQ9bE+VFJz2R+hSSg+WxE8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 15, 2023 at 04:35:41PM +0000, David Howells wrote: > Make generic_file_splice_read() use filemap_splice_read() and > direct_splice_read() rather than using an ITER_PIPE and call_read_iter(). > > With this, ITER_PIPE is no longer used. > > Signed-off-by: David Howells > Reviewed-by: Christoph Hellwig > cc: Jens Axboe > cc: Steve French > cc: Al Viro > cc: David Hildenbrand > cc: John Hubbard > cc: linux-mm@kvack.org > cc: linux-block@vger.kernel.org > cc: linux-cifs@vger.kernel.org > cc: linux-fsdevel@vger.kernel.org > --- Looks good, Reviewed-by: Christian Brauner