From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95A7CC6FD1D for ; Thu, 16 Mar 2023 02:45:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6A236B0071; Wed, 15 Mar 2023 22:45:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF31C6B0072; Wed, 15 Mar 2023 22:45:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 993FD6B0075; Wed, 15 Mar 2023 22:45:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 812B96B0071 for ; Wed, 15 Mar 2023 22:45:22 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 38D9FA129C for ; Thu, 16 Mar 2023 02:45:22 +0000 (UTC) X-FDA: 80573220084.20.5934137 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf14.hostedemail.com (Postfix) with ESMTP id 5E4FE100005 for ; Thu, 16 Mar 2023 02:45:20 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TSOlPenQ; spf=pass (imf14.hostedemail.com: domain of isaku.yamahata@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=isaku.yamahata@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678934720; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Av+oX0XnbDdNARNcmN0g/sKvTcF1A2qXjoo1gbUEn+o=; b=fve3D5jPOvvrokOuIaf3DztRoYnfBCqlM5T5ZtmD+j6U4YprGBvH16k6UedUORa7cpe8xG oChn6XMFH+lvU2uRDU/7ap7OtNG+j4wR321vClTk7sbHlHlQ9Xj8EexPn2DsmcbI6JbGiX dUJZeJLnona5nJ1Yjo9XqVvjNqNXd9E= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TSOlPenQ; spf=pass (imf14.hostedemail.com: domain of isaku.yamahata@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=isaku.yamahata@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678934720; a=rsa-sha256; cv=none; b=AkCac6dTw2kjIRi8V76rWhbOC6TDiqmjVQjsQAm/qcY7MAmU4CsmkBEHFJq6AM69QrI7Z2 yJ6h2iuYxOjLNAmfobIk2uehwhAgIhq4Ygjlf99NRzuiiP4pQJeFLCF/i2Y24M4/6af77o 8ND4SYSDPU2Aevcal9ioX3Cf2JCTwxk= Received: by mail-pj1-f53.google.com with SMTP id om3-20020a17090b3a8300b0023efab0e3bfso3780796pjb.3 for ; Wed, 15 Mar 2023 19:45:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678934719; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Av+oX0XnbDdNARNcmN0g/sKvTcF1A2qXjoo1gbUEn+o=; b=TSOlPenQOpkkWNYzq2P9Xss496yyC1hfvDnQg/Whu6Z/ySk+ZrUohBciKvTwT5W1mZ F+53XH+fUZ8/emXjPKr0Rjue7Z+CvOX2O/HCkUDLrQBx3WjH1Ck3eE2gjfsLQro+gY0s Mnqjo9PPIn6dnyU+XYqX4n8DFkefoUk717fRKXBjSzx1LcrOS4b7BQ6FcJ0lEFrKnzRu x6NhaV48BtE1OEL1/G2ut0Qz3dxu9QTxiDr7fiY8C5Oek5GB8IApd/lweYITxy0o56PV VDxGS3PdFIgrLNEqje3c3RRADNyyzyDLDqzi7W7T0/Fw55zuPMnqvk4Qnn9GStExstZ2 hG6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678934719; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Av+oX0XnbDdNARNcmN0g/sKvTcF1A2qXjoo1gbUEn+o=; b=C/cnMAIgwhrWHIcZPXIQhfJgXWWbAJjkknoZngpN4f9FtXOD/SgsuhKqSARZ5EyZK6 rx5B/vXtdL0+srt8PxWH1GsvVgo4N9/m9tpfALSMy2ok+lSkvOsTAfFruOd7vPoxKmM9 Kfkdajh1B2OH8tRYjyFY0Qhh/HrvH6Cx1JnMmg6Dm1ltowFuaIbBOzYz5d8pr5/SAZ54 JtxqsXIC1icLfRn6RHggwIlES+8fYaZPTBx6IddIul3ihj5oeJf+S2tRx8in4SD3Zl/9 IRHj05FpxsYNCCv3u+p+9xRB5H/OkTAzH0DI8fvzZx7fICyDHaN3E15/2zOeq1EuAzA4 HyUQ== X-Gm-Message-State: AO0yUKUHY/2eVR2VkoRm0sUhVtujPDD0PV7RNNzTWmTAI3/vbcB31fh+ KLXqQgKtTlqMS4bLd3+UYOU= X-Google-Smtp-Source: AK7set8xm7nDqKehvLTCj4Tr3ZoXrci3aHs6MQE/gwPsjkrqR2h18M6L4QoBBSjK1afrPjludTGkJg== X-Received: by 2002:a05:6a21:9983:b0:d6:bfc0:54e6 with SMTP id ve3-20020a056a21998300b000d6bfc054e6mr1784963pzb.53.1678934719087; Wed, 15 Mar 2023 19:45:19 -0700 (PDT) Received: from localhost ([192.55.54.55]) by smtp.gmail.com with ESMTPSA id u6-20020aa78386000000b005d3399efd80sm4176609pfm.136.2023.03.15.19.45.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 19:45:18 -0700 (PDT) Date: Wed, 15 Mar 2023 19:45:16 -0700 From: Isaku Yamahata To: Kai Huang Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, dave.hansen@intel.com, peterz@infradead.org, tglx@linutronix.de, seanjc@google.com, pbonzini@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, kirill.shutemov@linux.intel.com, ying.huang@intel.com, reinette.chatre@intel.com, len.brown@intel.com, tony.luck@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, david@redhat.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com, isaku.yamahata@gmail.com Subject: Re: [PATCH v10 05/16] x86/virt/tdx: Add skeleton to enable TDX on demand Message-ID: <20230316024516.GA259042@ls.amr.corp.intel.com> References: <20230316003102.GB197448@ls.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230316003102.GB197448@ls.amr.corp.intel.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5E4FE100005 X-Stat-Signature: jxryfrqxzr8tq1kpw16cer6j3a5phuo7 X-HE-Tag: 1678934720-527446 X-HE-Meta: U2FsdGVkX19ys1/x8pmCSZWNk6W2OmJPSfrJCJAra3cgkQmggBop9mW7Z1Uk6g1Tm3qop/bu8FFa19+D/YNlMnR82Uxs6jOf4EnQ5flVrHj4OT1asAUQHxE/lLTWiHqhnPiRNZA/UVInpUwqmkIqF1Iyng9Kcc3oBMj2W6FlBMAEikBkH6tL/jPY+CN22Sd9XAIirQ65IA634Gfs6sl0dtFgnQBwg8W882tFDnMjxN8P0MLWeE+VrTTy5tZMHpjN2MCwdimI7MgKAPjhApxZs7EfLdNd+QBm8Mk6GGSmLog20OiITk5vD4ADaKPndxp4jjLKfgOIqeKUYbQk3n9ERSBlSXxqlCvNnnJW7q5vJTUHK1j6oTr6W7b4Ju9WIS/pY6/ViZKPOCd9kP8Uy1XXgR8USXI0FfGSAIlmdiAajq2vQ9wYe5vkV2TkkvcCXoS6YG7UO2ZZWU4txsHc16H/AmzMsl3mx8Zbk0aqFqPXpgbRVgZU85cTsSQT/aQDgAaefeUOzCwoFTm7APFv9u9UUJGan50qtdcCY1PIKN4itXlkyVuaueQ1nnnHi+nISAR+grhfU/OXawjN8eVm6vr8s2WULfe9279xFrcPFSkRu/luHxMnYkb0jHNNOPkqnwU3RYlUFuDZriR0In5BIkyWkcEkQQYP0WWyqPTkqfp3FWPOF7LRTZRdvao9WJceFpKcajc6By0anGklInnN2qWsNdgovEzUtq3879GX2nAJj5wy0uT2NrWhjl831cpS7+Ndn85J0mTZBQ4dLaYJd+3vWxq8jL/6lUsZSF1MRZUKrjz9TRRzRBVlnI75DUH220c0WHKCj+XVxKjTJIYlFLHIKgZY1bCvsD38rZOd+WrEXBhmFMRelVpLakESgKgl/hZ+jCTzDrPgDboK20v0BR/OOaWUmLxnaGyg50QkSXyQgwAhQHAYf6Daghch/z9sIQPrOae80fFTWLrxKl24oHV 56lkwiCD wvumjBNwS4jIY88Xy5qUbSs0hTcOtk6wG5K/mcLPfBQDfOJp0SIQJK2Sq3PL9zxtwJmAp6uWapCJTM+b8QXvWkkjm6Qy3F1FNN/xb7Fy/OF7qXZ4hhaHjIYHWpjyHrCsrem6Mawk7/HPgAPPDfYA1O/bZMQSqd1n73BFqmqTnxWHzgAYCnNPiWSvZhX5yRk284KovYLv4+LdfrCJKTmtzKQaY2oq01egCZEbfFBL3l+LqIoyo3XyKywUJ3xRgs4ISEWNU2ppfG7EkwBCI6/9kSBSWLrPjdD4jljFG8d3i8b6Ifr5CU/8sciUHv5uIfR8KafC8Q+3fjjl4hWzgcsWj96YzJ3x1arktOlVkwFb3RUxChNz/l4+F8Q0DHncyBS76JfWftv8F/RbvjwiB10PaX6CFDKCH5q35UbQ4NUEKd8SYtzicrDzKNm3dwcpTMCYwSU0+5gB7RKEm7nlC6/MpM2fvhVqOLGUqUS2O2qVzcLfiliiU1DDgMtt5pdA25MB4RXFKZF9cdasbj3/bfn149fT/9MH222oGdC4YhuDHCEDuq646FwJNdPz75w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 15, 2023 at 05:31:02PM -0700, Isaku Yamahata wrote: > On Tue, Mar 07, 2023 at 03:13:50AM +1300, > Kai Huang wrote: > > > +static int try_init_module_global(void) > > +{ > > + int ret; > > + > > + /* > > + * The TDX module global initialization only needs to be done > > + * once on any cpu. > > + */ > > + spin_lock(&tdx_global_init_lock); > > > If I use tdx_cpu_enable() via kvm hardware_enable_all(), this function is called > in the context IPI callback and the lockdep complains. Here is my patch to > address it > > From 0c4022ffe8cd68dfb455c418eb65538e4e100115 Mon Sep 17 00:00:00 2001 > Message-Id: <0c4022ffe8cd68dfb455c418eb65538e4e100115.1678926123.git.isaku.yamahata@intel.com> > In-Reply-To: > References: > From: Isaku Yamahata > Date: Wed, 15 Mar 2023 14:26:37 -0700 > Subject: [PATCH] x86/virt/vmx/tdx: Use raw spin lock instead of spin lock > > tdx_cpu_enable() can be called by IPI handler. The lockdep complains about > spin lock as follows. Use raw spin lock. > > ============================= > [ BUG: Invalid wait context ] > 6.3.0-rc1-tdx-kvm-upstream+ #389 Not tainted > ----------------------------- > swapper/154/0 is trying to lock: > ffffffffa7875e58 (tdx_global_init_lock){....}-{3:3}, at: tdx_cpu_enable+0x67/0x180 > other info that might help us debug this: > context-{2:2} > no locks held by swapper/154/0. > stack backtrace: > Call Trace: > > dump_stack_lvl+0x64/0xb0 > dump_stack+0x10/0x20 > __lock_acquire+0x912/0xc30 > lock_acquire.part.0+0x99/0x220 > lock_acquire+0x60/0x170 > _raw_spin_lock_irqsave+0x43/0x70 > tdx_cpu_enable+0x67/0x180 > vt_hardware_enable+0x3b/0x60 > kvm_arch_hardware_enable+0xe7/0x2e0 > hardware_enable_nolock+0x33/0x80 > __flush_smp_call_function_queue+0xc4/0x590 > generic_smp_call_function_single_interrupt+0x1a/0xb0 > __sysvec_call_function+0x48/0x200 > sysvec_call_function+0xad/0xd0 > > > Signed-off-by: Isaku Yamahata > --- > arch/x86/virt/vmx/tdx/tdx.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/virt/vmx/tdx/tdx.c b/arch/x86/virt/vmx/tdx/tdx.c > index 2ee37a5dedcf..e1c8ffad7406 100644 > --- a/arch/x86/virt/vmx/tdx/tdx.c > +++ b/arch/x86/virt/vmx/tdx/tdx.c > @@ -41,7 +41,7 @@ static u32 tdx_guest_keyid_start __ro_after_init; > static u32 tdx_nr_guest_keyids __ro_after_init; > > static unsigned int tdx_global_init_status; > -static DEFINE_SPINLOCK(tdx_global_init_lock); > +static DEFINE_RAW_SPINLOCK(tdx_global_init_lock); > #define TDX_GLOBAL_INIT_DONE _BITUL(0) > #define TDX_GLOBAL_INIT_FAILED _BITUL(1) > > @@ -349,6 +349,7 @@ static void tdx_trace_seamcalls(u64 level) > > static int try_init_module_global(void) > { > + unsigned long flags; > u64 tsx_ctrl; > int ret; > > @@ -356,7 +357,7 @@ static int try_init_module_global(void) > * The TDX module global initialization only needs to be done > * once on any cpu. > */ > - spin_lock(&tdx_global_init_lock); > + raw_spin_lock_irqsave(&tdx_global_init_lock, flags); As hardware_enable_all() uses cpus_read_lock(), irqsave isn't needed. this line should be raw_spin_lock(). -- Isaku Yamahata