From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04A3BC6FD1D for ; Thu, 16 Mar 2023 00:31:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B2996B0075; Wed, 15 Mar 2023 20:31:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2627C6B0078; Wed, 15 Mar 2023 20:31:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12BB86B007B; Wed, 15 Mar 2023 20:31:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 021346B0075 for ; Wed, 15 Mar 2023 20:31:07 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CED98ABA45 for ; Thu, 16 Mar 2023 00:31:07 +0000 (UTC) X-FDA: 80572881774.23.ADB0649 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf06.hostedemail.com (Postfix) with ESMTP id 028AD18001C for ; Thu, 16 Mar 2023 00:31:05 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="WB/xmzCs"; spf=pass (imf06.hostedemail.com: domain of isaku.yamahata@gmail.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=isaku.yamahata@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678926666; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9KhrkJGSUOYiiVfotnNQfrQRu80N+GO4LCzY8Gnj/3w=; b=jdZTMVCbo+QteC7pVFJybQUU6tjj/SV2OoSCnx6tEy6sD2JNt4R62BsJZ3MqkZKUmTcQ02 1eejDjJSQXIYQI6aeL7s2nxvxeVe4Zzlaeak5OlsxCE9gda2alAGJ9GAY6U+ULduWwha4B af89TOaO3grb9d9FjV1h1efSKjtSWls= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="WB/xmzCs"; spf=pass (imf06.hostedemail.com: domain of isaku.yamahata@gmail.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=isaku.yamahata@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678926666; a=rsa-sha256; cv=none; b=XdJcLN1EUmw1r0c4vOSssgw++khcvyRZBLdUzuFJ+7v00pLKhA67vJLRQMz4GqYA+u1Yfc 2G6kFpN8vaoxmbtx//GNzXkpfGzkXF5VgG8CKgFqPWJA5UoBC2mHkFV85E29MJSZMpzG3z spAA3r09y2qkthV8GECBswR4rGVMjM4= Received: by mail-pg1-f180.google.com with SMTP id q23so24617pgt.7 for ; Wed, 15 Mar 2023 17:31:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678926665; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9KhrkJGSUOYiiVfotnNQfrQRu80N+GO4LCzY8Gnj/3w=; b=WB/xmzCsZRZtBIneo/AO01OwGLTrzzIQLgaUwzbND73RDg+PHC/zVOVnq3CrJHOlSc ++cFP2P+wFQzuZ+g4e04Dyj8WZQ+4n96gQNzpFvGmSzaWeTUsAdiTRyQbOpZKqVxn+oY yDP1LnIiYSeyvlhR53U5wE9LM2tyWJj94g4OSGAygyMlAbKEQ71n8+B5ZowXN07WRJXa NMD2sh4JrrS4pFPy59RNoGDrvKU+oRHnx49Dh2cg8t6dfAi5HnruloXaNPpXQISEiyCz HERy92y62Nn80x7R9As/vuFZlznBDV6PYVD/9oUjdujytkNa9Ym3pRrTqDKxVqRJGsZf WWSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678926665; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9KhrkJGSUOYiiVfotnNQfrQRu80N+GO4LCzY8Gnj/3w=; b=cwhFDmcuHYIp1QW15f+Jc5TW1y0KqoRX0fX/wy4WVkClXiPRDXYhiK1v6zAQg+yh4C TW/tSJew1VasZaBhe7vfZ4lNBzUiAFgK/JTpVtkZnXBVLVWOgHt69EDqmRyYRKkx50W2 fL3JDEBLfRvCvSdKTPS530q9/sPjtoFUfDnHPbEV3Lhp8tDhDI19HNMADyhCr/jDKJe0 JV+iNovMxp50gnbduXJyCFNREYo0mHu1N32UWOYC1KNQrvfE4UXf1j3sjN8/of/DJIAp T3ij/28tjTY55odhMEFkd21ihanh7hq/tsm1Zke7UYUReaKDjsItoI1PYer2yHK4JfOO DgEA== X-Gm-Message-State: AO0yUKV73uYrXMtX/cQDjNyBeVlmcIUYs2eYbGCVOg79cN2KOYDpXdyK 4GBk1QJ79xKAJlHsuHJtZqQ= X-Google-Smtp-Source: AK7set/esHi5avqDM2fH/I0qVxsmqc3WYu3IkEKKVsSeLWv7mYXWdyRBXofbNOj9imT11r//7zi6Ow== X-Received: by 2002:aa7:9591:0:b0:625:290:e303 with SMTP id z17-20020aa79591000000b006250290e303mr1504683pfj.14.1678926664681; Wed, 15 Mar 2023 17:31:04 -0700 (PDT) Received: from localhost ([192.55.54.55]) by smtp.gmail.com with ESMTPSA id e4-20020a62ee04000000b00587fda4a260sm4100324pfi.9.2023.03.15.17.31.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 17:31:04 -0700 (PDT) Date: Wed, 15 Mar 2023 17:31:02 -0700 From: Isaku Yamahata To: Kai Huang Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, dave.hansen@intel.com, peterz@infradead.org, tglx@linutronix.de, seanjc@google.com, pbonzini@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, kirill.shutemov@linux.intel.com, ying.huang@intel.com, reinette.chatre@intel.com, len.brown@intel.com, tony.luck@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, david@redhat.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com, isaku.yamahata@gmail.com Subject: Re: [PATCH v10 05/16] x86/virt/tdx: Add skeleton to enable TDX on demand Message-ID: <20230316003102.GB197448@ls.amr.corp.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 028AD18001C X-Stat-Signature: bmfdsmjnjfqqfafgijjd3isbwnnx5dnm X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1678926665-263483 X-HE-Meta: U2FsdGVkX1+eiv0J+X4mF1jXBahVH9ZUv28x9LFZw1yTeMNZOKOkCtVLD+KfowahAekv1OCjkSl6iMBHzErhGkBdZ4INHloVg8HBth8PuzJJvblRMQTQTofbSKN8NzOg+GzHsoXVc6+P1G8Z7uq/vw3lzbUDREiizfMGhpMxlggi/9p0sRk3PiBynn0Y3kODCMJ4n2oeQiaxbpPmtfWnSq9uBmBVez0zHTMopoTr9Y9niCNcSZV+XVB9A2Hi1mhiyn0SZQ+cPXiI8m+SYGLKf59LVgMwdrWiAACKLm3doGnd+L2YiXwMhleQ38DVSOe2mlw7Tuq8vRDQRWCBFi3Nom8FXHroDWcK0hLsL+rMkrUEhVHDQFZpFT/pHQqnLvkFAbBR4nq2LE4rzwfRgVOS3o204AVf75/92RPBDB9tGTjY98sDOBRxLstQBlzcPdlbsc6qEiLmeznSD5OXRXX8AMQOahIJRKbXIddCL1VmfbLpYLVI+GfChJOepqMwlIFnvduXBe0vxHWCXYnM31DYVjXI8YjmwvzDIyCy4mF5NkZJw3l+Y6dfF5aq/KcjMbvePifP4iqWpXYr3wMRdDOfzu9Yn+WAZpOakHDAHMaDw68K+NWVZKUXFU55X9IeWHgKsZ8z7WXHI/yJLoVjFsYbLVGGpZ5P8WBf6dS9aP3MUBmxvbBnxJYPuqlAJJHyacs8J4Bdndg2vXlb8kBOFTNpg5EroZ1J4/oN1vEyO9J0Ll2TRiQpQbtZ9Mdo9yNGFq9QNYR03qAn75hu1j2xn6YtLPeC2uO9+tKgOozHb3X/s1bWeAAreFcE6VISV3zPyAm/7lgMyHu2FfycFMR957iSIXYtAnHNzfuWePQfo8ib84H1R5GKpxUnYfFeQDCZOhmwj/mvtOTzVO0qPf8wu1PgK9Ru5ejt0GGq6rlByLbGNHUmr07wmfH9+wulDW7KQAUsltJJTItMr+T6WQP4Zhh 6XfsvrQB G7sFNhsCbUJGCftYwNCfA9WfvkOikfEdgwthRrM2RtFhXHPZ2tBNSWi5KT0JQJ3XEJQl7drhzBwUOpWOnA3yXpyRaVTCGi10NIzYSOLMpmCRgTP6J2OHtRdIufrYE4MTeQhQJb/V7TFrso8cPt6NKgspp3zofioLxAnLaFd2HSdKU7FKbNOVCbP8jvCUcgD6DOBSCtNwGEtx3uBG1oEtqSbHJNhri8+QYOKCfAJiCQlhwr6KOckuLRl+fi+6bSlpHShfaHKnSyY8IbbLUqK6X4irlm2HEpPmdcXjGcvO1q2ySZoIGUEaFv//wkGJXDRhZMBv8dRDFj3klUGlAsWPCxvLc3thnIws4FCwzXvLuoxRlGgTgzOVYl5pIWMpqUFA0ZUjwsLbQUCpSjZJyLwPy9LwZe+xLvKl50gSrcf2Abr6WeUkwpTJ9PKeRRStO/A/eei2o5JA8vxFbvQm07wI3RG4pEi0Dtk7ciKRMTczicuK2uM73w2JPZ1urysTtsSiTBF5sA3eSrE2wZVaFG5CMRGtDwT3Lr8xVwBzU9+ugyFDYEvXI4GTU/kkh1g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 07, 2023 at 03:13:50AM +1300, Kai Huang wrote: > +static int try_init_module_global(void) > +{ > + int ret; > + > + /* > + * The TDX module global initialization only needs to be done > + * once on any cpu. > + */ > + spin_lock(&tdx_global_init_lock); If I use tdx_cpu_enable() via kvm hardware_enable_all(), this function is called in the context IPI callback and the lockdep complains. Here is my patch to address it >From 0c4022ffe8cd68dfb455c418eb65538e4e100115 Mon Sep 17 00:00:00 2001 Message-Id: <0c4022ffe8cd68dfb455c418eb65538e4e100115.1678926123.git.isaku.yamahata@intel.com> In-Reply-To: References: From: Isaku Yamahata Date: Wed, 15 Mar 2023 14:26:37 -0700 Subject: [PATCH] x86/virt/vmx/tdx: Use raw spin lock instead of spin lock tdx_cpu_enable() can be called by IPI handler. The lockdep complains about spin lock as follows. Use raw spin lock. ============================= [ BUG: Invalid wait context ] 6.3.0-rc1-tdx-kvm-upstream+ #389 Not tainted ----------------------------- swapper/154/0 is trying to lock: ffffffffa7875e58 (tdx_global_init_lock){....}-{3:3}, at: tdx_cpu_enable+0x67/0x180 other info that might help us debug this: context-{2:2} no locks held by swapper/154/0. stack backtrace: Call Trace: dump_stack_lvl+0x64/0xb0 dump_stack+0x10/0x20 __lock_acquire+0x912/0xc30 lock_acquire.part.0+0x99/0x220 lock_acquire+0x60/0x170 _raw_spin_lock_irqsave+0x43/0x70 tdx_cpu_enable+0x67/0x180 vt_hardware_enable+0x3b/0x60 kvm_arch_hardware_enable+0xe7/0x2e0 hardware_enable_nolock+0x33/0x80 __flush_smp_call_function_queue+0xc4/0x590 generic_smp_call_function_single_interrupt+0x1a/0xb0 __sysvec_call_function+0x48/0x200 sysvec_call_function+0xad/0xd0 Signed-off-by: Isaku Yamahata --- arch/x86/virt/vmx/tdx/tdx.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/x86/virt/vmx/tdx/tdx.c b/arch/x86/virt/vmx/tdx/tdx.c index 2ee37a5dedcf..e1c8ffad7406 100644 --- a/arch/x86/virt/vmx/tdx/tdx.c +++ b/arch/x86/virt/vmx/tdx/tdx.c @@ -41,7 +41,7 @@ static u32 tdx_guest_keyid_start __ro_after_init; static u32 tdx_nr_guest_keyids __ro_after_init; static unsigned int tdx_global_init_status; -static DEFINE_SPINLOCK(tdx_global_init_lock); +static DEFINE_RAW_SPINLOCK(tdx_global_init_lock); #define TDX_GLOBAL_INIT_DONE _BITUL(0) #define TDX_GLOBAL_INIT_FAILED _BITUL(1) @@ -349,6 +349,7 @@ static void tdx_trace_seamcalls(u64 level) static int try_init_module_global(void) { + unsigned long flags; u64 tsx_ctrl; int ret; @@ -356,7 +357,7 @@ static int try_init_module_global(void) * The TDX module global initialization only needs to be done * once on any cpu. */ - spin_lock(&tdx_global_init_lock); + raw_spin_lock_irqsave(&tdx_global_init_lock, flags); if (tdx_global_init_status & TDX_GLOBAL_INIT_DONE) { ret = tdx_global_init_status & TDX_GLOBAL_INIT_FAILED ? @@ -373,7 +374,7 @@ static int try_init_module_global(void) if (ret) tdx_global_init_status |= TDX_GLOBAL_INIT_FAILED; out: - spin_unlock(&tdx_global_init_lock); + raw_spin_unlock_irqrestore(&tdx_global_init_lock, flags); if (ret) { if (trace_boot_seamcalls) -- 2.25.1 -- Isaku Yamahata