From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA320C6FD1D for ; Wed, 15 Mar 2023 15:39:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 68B966B0072; Wed, 15 Mar 2023 11:39:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 63A2E6B0075; Wed, 15 Mar 2023 11:39:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DB416B0078; Wed, 15 Mar 2023 11:39:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3DA836B0072 for ; Wed, 15 Mar 2023 11:39:01 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1B72440778 for ; Wed, 15 Mar 2023 15:39:01 +0000 (UTC) X-FDA: 80571540882.10.5828416 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by imf28.hostedemail.com (Postfix) with ESMTP id 1E110C0011 for ; Wed, 15 Mar 2023 15:38:58 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm3 header.b="c 5Ff4yD"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=Uq4dZKnF; spf=pass (imf28.hostedemail.com: domain of kirill@shutemov.name designates 66.111.4.28 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678894739; a=rsa-sha256; cv=none; b=4L5D3QnqZ9xtkyKuv/p0a1ai6Qk56iyKz9nInjgUZUdLenBV63KAMYj0pPCRzAVSF0EdG2 KKs1HE1gw1TObX0mhQDyecJuUNx8CsMab42o54UrKpd1Q/03MoisGxCeKv6qpe4BF0bDRj mZVxL3WXfYYehSTUSPiHN/V9mk1C4Hk= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm3 header.b="c 5Ff4yD"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=Uq4dZKnF; spf=pass (imf28.hostedemail.com: domain of kirill@shutemov.name designates 66.111.4.28 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678894739; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ush8ME0jEakHYg80k1g2osTICDPTTulGFVSfscZli7k=; b=kHGYdVcag2nV8ZL7mnAxEDWs5vSe2vuQh3Ajx6y9Q4mAx1Lbvd003h0gl8QagNlKRXQrHd 0lTuk3vR4jm/C2EtJLAFDODDEbKj9oSVT80PAv8t77m9qDSc2QDrgMEvsNHt37KcY0ivsL bgTs5CWPKheYgIayaVMPpXMNdYG8m/E= Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 984835C0526; Wed, 15 Mar 2023 11:38:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 15 Mar 2023 11:38:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1678894738; x= 1678981138; bh=ush8ME0jEakHYg80k1g2osTICDPTTulGFVSfscZli7k=; b=c 5Ff4yD36w41DKPma3HDdgIFg7AtVNZDC60XK8998GcBVLO3wL4D6I/qIcLyXh27m bCyrvJblAbOvAEEjc/iwujurPhajGIdERxogM81s+14yitqMHYsP1CR6D4ZxS1o+ t3hKAZLVygO9+IBOcs1oIuG59Jp088hOUBLEEcCNGbi7QIXwZ8gu2vSC9YrgiaKA Bix70JCboKiS3pisEPsPOp4zoMWUDjkBtxmQRj1ClZWQVwl9zoWuZJKUMRRfLyMi qITlkCycukFLeztfi4ZaIusDLJ5wrDdVrPBuS2qG4qEBTNW79wp13mhX5i+1/v9T BkE9s4yGHUmlO2Q60jVvQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1678894738; x=1678981138; bh=ush8ME0jEakHY g80k1g2osTICDPTTulGFVSfscZli7k=; b=Uq4dZKnF9dgnEFNEmwMyZFcFO6mXZ kVXn0skZTXHybY4KdfGC06+UK7lLMT+Vw9Tl6JQtlNmAJvmwdomjy/Kvk5GCj7+s Gcn5ZM4WxrwOjvcVjYimycPoQRGb78xXeIDy+gUHzBlPdrQfHiOAqgtFEC0VtdaA g4piQpywGHLOT28nSauuYgOnbIog+gUPnwu99L3PDFQsqhQU2Erhw3ltS+dVTq/6 +5bhAVuGrhLc7uE8LsTXovTTByBP0gnxgvSYHiwvVkg4S4VO2rlhNpGy191akjiA tFcYQdJz6S1P3pRo+9M7AC0nUEfhYSaEb/0h3fH+gb+LJEnkv8/HKtorQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddvkedgjeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepfdfmihhr ihhllhcutedrucfuhhhuthgvmhhovhdfuceokhhirhhilhhlsehshhhuthgvmhhovhdrnh grmhgvqeenucggtffrrghtthgvrhhnpeffhedvveeuheeljedtkedtkeeiieekgedtveeu tdejkeevudffudfgveeggfduvdenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuve hluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepkhhirhhilhhl sehshhhuthgvmhhovhdrnhgrmhgv X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 15 Mar 2023 11:38:57 -0400 (EDT) Received: by box.shutemov.name (Postfix, from userid 1000) id 05A9A10C8DF; Wed, 15 Mar 2023 18:38:56 +0300 (+03) Date: Wed, 15 Mar 2023 18:38:55 +0300 From: "Kirill A. Shutemov" To: Tvrtko Ursulin Cc: "Kirill A. Shutemov" , Andrew Morton , Mel Gorman , Vlastimil Babka , David Hildenbrand , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi Subject: Re: [PATCH 04/10] drm/i915: Fix MAX_ORDER usage in i915_gem_object_get_pages_internal() Message-ID: <20230315153855.aeqyxncf3k6yqipl@box> References: <20230315113133.11326-1-kirill.shutemov@linux.intel.com> <20230315113133.11326-5-kirill.shutemov@linux.intel.com> <7fe9a4a0-9b30-38db-e739-1dc1f7a8f74e@linux.intel.com> <20230315152802.gr2olzji5zhu6vdo@box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 1E110C0011 X-Rspamd-Server: rspam01 X-Stat-Signature: 65tu3o69186htmitjt1m5p4boiny9mom X-HE-Tag: 1678894738-281390 X-HE-Meta: U2FsdGVkX1+Yb6izdMjpBsuXY6YeUN9LCtDkSuEzDeyxyfF8gi8T7c4dxHSrxFJKVkPJLq2AJNYR0PWrrM2Ip/EgrOYLC+EKwcG33e8KJ1HtsBqqoqRtWR3zI5yf5HphieCRYdbsmZBKhoaKkr2o8GFP/NgF4B1I7jDn3elZFX9S2I/zCAXZgKNmCYC5k7o1IfeLEg25ZRpeC3aAyy92ms4tVxd17+GBR+WRx/mN20ZyzD+ntcktKXlotS4uWqIxpp5a5h2iCsVsF6/pXeQfNoq1F8vsgvdjOYdjatM233wjVZqz9FY+LL6jKOfLDRRfKAi3NB9Ji4/w0K9dPe9TC/6WQ1S60xrcUFbPOYKyvYWaTb80hbxiEz6uhotn4D6eAEt3OZlOOFNIc0QC8QlmNf3BBFbG4k34Hjk0skhNwNhnE39K3pSFN06mqIOUOqGy7ebdEdg5cMV96lMVr2FOqZhsQPf2dxFisNVjJDVdZtEoZLi01E6WW1ptfX/MosVlK9thMEcc/KNYEJv779WKEJDSJ8mAkbRNRUmOVWnHAw4zry57BFnD0wCnNUR3HT6Zqh6UanFqxGflK5J+IpYcktE1CEyIe1EksbOnQE/DLrgC2vedbvSqeYycJiGvKaHoJ5QHkr6bTjQGG3s4G7BbXmhDcnRCPRHT55f70EV5QMd+kCX+O/8f2y8YnSO9qOsGdBRBCwylHXStFP8EowPBDD7vXT9tWK/80+qalmyUtAfVGGZ4+P7lu2mNAMNyuZkXEWqVzvBAFfCF8BBWcoSylIkeChWY30GoQOonNGbJs5svf+fap9+RGWFlG5SRAO1v0juz77c2n4ZQX1S4TC2TZkEz2+4v4rAHz6HPNbvj6Z33l1/jJK4GFfl2+6WJI6iqYrpwp+aqg8+Ecr4eDlegnn5KScbaNEoVw5o2ELL3+oevVqe567p+lK8IGhpY0a/JUv7lvlIqlF1POZpML61 wfhYEWLC zXO6y+tSkEhLEbLConB6FNxgGClGoE6t5OEqubhpWWYAWBeBJiIDIJpYqGi8AKoDlAppOIXrSkQsfwpgAXOVpF0YDoR3U+Rh3csn7H9Tgt/QYGb9IbEf4xYMZHJLt1WRmROZ7fKFZCnEDEScRW//PhqNI06shgV4gMgfj6ZWXmjRH3rK2Jkz3egRmgwE3Hj4Dqw9m9i7TXO5h60iX0W3xLyYkeYf56n2n5E3mTArNGshKaZhm1VxS2m7WJRRCynUIGYa34dXxoV4JTjCTB10UW/KKYJpuQLCRduhQp0a9oTsY9JjevO8xgoRbDxmRwT3lt1gHhlVMcw7BvnAhUOJpMGTihGWqF+qZe9XY60kTNFZaNcBE/FYpXA7/FYgWFyQdkDIZPkyMFbT9MqHy++UW8xwerP1BTDxlBtId X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 15, 2023 at 03:35:23PM +0000, Tvrtko Ursulin wrote: > > On 15/03/2023 15:28, Kirill A. Shutemov wrote: > > On Wed, Mar 15, 2023 at 02:18:52PM +0000, Tvrtko Ursulin wrote: > > > > > > On 15/03/2023 11:31, Kirill A. Shutemov wrote: > > > > MAX_ORDER is not inclusive: the maximum allocation order buddy allocator > > > > can deliver is MAX_ORDER-1. > > > > > > This looks to be true on inspection: > > > > > > __alloc_pages(): > > > .. > > > if (WARN_ON_ONCE_GFP(order >= MAX_ORDER, gfp)) > > > > > > So a bit of a misleading name "max".. For the i915 patch: > > > > > > Acked-by: Tvrtko Ursulin > > > > > > I don't however see the whole series to understand the context, or how you > > > want to handle the individual patches. Is it a tree wide cleanup of the same > > > mistake? > > > > The whole patchset can be seen here: > > > > https://lore.kernel.org/all/20230315113133.11326-1-kirill.shutemov@linux.intel.com/ > > > > The idea is to fix all MAX_ORDER bugs first and then re-define MAX_ORDER > > more sensibly. > > Sounds good. > > Would you like i915 to take this patch or you will be bringing the whole lot > via some other route? Former is okay and latter should also be fine for i915 > since I don't envisage any conflicts here. I think would be better to get it via mm tree. -- Kiryl Shutsemau / Kirill A. Shutemov