From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F670C6FD1D for ; Wed, 15 Mar 2023 15:28:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77CA26B0071; Wed, 15 Mar 2023 11:28:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 72D326B0072; Wed, 15 Mar 2023 11:28:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F5A56B0075; Wed, 15 Mar 2023 11:28:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4EE6A6B0071 for ; Wed, 15 Mar 2023 11:28:12 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 07F19140142 for ; Wed, 15 Mar 2023 15:28:12 +0000 (UTC) X-FDA: 80571513624.24.095E9B4 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by imf29.hostedemail.com (Postfix) with ESMTP id EA3EA120024 for ; Wed, 15 Mar 2023 15:28:09 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm3 header.b="J QxJcae"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="ST/65M3F"; spf=pass (imf29.hostedemail.com: domain of kirill@shutemov.name designates 66.111.4.28 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678894090; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mq6wnsfPg0Odxi6RseqaQNbi52OOC00lXDJeDSSRChg=; b=EMNokMkMghwd5/5Yoc3GlAw0QkB0tyUFcSNcu0uzxUHQkisZgkWBb88eN432i8yOJQtY6Z JPFPbWUqzVXFAgZ0YFZ36cxTNuJNuOunMtGQZ11tyP0pJi+qJSFIE3VKy4/YD50TJ06+HT Fi51v17sz9cNlmuRlBbZ9vATCZQYRx4= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm3 header.b="J QxJcae"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="ST/65M3F"; spf=pass (imf29.hostedemail.com: domain of kirill@shutemov.name designates 66.111.4.28 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678894090; a=rsa-sha256; cv=none; b=h7PecMgW1NZW/Q6/eqYKlJsrQb97wIvu5K1BWBBoBk33o84/euaKgXpW71ZlVQjKzkswTF MXlxW54hXrjz3urLKoU4gBzF3w2/QfOoEtDZbIGkrLAEy+a5jE0ftiJkfgDu5yo1NFH3kG BWoLRRgMKJIg3NG7G3lOu0LlfelVnto= Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 36B075C0066; Wed, 15 Mar 2023 11:28:06 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 15 Mar 2023 11:28:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1678894086; x= 1678980486; bh=mq6wnsfPg0Odxi6RseqaQNbi52OOC00lXDJeDSSRChg=; b=J QxJcaeDyhRKiBj9ppkvxKjaAhrkCmGHIQtVoMv/tjuvtAotXd2QLfORO0Tf+hoJJ IvUCrtI3aCkLsY1DT/0UpKOaW5/FQXT4Jb1LnN34cnmE1jQW6NDohCtbtSRuh6Bf HtfXrfpAKM5nX3r645vrAEDGp37LNNbFCVNgZr361/+ScHDhjavITGOQJEEGAksU vUUtuT5iM4S8677QHUQhw534xSy+gM4lRWM9sF/f62Q5E6lC/ivkWLRBlgLxrgfs AZpperNaChHqWwjxMU47ISLMlexrdI8am0/2fjGswjfkOVAYCCnF1nwFk567vUIt csJYQrlCUmjewdHStk9pA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1678894086; x=1678980486; bh=mq6wnsfPg0Odx i6RseqaQNbi52OOC00lXDJeDSSRChg=; b=ST/65M3FFprhfEUaQr/SVj9lFWvJw uIrYbfaWB4bx2hQxXkcBMyVKKbotWr2nEZLmNNm7v5/l23wqMP9LhRGkTWwWzYR7 UhJMKE89z6Z6GTW8NjUCUJRXESPfXTrIk6lhPKtj/VrqQ525e5oZ7YWfU7gWy43i cVze9TIsuzH3xGU3jPgw/nZgeTwV0ycfSIMCSZ41/6LAds/PUzgGjsg0//AS/TaF xFmkM6taSL7cp5lJPGK67MN8iRmcy5m64f5MwPQeksm7pCddH8lhAYzfXaLy+Bmx qzVemwOZuFrOYNaVvZkWJ4i/bDQUT3K4+ZZVauluxY4d2sV74XxKSCbnA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddvkedgjeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepfdfmihhr ihhllhcutedrucfuhhhuthgvmhhovhdfuceokhhirhhilhhlsehshhhuthgvmhhovhdrnh grmhgvqeenucggtffrrghtthgvrhhnpeffhedvveeuheeljedtkedtkeeiieekgedtveeu tdejkeevudffudfgveeggfduvdenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuve hluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepkhhirhhilhhl sehshhhuthgvmhhovhdrnhgrmhgv X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 15 Mar 2023 11:28:04 -0400 (EDT) Received: by box.shutemov.name (Postfix, from userid 1000) id 81B6710C8DF; Wed, 15 Mar 2023 18:28:02 +0300 (+03) Date: Wed, 15 Mar 2023 18:28:02 +0300 From: "Kirill A. Shutemov" To: Tvrtko Ursulin Cc: "Kirill A. Shutemov" , Andrew Morton , Mel Gorman , Vlastimil Babka , David Hildenbrand , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi Subject: Re: [PATCH 04/10] drm/i915: Fix MAX_ORDER usage in i915_gem_object_get_pages_internal() Message-ID: <20230315152802.gr2olzji5zhu6vdo@box> References: <20230315113133.11326-1-kirill.shutemov@linux.intel.com> <20230315113133.11326-5-kirill.shutemov@linux.intel.com> <7fe9a4a0-9b30-38db-e739-1dc1f7a8f74e@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7fe9a4a0-9b30-38db-e739-1dc1f7a8f74e@linux.intel.com> X-Rspamd-Queue-Id: EA3EA120024 X-Stat-Signature: 511ds5xk63a3hig9a3edbf7pzkjtm8bc X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1678894089-940144 X-HE-Meta: U2FsdGVkX18bpTpk+653w1h7f1d+WEgXRPhavVvFaXF8t5sl/cJ48mHYZsekKrmjLRzmEoGkT4t6eKQe9UPV8tnu7gP35BLpWwO2qFYVsqjq/lB5JaNCnNkri0svg4eKngohwCFo0MpAI9fvIea0M7sfV6Gj4loM7W5eKMeOLvoaOcJThf4kN+5YLdR7r3coDr+P1oIJKqQ0FX+hEjYKttXA+bpDZkwxNU1VBz9jz/vmWvD11xn3SHdsT7qMUorhWwTHLtVsejURqBFlG+N+GD0umhjpqW3SA2UMDUOUtNHiHE3S3gPZOv8cBl/sS/gP9xlnuJYLARaeBw9m2to/wpo2UPQqBTNy79p9u7KH1zgqN/xP56PXOvZNlHqwfBaqmnhseJOe/hFaJW2iUmNShc7c+v9CX8dFH44rdTxYuuCAslJ75R/FL4rrAB8+ZXDAKoFt8LqWIWbr58Re76iyyQ347g8ll8Q4WRiUnMVlAnegkqdj36hYCbo/NwB2GHbeeP6U9l+YDQ4VfMtyLmRzcAvm4PG8qgifg1O+oIvPRc54JpADKCyo+PgmxKl0IhCaCviFDtOKq5GcdD8IBjFhcdnIn1g6oTY1XNFDwcI6v/XC5X5j8ZSFL5jGRFV/gMhJCaGL8DwU7F7IYFR58m67DVYsTeoK6FTAJKEUcrd0b83lF3jtO35naaDRXzh53sgfOYzsjF/GL6XdLQahk8bkRw7mI3t1T2N85pj8tt6ekDkhfGQZgIfqMiBMwdPOF2wRbXmmXn/kue69l30SmQsyEQEudKfLq4jmEtJISzGqDQNBD7ztnmSXhJqJ6d6wkdAUQzSuqthhL/1Roo/r/gFK9Z2bpIktpSWZOXgMVGTUTD+XhEVo2pebsSqiuR2ONQK3w6zhM05X4EmK4sxO30EYMZsFcUcwwBPS0PIhVz7MYI07UDWnxXoqkvnV1V1VClakPXtSzA5JSmWStOEAFZJ 0bUw4pSO Vcn2Zih2P1Pi2N45uctZfLHw5z5J6rh9b6FJ1T3EKuNJPY0jFBuROOoGQdYCl5cBdeaNJcMUlevWBKJQUuG/zObFA4m6IUuv+89sspGoRdtCBDiElfp0A5hI3BB0BXkvib9X9tnix4FGqBSJJBU5gpb18g+Pvhy0kre9VFvOdPlcMo6yfKBioWj79myDMW1IiooGFYveyVoQU02JbxtNMf6dvErb2EzYzK5lqZ0BuZIGYxUEsskYIpbXyctLbRkmdbus3gySuA4KRcRvEnOkL0pUdnbhZMVylIYBhaxTquIy58BLsBNrsfHCMO+GsWjWozal1nnZ4CYTLSM656plrd6GK8zmGQzfZM0ADp/u4ccLbS44HXb+4x4ZUAFq56xenUhvXzvvsRPhtyPUzvL34oROcdsTfT+t1jzlQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 15, 2023 at 02:18:52PM +0000, Tvrtko Ursulin wrote: > > On 15/03/2023 11:31, Kirill A. Shutemov wrote: > > MAX_ORDER is not inclusive: the maximum allocation order buddy allocator > > can deliver is MAX_ORDER-1. > > This looks to be true on inspection: > > __alloc_pages(): > .. > if (WARN_ON_ONCE_GFP(order >= MAX_ORDER, gfp)) > > So a bit of a misleading name "max".. For the i915 patch: > > Acked-by: Tvrtko Ursulin > > I don't however see the whole series to understand the context, or how you > want to handle the individual patches. Is it a tree wide cleanup of the same > mistake? The whole patchset can be seen here: https://lore.kernel.org/all/20230315113133.11326-1-kirill.shutemov@linux.intel.com/ The idea is to fix all MAX_ORDER bugs first and then re-define MAX_ORDER more sensibly. -- Kiryl Shutsemau / Kirill A. Shutemov