From: Andrew Morton <akpm@linux-foundation.org>
To: Marco Elver <elver@google.com>
Cc: Muchun Song <songmuchun@bytedance.com>,
glider@google.com, dvyukov@google.com, jannh@google.com,
sjpark@amazon.de, kasan-dev@googlegroups.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, muchun.song@linux.dev
Subject: Re: [PATCH] mm: kfence: fix using kfence_metadata without initialization in show_object()
Date: Wed, 15 Mar 2023 12:54:25 -0700 [thread overview]
Message-ID: <20230315125425.70a22d32cf46b23d249775ec@linux-foundation.org> (raw)
In-Reply-To: <CANpmjNMxDT+AHBZra9ryhm6aw+WqBsdJ_SKdcdZr6CBsh97LyQ@mail.gmail.com>
On Wed, 15 Mar 2023 09:07:40 +0100 Marco Elver <elver@google.com> wrote:
> On Wed, 15 Mar 2023 at 04:45, Muchun Song <songmuchun@bytedance.com> wrote:
> >
> > The variable kfence_metadata is initialized in kfence_init_pool(), then, it is
> > not initialized if kfence is disabled after booting. In this case, kfence_metadata
> > will be used (e.g. ->lock and ->state fields) without initialization when reading
> > /sys/kernel/debug/kfence/objects. There will be a warning if you enable
> > CONFIG_DEBUG_SPINLOCK. Fix it by creating debugfs files when necessary.
> >
> > Fixes: 0ce20dd84089 ("mm: add Kernel Electric-Fence infrastructure")
> > Signed-off-by: Muchun Song <songmuchun@bytedance.com>
>
> Tested-by: Marco Elver <elver@google.com>
> Reviewed-by: Marco Elver <elver@google.com>
Thanks, I'll add cc:stable to this.
I assume the warning is the only known adverse effect of this bug?
next prev parent reply other threads:[~2023-03-15 19:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 3:44 Muchun Song
2023-03-15 8:07 ` Marco Elver
2023-03-15 19:54 ` Andrew Morton [this message]
2023-03-15 21:04 ` Marco Elver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230315125425.70a22d32cf46b23d249775ec@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=jannh@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=sjpark@amazon.de \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox