From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CA5AC6FD1D for ; Wed, 15 Mar 2023 11:19:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB4886B0075; Wed, 15 Mar 2023 07:19:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3DA96B0078; Wed, 15 Mar 2023 07:19:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB7716B007B; Wed, 15 Mar 2023 07:19:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A69A46B0075 for ; Wed, 15 Mar 2023 07:19:51 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 77D36160658 for ; Wed, 15 Mar 2023 11:19:51 +0000 (UTC) X-FDA: 80570887782.07.55EA3CB Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id 84C15C0004 for ; Wed, 15 Mar 2023 11:19:49 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=r9sY4aY3; spf=none (imf28.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678879189; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y1qbaNmKGtblNVhdlxDCOnZuD6KOCPFbJF9ZFx/bdFM=; b=SAal04dj8SQ8JKkCi2J8TJlZOxGHqdLLMx8a+HRN1pavzT5AH6N4L5bcozx7yt1kNTHbhh 4ra1Tb0404FPMVt9vjnilXFySP5yr54GPpFY5cuwzE+jZJzXsNuSWIV1AUhTcSgHjYnewe B9wzhC1emWRAkEc3RHkak8YN6VS1yPA= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=r9sY4aY3; spf=none (imf28.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678879189; a=rsa-sha256; cv=none; b=Xu8dgFtH8HxBrhLLd0q9T8t2z8ZUBopP9zaPwtv/BVVdlH6bEbuuT2NXndIMeg6Ln627oS 5/3vsS4+T9vrC0AOMTBiv3XxwoW46PZeuRfeF4OHToIHP0BLgXCb3AjBjkFdca5iC/0CvK sGORcM6l4KA3mVAMJxp7CnXED4NDcnk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Y1qbaNmKGtblNVhdlxDCOnZuD6KOCPFbJF9ZFx/bdFM=; b=r9sY4aY3ZXCD0AcKFsKkZA5YuC aIpytDEDMlZWSG0ayXCImdw3to0/+P8A12SOeeirCAWSzGf4HoEL6a09f8wVRmKh4wIgf4S+j0poD aQa+zFKzEVKRJ+mrYP1x/RwdKl4Rdr6wUyavTo74ONgR2GLhGhS+ZtT8zV89SgDXvAcO8CEgHm3h7 jsdSYpqFO5InR0xfLRpm8f8ksdxjAIGDqyQWBeIYkcgthiKUFDuAj9J8FT6qgKVMsxbnxXPDKZTrh IukN0ALe+uTYJT1fNTtje36S90BSYB6W7ATPK2uFsbyOuuKYS08IIXDKTaXM9jqNr7rENnFOBDIbN GCNVi9cg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pcPAV-00Dmgc-Hw; Wed, 15 Mar 2023 11:19:44 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id F2FFB300288; Wed, 15 Mar 2023 12:19:41 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id DAF6920FF20AE; Wed, 15 Mar 2023 12:19:41 +0100 (CET) Date: Wed, 15 Mar 2023 12:19:41 +0100 From: Peter Zijlstra To: Mike Rapoport Cc: "Matthew Wilcox (Oracle)" , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Subject: Re: [PATCH v4 27/36] x86: Implement the new page table range API Message-ID: <20230315111941.GC2006103@hirez.programming.kicks-ass.net> References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-28-willy@infradead.org> <20230315103436.GA2006103@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: jist577ykckn1on9hkax7aw9pchk5z1a X-Rspamd-Queue-Id: 84C15C0004 X-HE-Tag: 1678879189-71530 X-HE-Meta: U2FsdGVkX1+mcJqXFsIAJMMLen2+SIpAow0yuOLrvvLxi1i32NPgiy1DL/cfDlfrxL9o1/K6DPolux5TQ0TRF94asG/jPQtNSX1Dl5gFbPRLA4OwU5A6kpAdjJ3AfMVsKTI/wLkYw7tLGunumD/OY+Pph1G8WpcXafQiDFQ77HFbJPtMOZGFj0wxtidaiwpOkTSYkJOGi7HgXpnJDjS4+j2ewI/5CrGqWX7GazjqieNBWtKw6b5eounk1tjCCHnkk8vW/BV9KyGMtK91pxUZIWfwhpvzfmrbKXAnsz9GuTaa5kRBUoq4fGkrF1NL31D1Sq3b0zmg7qu9ead9pM2z6TPa1vX/Yz+kGw/9DcLdID44uolwMOH9CHM2FiP5UaN8DVmTgFFPmxTXuir+NZjO8VFtySObRyjbo/Bk2Kg1OTa7kurwJoxwp+AFqFMNrEyhdpxiNxQELTLMwzu0xr2OlMCDz/AwgEHMs6nncxHDiQRMfthsjivf1YkgVMl8TV9UOUeao1Ql5KB375J4ZiznYXjDti5J6xOCQbHE2+OhNnugPxYLZuRw4BVxcEoJxzeMrDfW6GbiQhMHBYJLEgg+cpgg1s5sZEm2spWC1YO7enI+l+A+ds7JK2S5YYDuIqGbNa6HDIblAi7Sz4E9Gaqs+m7DkMQisuVwBGv6AEEbZ+IpwEJNm/hGEbhWJFgqXbeZa69xfNZR+1O5pLTd1EJN33b6trTfJxDy6N0MHdLlvqfezQkfPenjr5OjrgAzx3RviHy0VE8C5OLMlzcY6QeSEfvm3g13oQ+yL8pkfO4wW93uF+hp0NzVhOkCAFiDWZarTL9LsfONygxQu8o3C/7dyD/uUtduGj62UInfj4pkp4JiUygxZLjngmF/ztlS9NbKpnj/pQx0F9mEY1k8tatc1akIqIxeQQfN8OlxvF1xIbzzAhDfVYYStGOXuhN5V3I66xbZBx7UUtpdliO0C93 KJIxLGN5 SnBga8izasYfiq3k7I6+StQbNMAjlhnIEigle4Lx2zbIrtuYaX2toZYWB7ZbCWx7smzks4KJNKTNeqKeMvyJMsh/ao4khB3iLsfLgPhfwPAE8TiHifAVA7K8ygu0OVfT0vCBvxqXBNyGOgKwxmwOJbaSyy0SBysMnLebAEkVx/iZd94IOo/wssuYZ+0ZXuXfVIZXqu1rAV3AjfE4v+6HGF0T/v7tNCFou62Hl/rKpLfs+hYWq5G3NlYD0f6NYmVnORPVL6QgU+jQIf1Z6dFf2mnGCJ5cHw7Z+v46NvzV5tFrOR6N21zE5K1pREX0ITTMY18XBQxQaKdJNttST/AfxEjUk4CRay0+zW5cCxQoLA65d80SBK3HD8EoJNw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 15, 2023 at 01:16:24PM +0200, Mike Rapoport wrote: > On Wed, Mar 15, 2023 at 11:34:36AM +0100, Peter Zijlstra wrote: > > On Wed, Mar 15, 2023 at 05:14:35AM +0000, Matthew Wilcox (Oracle) wrote: > > > Add PFN_PTE_SHIFT and a noop update_mmu_cache_range(). > > > > > > Signed-off-by: Matthew Wilcox (Oracle) > > > Cc: Thomas Gleixner > > > Cc: Ingo Molnar > > > Cc: Borislav Petkov > > > Cc: Dave Hansen > > > Cc: x86@kernel.org > > > Cc: "H. Peter Anvin" > > > --- > > > arch/x86/include/asm/pgtable.h | 13 ++++++------- > > > 1 file changed, 6 insertions(+), 7 deletions(-) > > > > > > diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h > > > index 1031025730d0..b237878061c4 100644 > > > --- a/arch/x86/include/asm/pgtable.h > > > +++ b/arch/x86/include/asm/pgtable.h > > > @@ -184,6 +184,8 @@ static inline int pte_special(pte_t pte) > > > > > > static inline u64 protnone_mask(u64 val); > > > > > > +#define PFN_PTE_SHIFT PAGE_SHIFT > > > + > > > static inline unsigned long pte_pfn(pte_t pte) > > > { > > > phys_addr_t pfn = pte_val(pte); > > > @@ -1019,13 +1021,6 @@ static inline pud_t native_local_pudp_get_and_clear(pud_t *pudp) > > > return res; > > > } > > > > > > -static inline void set_pte_at(struct mm_struct *mm, unsigned long addr, > > > - pte_t *ptep, pte_t pte) > > > -{ > > > - page_table_check_ptes_set(mm, addr, ptep, pte, 1); > > > - set_pte(ptep, pte); > > > -} > > > - > > > > And remove set_pte_at() apparently.. whut?!? > > It's now in include/linux/pgtable.h All I have is this one patch -- and the changelog doesn't mention this. HTF am I supposed to know that?