From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74B69C61DA4 for ; Wed, 15 Mar 2023 10:34:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C55236B0074; Wed, 15 Mar 2023 06:34:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C04AE6B0075; Wed, 15 Mar 2023 06:34:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACB4B6B0078; Wed, 15 Mar 2023 06:34:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A099B6B0074 for ; Wed, 15 Mar 2023 06:34:52 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 79F07C02C1 for ; Wed, 15 Mar 2023 10:34:52 +0000 (UTC) X-FDA: 80570774424.16.7891043 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf27.hostedemail.com (Postfix) with ESMTP id 282304000F for ; Wed, 15 Mar 2023 10:34:48 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=pBoo235z; spf=none (imf27.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678876490; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Mt1/z2UrE0VK1pxUQEs3KTv8uVCQ4X++r14v6jz/7wc=; b=ILk66bZTrvAU5owdlrKTj5gUABcf9c3lFoPiSkabpD/g5iN7ca06oSNJnjBOx9N50hF9qM xxNByyobtdhXXfmRcwta1nonuQ6SWMn0A6zgqEdjLigacy11+2+vJKDyrpiyhE9lbLAj5U Odb5vnLVPK/L+3T5hpYXatAkdyBP4LU= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=pBoo235z; spf=none (imf27.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678876490; a=rsa-sha256; cv=none; b=UUGILMb1mOD9OjRAHkA3Z9ZZalvhQNCFAH6SGRTnUVCBL+FgqiDkJZWGv+QZizBmSdIV/U oWo9tT05gph29iAT3LDIhatk6n8RsjymR5GD+8tl/6Z6ugc8r42L5Tllg0Jukjiuqz/sFn k/vw6aDRY16dRFMM3NXtFA/+RZXfAZk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Mt1/z2UrE0VK1pxUQEs3KTv8uVCQ4X++r14v6jz/7wc=; b=pBoo235zkur4RaZuoc1rRM75yh BNyugLz0MUtINYbC44tP27PuUyx2T5vRGVIAbdXeKK6K9yKAryfXCyubm2aQUPKO93B7b1pIkG2QY yUot4jozF+Cmu55ygC0QU2jjOQCcGF+6k7KfDIKczkjFyk+SSRUX+GCIVexAPtiFWb99xmGpgdAcj L5OsRp0l2ORDgHORepDVgsjuZaR7mQhhNxV++s6mLaxMS4sm1MS+LIFmk0yF18ca4TGklBj+8hoax HjUJzOorN7MCW0bxnyKNtRyzob0uxEZfecmVq03HMa2R3I/P/uRhSzGwiMhRm1bEMO6+H9eMxLhrk a6Rzjodw==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pcOSs-0024yN-1N; Wed, 15 Mar 2023 10:34:38 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 5AAFB30013F; Wed, 15 Mar 2023 11:34:36 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 369A6212CB3D8; Wed, 15 Mar 2023 11:34:36 +0100 (CET) Date: Wed, 15 Mar 2023 11:34:36 +0100 From: Peter Zijlstra To: "Matthew Wilcox (Oracle)" Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Subject: Re: [PATCH v4 27/36] x86: Implement the new page table range API Message-ID: <20230315103436.GA2006103@hirez.programming.kicks-ass.net> References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-28-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230315051444.3229621-28-willy@infradead.org> X-Rspamd-Queue-Id: 282304000F X-Stat-Signature: x5qkfroguqddpp54expgzdgkqu6k596g X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1678876488-195768 X-HE-Meta: U2FsdGVkX1/7PKGzDi43UCZfbHHs9KjSet+2Hp0P1noys832Ty1nT4dXB1nw6f4lj7NRuAYhtna3rsvbMm9dzi3dqtLPI6Koc7nhzkcmNsJLePQ+Z5st4ACpgJL2cBrYQW0n066ez2ZMF7i0ud4YQu/ssKBfXzw3GhkAnhPFTOPe8rIP9hrHB0w603y99Xs+u+ZciPxpepdiv9xKja3Cq+e8k9iJqFUPzYEyrtRR+ofDsaFkyXlius1RUyAVFJ77z2q1f5IdGTqAG4WGbcXFBQk/BbrWAd9Mw1GWbDGuSpGfIlB3xU8ByEXIU/hmzSflbte74mRvNeope1hBujUaDg/8/eKdSjrUVNvTG4kJfVsIzKl26i9MLCqMa3zLGUgH1NvyJwlVD7Xz1bujcFo45Y7BNjMSEM07PKYyPxEFzACF4Lnj9MNzIvIAeNPnkYHce5o1p7u9ZBBr4RRiEltPqFHbuvIe69bunLF8NdwCV6NqvWWrzQuz+y75wCaD502PSiUl2hVdR49ladmwqMbSAxLlJAlU4q61/HT8r7Z6DHuie9aQouhLwnRV5uv/nrBrpV/OkEEv5igffbgPa3EyX/P3k7CxlqPw/jbxRRdDBeEoG+5jumiXpRH/7WGQjizLeu3o/wRV1nox1cGUW5F+0uj5nkjAuc7OqKInmfYgD9GYY3fDSwFxr8pKOI+ElHCzomIpkrHpGUssB8uO5WH9PD21gauQlDsyBFV6tV7wK+Kwikfibvd3UXbeYimrs00JF1n1yGwG0vUU6C4ua1PC4bOvzAFPv97mPkslYLbEyws8IQnqt+9h0hPr260pwDZN/X8phdtDXe9bZ4x9SE4bfTJK1nfuvd3RVG84tng/vuIkz0VwZysNNN5SJP2EUU2OFhlvqjiTOjd+aUjYndI38zFBIlifQtKhGmJCM5TvBClbLa4jPFkSXWkrPJHbw8cinTrVJQS2qVCL+RVOYEW 3420rpfR yAvuYDVGi78r6/FV9ncfizWiFHe3sHern/k1KtJj9Dd0Gb+i7DS5oaAkskBEYIgcMkCmM5QzOSZrV/QA2WjNmH0BKn4ZXmZfNR1M0My1maslnArdi/e4hDoZ75315ZXBeth4XYxZA0Z3eULUBzPRR5WuKNsviGBAIiKD6uE38J4wmpM/mY5RRxXLtXZTMeA3HruMzPLKBA3Uy1CSwJq2QH4KQP05P+X1ulU7lE2r5GbZ65MfusK5++1s7fEro1TE3wKfYS8S3ZRJ0CKYPU7hOlVhOID3qy5JGjbVMVR6zlDJKIZxaIjcafWTE7DwxeQpVOy8Y16P5G//gb1LurNJZQrnmwpEh3Pv3fxkJCBKhDrX3RJBzIe6AD/xYZjuhBKEb6OVv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 15, 2023 at 05:14:35AM +0000, Matthew Wilcox (Oracle) wrote: > Add PFN_PTE_SHIFT and a noop update_mmu_cache_range(). > > Signed-off-by: Matthew Wilcox (Oracle) > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: x86@kernel.org > Cc: "H. Peter Anvin" > --- > arch/x86/include/asm/pgtable.h | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h > index 1031025730d0..b237878061c4 100644 > --- a/arch/x86/include/asm/pgtable.h > +++ b/arch/x86/include/asm/pgtable.h > @@ -184,6 +184,8 @@ static inline int pte_special(pte_t pte) > > static inline u64 protnone_mask(u64 val); > > +#define PFN_PTE_SHIFT PAGE_SHIFT > + > static inline unsigned long pte_pfn(pte_t pte) > { > phys_addr_t pfn = pte_val(pte); > @@ -1019,13 +1021,6 @@ static inline pud_t native_local_pudp_get_and_clear(pud_t *pudp) > return res; > } > > -static inline void set_pte_at(struct mm_struct *mm, unsigned long addr, > - pte_t *ptep, pte_t pte) > -{ > - page_table_check_ptes_set(mm, addr, ptep, pte, 1); > - set_pte(ptep, pte); > -} > - And remove set_pte_at() apparently.. whut?!? > static inline void set_pmd_at(struct mm_struct *mm, unsigned long addr, > pmd_t *pmdp, pmd_t pmd) > { > @@ -1291,6 +1286,10 @@ static inline void update_mmu_cache(struct vm_area_struct *vma, > unsigned long addr, pte_t *ptep) > { > } > +static inline void update_mmu_cache_range(struct vm_area_struct *vma, > + unsigned long addr, pte_t *ptep, unsigned int nr) > +{ > +} > static inline void update_mmu_cache_pmd(struct vm_area_struct *vma, > unsigned long addr, pmd_t *pmd) > { > -- > 2.39.2 >