From: Mike Kravetz <mike.kravetz@oracle.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: akpm@linux-foundation.org, mgorman@techsingularity.net,
osalvador@suse.de, vbabka@suse.cz, william.lam@bytedance.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: compaction: fix the possible deadlock when isolating hugetlb pages
Date: Tue, 14 Mar 2023 10:27:25 -0700 [thread overview]
Message-ID: <20230314172725.GA4769@monkey> (raw)
In-Reply-To: <db50d82c-07f1-6a87-6960-7810c54f8093@linux.alibaba.com>
On 03/14/23 12:11, Baolin Wang wrote:
> On 3/14/2023 1:08 AM, Mike Kravetz wrote:
> > On 03/13/23 18:37, Baolin Wang wrote:
> >
> > It would seem that the pfn of a hugetlb page would always be a multiple of
> > COMPACT_CLUSTER_MAX so we would drop the lock. However, I am not sure if
> > that is ALWAYS true and would prefer something like the code you suggested.
>
> Well, this is not always true, suppose the CONT-PTE hugetlb on ARM arch,
> which contains 16 contiguous normal pages.
>
Right. I keep forgetting about the CONT-* page sizes on arm :(
In any case, I think explicitly dropping the lock as you have done is a
good idea.
Feel free to add,
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz
next prev parent reply other threads:[~2023-03-14 17:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 10:37 [PATCH 1/2] mm: compaction: consider the number of scanning compound pages in isolate fail path Baolin Wang
2023-03-13 10:37 ` [PATCH 2/2] mm: compaction: fix the possible deadlock when isolating hugetlb pages Baolin Wang
2023-03-13 17:08 ` Mike Kravetz
2023-03-13 19:31 ` Andrew Morton
2023-03-14 4:11 ` Baolin Wang
2023-03-14 17:27 ` Mike Kravetz [this message]
2023-03-15 1:27 ` Baolin Wang
2023-03-15 17:17 ` Vlastimil Babka
2023-03-15 15:54 ` [PATCH 1/2] mm: compaction: consider the number of scanning compound pages in isolate fail path Vlastimil Babka
2023-03-16 9:53 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230314172725.GA4769@monkey \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=osalvador@suse.de \
--cc=vbabka@suse.cz \
--cc=william.lam@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox