From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D341C6FD1D for ; Tue, 14 Mar 2023 02:19:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 13B5C6B0072; Mon, 13 Mar 2023 22:19:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C4736B0074; Mon, 13 Mar 2023 22:19:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA6A26B0075; Mon, 13 Mar 2023 22:19:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D737A6B0072 for ; Mon, 13 Mar 2023 22:19:37 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8D6554119F for ; Tue, 14 Mar 2023 02:19:37 +0000 (UTC) X-FDA: 80565897594.03.88B2279 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id B45861C0013 for ; Tue, 14 Mar 2023 02:19:34 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=TEy2LQY7; dmarc=none; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678760374; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JFvPjb2wxUG1mC/AbUqK0ynnByAyAetb4OmQNVNC4cc=; b=fX5f234wuKeQOke+sMlXNrB+xviXTxroxc6VvVd3sasDyOTQWr1fx3M7Dh/wzblKWQV2cy O9Dy03Uk63TxJh1nmcyJu/GmT0eHRIDs7PkUUwzf8lQexc6ht35WmXNtYcc+e9rEwjzOJi eM8WMzaFt1hp0xb0m0Xfg5/ozD5jgXo= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=TEy2LQY7; dmarc=none; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678760374; a=rsa-sha256; cv=none; b=uAM19EScsAxrQBWtwwWt2LijWe/yCCyjdzdslYzwyEeC7pShBtsjGqC+DZ2O5687zwoS60 XN2shoJa32GqGloo42nAlP4XXW4QzgHzRFSklPLfqQ7YcvP6Yix0sq5k/7xFybgphoqG56 20xzuvfbdttyW9YAdkJe2ILZiTxhldY= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8F8DE61573; Tue, 14 Mar 2023 02:19:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DFDAC4339C; Tue, 14 Mar 2023 02:19:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1678760373; bh=jQhD/M7Ani+bWf3eE9KwDDKZgpO+n2YjiyMZ49M+DVU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TEy2LQY75YaxuMZ9i9d0txb/bAPwVksXWhiZdQy+Gp0ocrEuwRrFo+5Wh7rqlFeNe 1LlrirqETNh2b1bMxwBWU+ClRS3UtSm156sFelxG38ph5FucwHNDR7Wyqo4Eq0iphr BLQ4sFlz8R2QZTg6FkeByENg0z1522RLRjMbOHgw= Date: Mon, 13 Mar 2023 19:19:31 -0700 From: Andrew Morton To: kernel test robot Cc: Christoph Hellwig , , , Linux Memory Management List , "Andreas Gruenbacher" , Hugh Dickins , "Matthew Wilcox" , , , , , , , Subject: Re: [linux-next:master] [mm] 480c454ff6: BUG:kernel_NULL_pointer_dereference Message-Id: <20230313191931.f84776cb09dc8c4b50673a76@linux-foundation.org> In-Reply-To: <202303140916.5e8e96b2-yujie.liu@intel.com> References: <202303140916.5e8e96b2-yujie.liu@intel.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B45861C0013 X-Stat-Signature: m64nmq6u5byr67inq1z8rid6818rpha3 X-HE-Tag: 1678760374-818101 X-HE-Meta: U2FsdGVkX188wZktgeohlsARAAaV3fbIJl1tjsi2gb58wWUtNzVHrBNe7RlzslzA5LMpg7GlN4GcgKMGfNQh6pHrSovCAFy15Gfm53JaMd2Pe7+gKi+Qy0no1bl9apir2MJ1JWwW4dLC3Cqrb510Cw2t95h5tOTqGuw02e+ufd0xbWFct5zns+cnH+5CaQP5mW9qyyo3It56/gvKhBz3CNfJzw0Me/iK7TbXPVJEGHdUGb9jOVBVvdzl5GrBqc4yWs8L8Zkd+dMp7gQ0jSp7AzB5VsWhqgv8GrvQ/FPaEIjAESxUy/bQaLYMMoQxujtNB2ybBEONuFhIa83UJ3DR9uIwtHACgvwi2resq/CFVQTISOeV0CNok5hgl1Ws3N4N/gU5qAV2q/0OXMgP5+iFIPCzhdO6JPhlji/EKU1QZEQi8ILKJC3lHFFzM9GlL/tMV02eg5nxgYRNqSEi6DublAOw3blCUVBgztStRIGQEn+kGjhjorPUzvpEI2or4Ut8rwODK3flTVPIGsgNV/byYik0Yr0mF9F7E480IdyjaPVOGrgNZDS4dLJDdvPMR1yQeUu6yz57Ob9io40BsipMnikS1yooboYouQqapEYy0IKUJwaDdV0dVxHKbtbckj6AHyNCDLt3vcqJ1WznTnV0OaZx1V4OsgSQPRAeIzcALytQluRkm6QSnwIIs+ZzpPdGmMnim5RZEOKeFYvdb+drf1A1KdU6u6+Bkvev0Flbx6HICo46lFEzWIGgiGQAQdj14K5dJAbHAmTUMGAMf2UJmoP2QRaZukPVeE1gGjmqdMEyphFQP7K9PRNW7inMphsZULCbGGYDimQbNfL1jLLUXv7FeILfH+Bm2nsujB/C8Fd+OTjrYqqZGOXG4sYzFfNw6lJ4k4IVf6N7lmXdomsg5JpqJSRZ+bu1ZjrRN9sTDYdmuvZDt6piqo64gO+9YQOawqNdXYkyQEU2YK44ckg YYA7DXop lZoLfnqK3EKvcOZAc93bj0u7jziJVfr1ONBmHQOPFhG8T3e33KM3HwfaC0eVP9HH7Ubw6A4G9g7iXi1s9YCyocPXhpeWmJMfoRwTfRjMFQeEQKPQqUlIw8iJc3FYnaDBwO0VmvYJuUCX4kIaN9Mx0gJBGOysmecIB61YfEOj3hkcJTr9UT4SL64xh9on7KPa8XSApIiyh8s00MtsU3SEWKoH5VNJq/8D/0CN5FpBP060vAjKmQOxjSkDnye+N/8FpI7UE36p2uAtjwYcZ2U9l4dPkg1/Y7EHCuyNLPpRusZWq4012JLnsREwpMbu9TWNC03e3zAkikCuB0/hs+lnqMo/QUort+hPiRX2jx3k34D4TacAJWiLJzU3vGZGzx2BpCNxf1u/QUN3LRzyzPav/UVLANRgLiH0j1y9J5zEvvztn2ZeNe/0zlb999hz0aO81FzTLxUrNN/3bkl4cXmF6/DSL46DyDFCfg8LHdMRXtnK4pul1N9/V8o7HvhCF/C+9J0fziFjEZUEHGdXOvKjPluQcFR3Uf+csJ/X5u6pzt+tdRW12hcHx4Gz/0lKVB5T4uj5IO2hBy8QX6YLD8AEE7f5y2ButAJpa2q463V/3Lxy/L0ZYTBRLNqU5dPyJtbyMIYhXf4srSK4ojERiTL15IfHAYbCgLkAO/1Ks0KTIUI6+W8mGkBdMSqR01q5rSK+2T1vAe7OjfzSEZVg65Yals0R5ZA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 14 Mar 2023 10:10:42 +0800 kernel test robot wrote: > Greeting, > > Previous report: > https://lore.kernel.org/oe-lkp/202303100947.9b421b1c-yujie.liu@intel.com > > FYI, we noticed BUG:kernel_NULL_pointer_dereference,address due to commit (built with gcc-11): > > commit: 480c454ff64b734a35677ee4b239e32143a4235c ("mm: return an ERR_PTR from __filemap_get_folio") > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master > > [test failed on linux-next/master 24469a0e5052ba01a35a15f104717a82b7a4798b] > > in testcase: trinity > version: trinity-x86_64-e63e4843-1_20220913 > with following parameters: > > runtime: 300s > group: group-04 > > test-description: Trinity is a linux system call fuzz tester. > test-url: http://codemonkey.org.uk/projects/trinity/ > > on test machine: qemu-system-x86_64 -enable-kvm -cpu SandyBridge -smp 2 -m 16G > > caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace): > > > [ 29.300153][ T6430] BUG: kernel NULL pointer dereference, address: 0000000000000000 Thanks, I expect this is fixed by commit 151dff099e8e6d9c8efcc75ad0ad3b8eead58704 Author: Christoph Hellwig Date: Fri Mar 10 08:00:23 2023 +0100 mm-return-an-err_ptr-from-__filemap_get_folio-fix fix null-pointer deref Link: https://lkml.kernel.org/r/20230310070023.GA13563@lst.de Signed-off-by: Christoph Hellwig Reported-by: Naoya Horiguchi Link: https://lkml.kernel.org/r/20230310043137.GA1624890@u2004 Cc: Andreas Gruenbacher Cc: Hugh Dickins Cc: Matthew Wilcox (Oracle) Cc: Ryusuke Konishi Signed-off-by: Andrew Morton diff --git a/mm/swap_state.c b/mm/swap_state.c index c7160070b9da..b76a65ac28b3 100644 --- a/mm/swap_state.c +++ b/mm/swap_state.c @@ -390,6 +390,8 @@ struct folio *filemap_get_incore_folio(struct address_space *mapping, struct swap_info_struct *si; struct folio *folio = filemap_get_entry(mapping, index); + if (!folio) + return ERR_PTR(-ENOENT); if (!xa_is_value(folio)) return folio; if (!shmem_mapping(mapping))