From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DFF9C6FD19 for ; Mon, 13 Mar 2023 16:27:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A738E6B0087; Mon, 13 Mar 2023 12:27:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D6DC6B0085; Mon, 13 Mar 2023 12:27:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 749C56B0088; Mon, 13 Mar 2023 12:27:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 431C86B0087 for ; Mon, 13 Mar 2023 12:27:50 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 06DA61609C5 for ; Mon, 13 Mar 2023 16:27:50 +0000 (UTC) X-FDA: 80564406300.08.454AC1C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 3FD531C001A for ; Mon, 13 Mar 2023 16:27:48 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=H9S0VYSU; spf=pass (imf21.hostedemail.com: domain of mtosatti@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mtosatti@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678724868; a=rsa-sha256; cv=none; b=rUad3RyFrC9IdRla2cL2i2Vkabnl1W/OYMYDsHu84obX75EpCK3C4120PfV1DA1WMMdiV4 79NmH9D1dGq6hjqydgfMmbfZhk7hckkOV70P1W7CUsSZx1mhBf7BSG+Jp14mFW0w4sO0xH +921p+z3W7TGKk/esWkeBBky0kV0hL8= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=H9S0VYSU; spf=pass (imf21.hostedemail.com: domain of mtosatti@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mtosatti@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678724868; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:references:dkim-signature; bh=/KQqYUQDwTZyYbpRZbwn7x1mgss03C//4Fvg72sL2vY=; b=dYrFEZnqT85h0fTUZxI2oV3WL+toL+WRbNZPBJk3CwPnelR4Pwzqe0X2lVB01VFbMWVDyD WG9NbAKC5AwkyFrYj3RHfRdPtfi82v/9rjStJkj2Sm7gvHxNOqHx4rdLgsVbz+yK787dDQ AeNXjgl+mZodZ2vaA3fV+5XXttfXZ8I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678724867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=/KQqYUQDwTZyYbpRZbwn7x1mgss03C//4Fvg72sL2vY=; b=H9S0VYSU8tZO5hcZveJ9+GtNnLoncamRvm1simoZPcL2HZgWbjXvz9fw/7yKl6+l4f+lau UoMG2/YqqX1IFovZxYPnX5kg+nVSt/ybXKv2GKqA4jJHnjTxIjujtBTT2DygNl0pcm++KQ 73XJhmpXUUcnW11YCqziip8eDebJxdI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-391-DQQRGpshNVW6Jcd0FnfZLw-1; Mon, 13 Mar 2023 12:27:43 -0400 X-MC-Unique: DQQRGpshNVW6Jcd0FnfZLw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0474C803481; Mon, 13 Mar 2023 16:27:42 +0000 (UTC) Received: from tpad.localdomain (ovpn-112-2.gru2.redhat.com [10.97.112.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C9959400F4F; Mon, 13 Mar 2023 16:27:41 +0000 (UTC) Received: by tpad.localdomain (Postfix, from userid 1000) id 348BF4038AB89; Mon, 13 Mar 2023 13:26:44 -0300 (-03) Message-ID: <20230313162634.482796394@redhat.com> User-Agent: quilt/0.67 Date: Mon, 13 Mar 2023 13:25:16 -0300 From: Marcelo Tosatti To: Christoph Lameter Cc: Aaron Tomlin , Frederic Weisbecker , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Russell King , Huacai Chen , Heiko Carstens , x86@kernel.org, Vlastimil Babka , Marcelo Tosatti Subject: [PATCH v5 09/12] mm/vmstat: use xchg in cpu_vm_stats_fold References: <20230313162507.032200398@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Rspam-User: X-Rspamd-Queue-Id: 3FD531C001A X-Rspamd-Server: rspam01 X-Stat-Signature: ii3a4ac6rj59huuj6q1qs19gidmzwynh X-HE-Tag: 1678724868-409556 X-HE-Meta: U2FsdGVkX19SWSc8GCoL+S0ZP+8UZq6VvxSBVfMjbL/Y7BMuKs6/EfhnNj4ODI5p/tEP8hcs1c+gxI7A7zi4Lo03ZBcz7sEqIrSJIf79TFEN28fhexBoUATBR5qq9aHeNroWdjpU/4ldBUas41Gik5Xu6lCVY9gBSf5odpEEpsIlLeaCkn8LDee7m0YXZCr727jnJVKY7fqj5DMml0yI0qf6syAXfk1+EFu93kvQfmLONmO+P0RZ0Ar5L6dLhYfJ35o5HerpV8UgIJnK3LQySL9nXfnZlGpHtKCP3hQzrF6V4GD5fRyrFgUgJEhKpzlSYQGEuz4u7nWg7/6+72UmC5lJdeioRvWxRvibPDOb2bXVN0XNtXNsCFzbqh1sB3Lw11ekYVkxPKHvoNGJYxXoQlXHs3Km8oxzhl1ziMLS7onY39FF7Zi3ZGwb+LDCC95pntIfuQtM5VeTHP2v8H7qk3RzCiUjjvADriFljce+eId5KAq5IJgZurkpnJvwXDbkjkqe3/hRUvNOd1n250yNLEuXtnQPenadjInYalcAxNvcCIFdgBj4BW/RrONbUuB7XbRKHMCrVbeBPM58oYg5HpLbnMOAcC6eFwMnlTTeaefzuZaqhC5582p0HFwDtWhRq4qvzAoBHgKNHwBApYdwzMVmHyMYh41BaNFNTbXWE6nC2m8YKjujw1YxQUaOWM6VBP9Go3z7QugZhpnK2gdteO1kq4p6WEtwhKiHGd9dmG55DnsUn1Y718tidU+Q5iBzEce3qqIVJxCglttT1wS2YFkHWRM38nD+obXiPM637IG2enyFpFadEu/HeZyhCw4EAY2NaUpBCcUzOVfJXEYpSrbVqpqvuQXh9kPAaKj82t1lWsne92WaqQPSQCekcGR8ZvBHh2aqL5w0oFOaejIjUXomfKkBnzaf8TLEL4Lo7Yjpay6BGD8zD8ED1UfLVnVkFioIeYmNdExCmLic5sq s2IL0d0w BOQ7JHvqcxpR00dmXm1ngoVaTWxC4mJvovW1bLaYhxeJsAk6mQChq4Fsi7yORPnuMIXP7AAUj6ot6hsb8sY0zyrBZ7JBpocNuaXGAKZb3QOs481Ztv3P3GhIvzJALJo74oIRaPLiPosDF78W4utZZrWjK2DzKihe8jQGiysdKOSqtxG4xtBB6xEm7qxuYyROXkboU7xoaT5Sq51TPpOVTv8OlQ53ZsDjNl++oxCUL/W3K7PttVrxtRyIIA0pw6O6mJSN2Va5fFzI1kOvNOjOeYVpiZw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: In preparation to switch vmstat shepherd to flush per-CPU counters remotely, use xchg instead of a pair of read/write instructions. Signed-off-by: Marcelo Tosatti Index: linux-vmstat-remote/mm/vmstat.c =================================================================== --- linux-vmstat-remote.orig/mm/vmstat.c +++ linux-vmstat-remote/mm/vmstat.c @@ -924,7 +924,7 @@ static int refresh_cpu_vm_stats(bool do_ } /* - * Fold the data for an offline cpu into the global array. + * Fold the data for a cpu into the global array. * There cannot be any access by the offline cpu and therefore * synchronization is simplified. */ @@ -945,8 +945,7 @@ void cpu_vm_stats_fold(int cpu) if (pzstats->vm_stat_diff[i]) { int v; - v = pzstats->vm_stat_diff[i]; - pzstats->vm_stat_diff[i] = 0; + v = xchg(&pzstats->vm_stat_diff[i], 0); atomic_long_add(v, &zone->vm_stat[i]); global_zone_diff[i] += v; } @@ -956,8 +955,7 @@ void cpu_vm_stats_fold(int cpu) if (pzstats->vm_numa_event[i]) { unsigned long v; - v = pzstats->vm_numa_event[i]; - pzstats->vm_numa_event[i] = 0; + v = xchg(&pzstats->vm_numa_event[i], 0); zone_numa_event_add(v, zone, i); } } @@ -973,8 +971,7 @@ void cpu_vm_stats_fold(int cpu) if (p->vm_node_stat_diff[i]) { int v; - v = p->vm_node_stat_diff[i]; - p->vm_node_stat_diff[i] = 0; + v = xchg(&p->vm_node_stat_diff[i], 0); atomic_long_add(v, &pgdat->vm_stat[i]); global_node_diff[i] += v; }