From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34D6FC6FD19 for ; Mon, 13 Mar 2023 11:06:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C44F56B0071; Mon, 13 Mar 2023 07:05:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF41A6B0072; Mon, 13 Mar 2023 07:05:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A953E6B0074; Mon, 13 Mar 2023 07:05:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 961F86B0071 for ; Mon, 13 Mar 2023 07:05:59 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 60435AADC8 for ; Mon, 13 Mar 2023 11:05:59 +0000 (UTC) X-FDA: 80563595238.28.68AC0B5 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf01.hostedemail.com (Postfix) with ESMTP id A41A44000E for ; Mon, 13 Mar 2023 11:05:51 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b="ozHa1zi/"; spf=temperror (imf01.hostedemail.com: error in processing during lookup of bp@alien8.de: DNS error) smtp.mailfrom=bp@alien8.de; dmarc=temperror reason="server fail" header.from=alien8.de (policy=temperror) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678705554; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WNDMylAInwsppeYyZOJK7Jz1yVA+TciusPUv+jlQGkc=; b=RdjHk2DUeOs46t9a/8juR7a+Ryli5OnMYshZb0bWdaVAA5+MarzKjWV3R3eP90FYsTQ6RT 4CHzNCjJizRjRdp+6IoA0xGV8xbiZralCy6x+tPHp4KgVUYwjkAPPLeMKftibssMeKOCzz j4Tb9plHU8I6kqt0LfWE8TlboMHdBts= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b="ozHa1zi/"; spf=temperror (imf01.hostedemail.com: error in processing during lookup of bp@alien8.de: DNS error) smtp.mailfrom=bp@alien8.de; dmarc=temperror reason="server fail" header.from=alien8.de (policy=temperror) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678705554; a=rsa-sha256; cv=none; b=T329V40dtCUAroMKLyJZaY5LcY2YrFipyaWcjf6BaPZdeD7vWzytzHJUzRv71HvVLqZ1IV SeumX32n7loLE6KjfW4CWmR+oJVf00C/Q3MjBYDJ2Gj9RRcU0VaAu9odrXKmgHAK6Kz3PK z+n9dh6h4h0I/h7uEVujlOUWj13GV3A= Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 2DD021EC04DA; Mon, 13 Mar 2023 12:05:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1678705544; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=WNDMylAInwsppeYyZOJK7Jz1yVA+TciusPUv+jlQGkc=; b=ozHa1zi/l5kctzIp5XnqLpQ1KP7+CTEjb8SiUCRN7EFlvoe7oqT/uqk2iab7eLYk7Nisw3 1vVPcM4AMCKBELmtt3XCM8Am3MTzKrQdU7Xt2nQ2Vid/zgq4frHIQ5HqIhQSlGASxZpZDl 3C26yhB6WoPYGZz1c+zLdXwyZ9Ie+VI= Date: Mon, 13 Mar 2023 12:05:43 +0100 From: Borislav Petkov To: "Edgecombe, Rick P" Cc: "david@redhat.com" , "bsingharora@gmail.com" , "hpa@zytor.com" , "Syromiatnikov, Eugene" , "peterz@infradead.org" , "rdunlap@infradead.org" , "keescook@chromium.org" , "dave.hansen@linux.intel.com" , "kirill.shutemov@linux.intel.com" , "Eranian, Stephane" , "linux-mm@kvack.org" , "fweimer@redhat.com" , "nadav.amit@gmail.com" , "jannh@google.com" , "dethoma@microsoft.com" , "rppt@linux.ibm.com" , "kcc@google.com" , "linux-arch@vger.kernel.org" , "pavel@ucw.cz" , "oleg@redhat.com" , "hjl.tools@gmail.com" , "Yang, Weijiang" , "Lutomirski, Andy" , "linux-doc@vger.kernel.org" , "arnd@arndb.de" , "tglx@linutronix.de" , "Schimpe, Christina" , "mike.kravetz@oracle.com" , "x86@kernel.org" , "akpm@linux-foundation.org" , "debug@rivosinc.com" , "jamorris@linux.microsoft.com" , "john.allen@amd.com" , "rppt@kernel.org" , "andrew.cooper3@citrix.com" , "mingo@redhat.com" , "corbet@lwn.net" , "linux-kernel@vger.kernel.org" , "linux-api@vger.kernel.org" , "gorcunov@gmail.com" Subject: Re: [PATCH v7 40/41] x86/shstk: Add ARCH_SHSTK_UNLOCK Message-ID: <20230313110543.GBZA8Dh/Ov/Jbmjot1@fat_crate.local> References: <20230227222957.24501-1-rick.p.edgecombe@intel.com> <20230227222957.24501-41-rick.p.edgecombe@intel.com> <2c67ed3b9dd93e215e5e7489ad56373da789a84d.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <2c67ed3b9dd93e215e5e7489ad56373da789a84d.camel@intel.com> X-Stat-Signature: swgdmymzthkrkifruoc3r7ipdhn7food X-Rspam-User: X-Rspamd-Queue-Id: A41A44000E X-Rspamd-Server: rspam06 X-HE-Tag: 1678705551-35684 X-HE-Meta: U2FsdGVkX1+AoxoK/zXLGDGbMw++ORCZDVEYjW8e1dit67k7Goj/q47Cgpk5b17yEJASBunr7EnFB8zEZqw6Cj+WvOs+4Mr04Jx/UZd3lJTspuCBOiiM8uG/FV/fVZ5rjYdK6oA3/CkgJsuuAvdE7Bqjg3JJuORSpyY7dRxDSSvcl4kSLO9mkj95f8WHoWwTihNxn1xVlaqz6YGgyTr3a9appxyH3MUj8WA1/tL0OevWaj5oU/1g1m49Y++PQZsRuE6iZjNvrxP/3ri0UUhJWS1QronoVphFuUCSRHgdUmzO3lhyeNwSEP8N7+cu1br4fALn4e0srPCNlsBVb7J1kldApPOk5EzE1o/PXW63Z0cmrdEJeRNkhnD5oJwz8PrxfUNnWERZn1NOukFxb52JDL186E3JhWjTXb/9QnedMY5AuBquIkzfKc77CkfRQjGvv5newy/D0tjBNGv7Vs89GXo9uGZyC+ODJ/LEvQoMCK7IapC0XcfhAXZqfg7fxAVu0AI2dlkNJhEZIaY2VEOslC5kBqX9D/EbBUBVvQOTdhZT02U/kBeNtBgC0N226KQu6PFnameAfks6273gwM7tUwgsPNaVgkZPI5fRWISD80U4itwFTrnYxGZQDUX1FKC6SgTScicOjtzrCis9tvaJF2fIytgyDzgolHsrP9uw0l9eF7Qk89UQdcZq/7KmP5ywsVECa3fG0R06wI/6f6NLKsmv5pJ91ykEyawc6MImHqXu7PYg6/vJuIYtzUt19waSzVIvOP2467so6G5lHcZ49gS8xPh9MGuFPoHuR6oDpU8KvAtQbYqUZOmoo8qEpnqY/qbEpE6CVMXn70xN7kvGpcZ737tUcbC+sospQiSwhZtczlr3sRB2DxOq300nzY/9mihQWEZTCF9ClQgys/crw87kUNbpOiwHUpvfWM5DdHRliMJx+WWkUn5G/O5/Roh7E3gUB5cGh8xlAP/OP7v zNP9p68o WFJYFyV8RKBHMQAH6mzSdLXYEfOvHFZYSL0Ebb/O+PYc6x6lQTYDeK6YXz9g0SO8MOd2hPnxEiMwoJ1dPwN1hY7mQwbH7pjXoB1Ot420xwZU0XD8I1cA0+21FifsiTKVRR7Cei4JkdTDDeN+zqklR3oRgYx2ESh/hU024iIdpa7nBN1G9OPZoAu2HKXpCWxL9JtuhYvAaT/NcH9zaCeCung37F3Eb5fN8ZYZY+wwTgqGRUqexJk8UB+zpCgwG+//bDKXTQTOH91Q8HkOxuMn+MwsQXWSlwa1txOiZW7GXr/2/zdXfzmybrI47hnX2yfGC7hLDLFCnzYGkampq+BmuHTloIGkedqjFpN5tZBA5FDLW6QDtN4Q0IR6qw0CVglAuqXrPWqKCU/NY+BunQmv+Coy8k2B+s7RNuyXYdVdj70p/WBxEZzQNGg5jL4sw/OBjSapaG8PXZIHRJ9gUZ8QPJPomjhRNXQLuuPzoSBD8LfZ8yONf+guEwbk1bmDLS6cO2bEViExP3sLE7UK/7p113/AN4LEO9to3cAfRuSxtU1eMyLSBoyL/F33FJbtFhjItrLC0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 13, 2023 at 03:04:10AM +0000, Edgecombe, Rick P wrote: > This is how the other arch_prctl()s handle it (if they do handle it, > some don't). So I would think it would be nice to keep all the logic > the same. > > I guess the flag might work based on the assumption that if the task is > being ptraced, the arch_prctl() couldn't be coming from anywhere else. > Maybe it should get a nicely named helper that they could all use and > whatever best logic could be commented. > > Would this maybe be better as a future cleanup that did the change for > them all? Yeah, I'm just being overly paranoid. Because if there's another way to unlock that feature, then this whole "overhead" we're doing is for nothing. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette