From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F318C6FD19 for ; Sun, 12 Mar 2023 20:50:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D42988E0002; Sun, 12 Mar 2023 16:50:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF2528E0001; Sun, 12 Mar 2023 16:50:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE1E68E0002; Sun, 12 Mar 2023 16:50:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AB6D28E0001 for ; Sun, 12 Mar 2023 16:50:12 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8211A120A53 for ; Sun, 12 Mar 2023 20:50:11 +0000 (UTC) X-FDA: 80561438622.22.1946A9A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id C96EB80008 for ; Sun, 12 Mar 2023 20:50:09 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ZdciYdaA; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678654209; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qrDyXVCx27kiA+3tgaVCSsQ8jSivGVzovCxzbPnUwaM=; b=0a9RRt/6C8y6OB3xTQDuLBR39vzk5tWLpAuOv9WOWp6cS1MbniXlefIV+xLo+VEPMMxmYy 1BNKLq44sZMSaBdxHeKtHcPlasQnnBR73DurWP4hdy2YycT1zTxxmg79ghrWNs9y0w9wEy 7juBmYwMmhZdFru7mHd6bNaIv8wy6bc= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ZdciYdaA; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678654209; a=rsa-sha256; cv=none; b=md82hp9t9zuP/Sg0t7p+46lboXbzStUWnIY7bXGEB1NGMCip1PW+eCe7HK1/Ey6T990fM+ jY5FSAxx2XVvI7RLfFxtr8S/853udEwvXvqeS2ASnK8jCQEjyjVRtfUL085/GY1dKIWxdu K8hjUPfphSkWXgWugL2Z2r9oW0os/Ug= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D1BD460FDD; Sun, 12 Mar 2023 20:50:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18E20C433EF; Sun, 12 Mar 2023 20:50:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1678654208; bh=9LYsWqzzKgaDmQwv3KDskqOC/HJwLvXuguPk+Bof6rw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZdciYdaAnnGvdIKOMxL9QcZTE3yz7x5ChSV9HgxVnkq7PojcgSDQ3AqhGzaBiPkTX RC0gQjSmyEs0GwIYl1fU3oxZl3wdlfS8a3KW5ExsMH1hVTpE3o5yGmgxVAl7rQzYoZ 8e2qrPjPTINZBwkJx1+rE/BE/8gW+qIaUMGFvncs= Date: Sun, 12 Mar 2023 13:50:07 -0700 From: Andrew Morton To: Kefeng Wang Cc: Naoya Horiguchi , , Miaohe Lin , Subject: Re: [PATCH] mm: memory-failure: correct HWPOISON_INJECT config Message-Id: <20230312135007.05a4fcea4d26c698a5d48b43@linux-foundation.org> In-Reply-To: <20230310133843.76883-1-wangkefeng.wang@huawei.com> References: <20230310133843.76883-1-wangkefeng.wang@huawei.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C96EB80008 X-Stat-Signature: ub4pqyriozabpwf6w8x5efu66jx3wgim X-HE-Tag: 1678654209-982634 X-HE-Meta: U2FsdGVkX19ff9xVn0jAgpAKd8Su1EYdjJYvCgCJSfN//7q2dldPiuGb1x/khghRehJqrC0Z0z+KmZYv0KBw8L6lXxwVc5yg1ra9dWr9I8s/3PdmaQjT/a8x4F7BkTBHQHYlcJbusoNSqyOdXtZyZzEtebZ7ByXHcXBWuAV6vn6WRfQgQlZoTVPgvCbpqUdIysV8Cl6iItEAgk0AVGVYr8l2cmim3Ug4FIkDI6KYVnOELPD4pF6D9fudj/aZ5Khy+qlDTfwqZPpZ1OJnfYtkAxEslP9RhWbBqIIPSA+voS4lrAVYhOlUlLqsOVk3vTbEB5lnpvbzcIMfkJdEaVAfQGJRvWHZl1M9dML2541fjdElOppHwNYOUJQ5Et2abKEzyxSAlw8xt60pEoaKm/jKusFT8Q17bHk+1tF376IdIsiT3n+AWrxGjRLId5q7L1Un70QHqRsIVHP6ZBPaV+Rx+TFFCD9S7z8WIgWPdNkDIWiCc8jLu/SwSq51/X2LobFWScJgxYgVYew/QR9Al/qTne0vTsE8qHB341EwgxSUgLOGboYlTBy3n6VOVOPm0C5361/pkBnL4pYe2xtOK2CY6NxOI1BvAiYFuqlsnDf9Ru9m9Kv4ump3+6lLjMW9iMwyTDGC3NZorT9bHwKeEknY085qmi/YuOPqNFQ6pIYZBrvMujU9EgMgfpM78tl4nxWoEsWwuInRFotAzMIqu7Cij5gUlBqivd1XBvtbMRYFRD8MbSBGeg6qfe5KkwRE5XlW3BMH+G/buWDOpoZrAPyz6vnbJY4VQ7tTrIurQibp1whVbwKGrbaZuBdE5kcBchQo85PiIeuDK6r8JluWVTDPSoi+F2sgZc1OhivmVCqs5mZVEIygt+z/Rsu/G9gbg5ZOLFyVlRh8dtn6hXtSGdYXiBo+JIdmcV3YaLoMHam67QYZ9lCUx9PCRgrOFJWRWJAtogmhsD3Kc5KX5T91JiS Jo9Mu92B wGDWmxqlHfAvSiU3UuUKVIyIXZQdL7Bazk7HaGc+e89fxocYM6kEAOnf4cWA+oxxZAU8eR1iMr3tipFBZKlXmo+r5k1igT/d/wQsZJTgtgJAkYO4OZEk0dZkA0j+t8KWWgHGTM0kW8jyrrxasZEtNfNweoCyLksQkXDhEJjtHdKs6K0DidzDMgsGFVp2mDVBIN1IMmQxB0Sqp/pbhDvtXo/roPlB+tUAE2FxPrBA4GqbGJNaNKaupU9H8AspKHC9WC4tmmDchvpWeVfVWJhx5FejrHgISQG8xFbh9COKT6SEGD2cCfV9ns9zIjm1pioTTa7HdqxQiaNBfl2wa/rtyMNVbqWWu0nboYuoZq5MXhubZf7iNmlz96Mj9DDae/4GRrm0KY5CDRY/U+6+/tz0CssFECKlXVrjiLU5Y X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 10 Mar 2023 21:38:43 +0800 Kefeng Wang wrote: > Use IS_ENABLED(CONFIG_HWPOISON_INJECT) to check whether or not to > enable HWPoison injector module. This is quite clear from the patch itself. What is unclear is "why". Does it fix a build error? If so, please describe and add a Fixes: if appropriate. Is it just a cleanup? etcetera. Thanks. > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -168,7 +168,7 @@ static bool page_handle_poison(struct page *page, bool hugepage_or_freepage, boo > return true; > } > > -#if defined(CONFIG_HWPOISON_INJECT) || defined(CONFIG_HWPOISON_INJECT_MODULE) > +#if IS_ENABLED(CONFIG_HWPOISON_INJECT) > > u32 hwpoison_filter_enable = 0; > u32 hwpoison_filter_dev_major = ~0U; > -- > 2.35.3