linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Naoya Horiguchi <naoya.horiguchi@nec.com>, <linux-mm@kvack.org>,
	Miaohe Lin <linmiaohe@huawei.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: memory-failure: correct HWPOISON_INJECT config
Date: Sun, 12 Mar 2023 13:50:07 -0700	[thread overview]
Message-ID: <20230312135007.05a4fcea4d26c698a5d48b43@linux-foundation.org> (raw)
In-Reply-To: <20230310133843.76883-1-wangkefeng.wang@huawei.com>

On Fri, 10 Mar 2023 21:38:43 +0800 Kefeng Wang <wangkefeng.wang@huawei.com> wrote:

> Use IS_ENABLED(CONFIG_HWPOISON_INJECT) to check whether or not to
> enable HWPoison injector module.

This is quite clear from the patch itself.  What is unclear is "why". 
Does it fix a build error?  If so, please describe and add a Fixes: if
appropriate.  Is it just a cleanup?  etcetera.

Thanks.

> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -168,7 +168,7 @@ static bool page_handle_poison(struct page *page, bool hugepage_or_freepage, boo
>  	return true;
>  }
>  
> -#if defined(CONFIG_HWPOISON_INJECT) || defined(CONFIG_HWPOISON_INJECT_MODULE)
> +#if IS_ENABLED(CONFIG_HWPOISON_INJECT)
>  
>  u32 hwpoison_filter_enable = 0;
>  u32 hwpoison_filter_dev_major = ~0U;
> -- 
> 2.35.3


  parent reply	other threads:[~2023-03-12 20:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10 13:38 Kefeng Wang
2023-03-10 14:13 ` David Hildenbrand
2023-03-12 20:50 ` Andrew Morton [this message]
2023-03-13  5:10   ` Kefeng Wang
2023-03-13  4:25 ` HORIGUCHI NAOYA(堀口　直也)
2023-03-13  5:39 ` [PATCH v2] mm: memory-failure: directly use IS_ENABLED(CONFIG_HWPOISON_INJECT) Kefeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230312135007.05a4fcea4d26c698a5d48b43@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=naoya.horiguchi@nec.com \
    --cc=wangkefeng.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox