From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AC50C6FA99 for ; Fri, 10 Mar 2023 23:25:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B3E36B0072; Fri, 10 Mar 2023 18:25:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 83CC18E0001; Fri, 10 Mar 2023 18:25:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DD606B0075; Fri, 10 Mar 2023 18:25:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5B9586B0072 for ; Fri, 10 Mar 2023 18:25:49 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 297081602B6 for ; Fri, 10 Mar 2023 23:25:49 +0000 (UTC) X-FDA: 80554573218.11.2678494 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf18.hostedemail.com (Postfix) with ESMTP id 66C7C1C000D for ; Fri, 10 Mar 2023 23:25:47 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf18.hostedemail.com: domain of "SRS0=GJLE=7C=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=GJLE=7C=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678490747; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Myo/VhVwzVsnWs5gquGzmpq6fZ/K29jj4TZHLNtQfuc=; b=lmLswZ8Fu91vA2okEQ8I2iANrJmmLfHPPGh22i7UFloF6glUNfLGiVvjuNTTV25GY5SfXV 3BUxaU85ImMZOUjmTf2HZLjeeyM1/nD9BkJvoxyBaJPiFmzharHpuCqJwY4G/dFR3K6BF8 NUzVVmOiH9cXB14pnp9L/pH+dMQDUCM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf18.hostedemail.com: domain of "SRS0=GJLE=7C=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=GJLE=7C=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678490747; a=rsa-sha256; cv=none; b=ypQfb89X8eAuaRcsrSyYYmF3lGXD4oF2RrK3JMmZRuBMwU7HcOoUcDixDfZXzFpzaz0mw9 au2a5JFlo6C4RyT9mU9pJjupclcpZCBWMh9VI+ZjtJjjuFzp7WBdnchfpXdUSuG2PIv9YK 3j5BuwuQidq40jf2eILoruuCrkjnu48= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CC563B8244B; Fri, 10 Mar 2023 23:25:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8A1DC4339B; Fri, 10 Mar 2023 23:25:43 +0000 (UTC) Date: Fri, 10 Mar 2023 18:25:42 -0500 From: Steven Rostedt To: Minwoo Im Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Masami Hiramatsu , "Matthew Wilcox (Oracle)" Subject: Re: [PATCH] mm: mmap: remove newline at the end of the trace Message-ID: <20230310182542.695e9933@gandalf.local.home> In-Reply-To: References: X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 66C7C1C000D X-Stat-Signature: onp959t1kse3m554pton6wdobhp4c3u4 X-Rspam-User: X-HE-Tag: 1678490747-588276 X-HE-Meta: U2FsdGVkX1+20ew6dOSjN3XRKSeg/PP82dqAa65BrUvRuZ6os/FIgasoR2Oi7PaocTmoyxuQgB7De17vAJvmpV4LhHfWHMZKz4pBBYDrjwiXaC8FUZi01dVbJee5+aWVBi60jRZprVL2ADWVqrXAGbsaFAePNPACtWKJiquXJJBeKp5n7TXVez6YpkHm90G3CLstpwAPIuSarRnTtxv1rAoy3ADM32C9unGAdh1qMrbYDb/l1q6QR9l0MeceFhBpFpZ85lRD/gmCTeR2jPi9F+ZCijeusU5IhvmbglT5kiVNBDIJ5Ec9/uBeMbj36B10dVVRYdVmhOKOh8xqR63dH52/MZhyKVOhp+vBmZXqzS0Bry9xB9EfYCgt2XRiq0c4OVM33Xe+uu6cPVrOYdIAA78jMWPl7/VaW7EAbyif0dyqzR76+1xFQQxgfMuWkCJvP4NYKQeezbUSWs3uPvX+LdJv+TrE7/OpvPmMuUisVNbmruzZEiuBz8FgEZws36+xvODixsabqoWNucyfUDb5EQTJGXUwQF0upmIucovAyVSsbgVRIXIDwffbLOkyJpNWQN1AvPD8oxkGhhVzeqst63CzF7IY8tWexq/66hixGQw9dZScqp+oX6FbENIvwifmsf7di47rG6Xjd2FIqJCO1IRLtcMRmrfQCOMZexqdytByPpFxaHG1AfJkaHT9pSnO8mIQ6jRghH97dEOh9k2Da/toqo1p3Z09vw0039YVjBBMonZ8Xbdi+Rt1yYo4qnh6idYnNgFkRKmKyyp4L5ujOeoMXx8oC2US9Co19G5NyFsI68qcZ+Nnbm5Q1m2kT2Ff8KqA3vz4AjnL+KqSajtSXQ9d6j7Lqy+UIRusEHb8pdCidyLe+CDSFA/atm9Z9EMNGjjBEBZLn7PPqHu8nPyuA4sCN0Fa8zTs3Cz9k0kSBjtw/QhNEZPK4jT3h66eG2np1RxWGu9NzKsgih+NR2P EM6XVnur vEHJWeXE9ZbucmaOrdxDAWmR6uMB+r1xearl3JRSJe0X0PYDIlJsnRnQSR1RF92lC2q11qqOLuJap8GL/uROSLIYHvqxEy1rwT2y2gbu0UkjZ43ZvJKc2VP+cKkxROZJ7bBa4ESl+5+IGsghfn1QhAzU4k7jAzw/AE/3bBRCEo1g1+hXM/TQsHu1CfVIxSyW85Ns7bTNfQlguZl1+ES4KRpsK7WUvpGROvb5FSflYcgG6Bu7GXzq+2EgmYN3OIPzaONOcO+XLaALG7htgnYUphjiawuCa215HdMpV1f7rEg/teRARIUZtoH4H1X5sneOaiR34Eg2yZwWekeUf33hwmBF7mYQd6iXqLhgr63gvgXaCt+beJKpHV7qcrlEJIbmWbAHA93qPaxMjUQB02vL1rT/548owcvq076c1cRRUYox/xoyesFzFjjTpgl0BzLx5FmlGF21vXyN9/a114DX/7IbF9ogEl4RLSnITIUmV2p1YiVPbJak+YNs+ID0b05x3cSxdrgfaeRf8LfQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 11 Mar 2023 08:18:00 +0900 Minwoo Im wrote: > We already have newline in TP_printk so remove the redundant newline > character at the end of the mmap trace. > > <...>-345 [006] ..... 95.589290: exit_mmap: mt_mod ... > > <...>-345 [006] ..... 95.589413: vm_unmapped_area: addr=... > > <...>-345 [006] ..... 95.589571: vm_unmapped_area: addr=... > > <...>-345 [006] ..... 95.589606: vm_unmapped_area: addr=... > > to > > <...>-336 [006] ..... 44.762506: exit_mmap: mt_mod ... > <...>-336 [006] ..... 44.762654: vm_unmapped_area: addr=... > <...>-336 [006] ..... 44.762794: vm_unmapped_area: addr=... > <...>-336 [006] ..... 44.762835: vm_unmapped_area: addr=... > > Signed-off-by: Minwoo Im This should go through the mm folks. Acked-by: Steven Rostedt (Google) -- Steve > --- > include/trace/events/mmap.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/trace/events/mmap.h b/include/trace/events/mmap.h > index 216de5f03621..f8d61485de16 100644 > --- a/include/trace/events/mmap.h > +++ b/include/trace/events/mmap.h > @@ -35,7 +35,7 @@ TRACE_EVENT(vm_unmapped_area, > __entry->align_offset = info->align_offset; > ), > > - TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx\n", > + TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx", > IS_ERR_VALUE(__entry->addr) ? 0 : __entry->addr, > IS_ERR_VALUE(__entry->addr) ? __entry->addr : 0, > __entry->total_vm, __entry->flags, __entry->length, > @@ -110,7 +110,7 @@ TRACE_EVENT(exit_mmap, > __entry->mt = &mm->mm_mt; > ), > > - TP_printk("mt_mod %p, DESTROY\n", > + TP_printk("mt_mod %p, DESTROY", > __entry->mt > ) > );