From: Steven Rostedt <rostedt@goodmis.org>
To: Minwoo Im <minwoo.im.dev@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
Masami Hiramatsu <mhiramat@kernel.org>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>
Subject: Re: [PATCH] mm: mmap: remove newline at the end of the trace
Date: Fri, 10 Mar 2023 18:25:42 -0500 [thread overview]
Message-ID: <20230310182542.695e9933@gandalf.local.home> (raw)
In-Reply-To: <ZAu6qDsNPmk82UjV@minwoo-desktop>
On Sat, 11 Mar 2023 08:18:00 +0900
Minwoo Im <minwoo.im.dev@gmail.com> wrote:
> We already have newline in TP_printk so remove the redundant newline
> character at the end of the mmap trace.
>
> <...>-345 [006] ..... 95.589290: exit_mmap: mt_mod ...
>
> <...>-345 [006] ..... 95.589413: vm_unmapped_area: addr=...
>
> <...>-345 [006] ..... 95.589571: vm_unmapped_area: addr=...
>
> <...>-345 [006] ..... 95.589606: vm_unmapped_area: addr=...
>
> to
>
> <...>-336 [006] ..... 44.762506: exit_mmap: mt_mod ...
> <...>-336 [006] ..... 44.762654: vm_unmapped_area: addr=...
> <...>-336 [006] ..... 44.762794: vm_unmapped_area: addr=...
> <...>-336 [006] ..... 44.762835: vm_unmapped_area: addr=...
>
> Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
This should go through the mm folks.
Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
> ---
> include/trace/events/mmap.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/trace/events/mmap.h b/include/trace/events/mmap.h
> index 216de5f03621..f8d61485de16 100644
> --- a/include/trace/events/mmap.h
> +++ b/include/trace/events/mmap.h
> @@ -35,7 +35,7 @@ TRACE_EVENT(vm_unmapped_area,
> __entry->align_offset = info->align_offset;
> ),
>
> - TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx\n",
> + TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx",
> IS_ERR_VALUE(__entry->addr) ? 0 : __entry->addr,
> IS_ERR_VALUE(__entry->addr) ? __entry->addr : 0,
> __entry->total_vm, __entry->flags, __entry->length,
> @@ -110,7 +110,7 @@ TRACE_EVENT(exit_mmap,
> __entry->mt = &mm->mm_mt;
> ),
>
> - TP_printk("mt_mod %p, DESTROY\n",
> + TP_printk("mt_mod %p, DESTROY",
> __entry->mt
> )
> );
next prev parent reply other threads:[~2023-03-10 23:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 23:18 Minwoo Im
2023-03-10 23:25 ` Steven Rostedt [this message]
2023-03-14 5:28 ` Mukesh Ojha
2023-03-20 11:45 ` Minwoo Im
2023-03-20 13:34 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230310182542.695e9933@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=minwoo.im.dev@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox