linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To: Peng Zhang <zhangpeng.00@bytedance.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	maple-tree@lists.infradead.org
Subject: Re: [PATCH 0/4] Some fixes and cleanup for maple tree.
Date: Fri, 10 Mar 2023 12:54:46 -0500	[thread overview]
Message-ID: <20230310175446.k536ck5rqwxtso62@revolver> (raw)
In-Reply-To: <20230310140848.94485-1-zhangpeng.00@bytedance.com>

* Peng Zhang <zhangpeng.00@bytedance.com> [230310 09:09]:
> Hi,
> There are some fixes for maple tree that may be needed.
> When reviewing the maple tree I thought some code was verbose so I did some
> cleanup and I double checked the boundaries so there should be no errors. Less
> code is easier to maintain, and you can ignore it if you don't like it.
> All patches passed the maple tree test program.

If you have a bug, please add a test case to the module if it is easy to
do so, otherwise please add a test case to the userspace portion (ie:
things that need rcu or threading, which is more difficult in the
kernel).

> 
> Thanks,
> Peng.
> 
> Peng Zhang (4):
>   maple_tree: Fix get wrong data_end in mtree_lookup_walk()
>   maple_tree: Simplify mas_wr_node_walk()
>   maple_tree: Fix a potential concurrency bug in RCU mode
>   maple_tree: Simplify the code of mas_mab_cp()
> 
>  lib/maple_tree.c | 76 ++++++++++--------------------------------------
>  1 file changed, 16 insertions(+), 60 deletions(-)
> 
> -- 
> 2.20.1
> 
> 


      parent reply	other threads:[~2023-03-10 17:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10 14:08 Peng Zhang
2023-03-10 14:08 ` [PATCH 1/4] maple_tree: Fix get wrong data_end in mtree_lookup_walk() Peng Zhang
2023-03-10 17:58   ` Liam R. Howlett
2023-03-10 18:53     ` Peng Zhang
2023-03-10 19:28       ` Liam R. Howlett
2023-03-10 14:08 ` [PATCH 2/4] maple_tree: Simplify mas_wr_node_walk() Peng Zhang
2023-03-10 19:20   ` Liam R. Howlett
2023-03-13 14:07     ` Peng Zhang
2023-03-10 14:08 ` [PATCH 3/4] maple_tree: Fix a potential concurrency bug in RCU mode Peng Zhang
2023-03-10 18:27   ` Liam R. Howlett
2023-03-10 19:03     ` Peng Zhang
2023-03-10 19:29       ` Liam R. Howlett
2023-03-10 14:08 ` [PATCH 4/4] maple_tree: Simplify the code of mas_mab_cp() Peng Zhang
2023-03-10 18:45   ` Liam R. Howlett
2023-03-10 17:54 ` Liam R. Howlett [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230310175446.k536ck5rqwxtso62@revolver \
    --to=liam.howlett@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maple-tree@lists.infradead.org \
    --cc=zhangpeng.00@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox