From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07868C61DA4 for ; Fri, 10 Mar 2023 02:38:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 891AB6B0074; Thu, 9 Mar 2023 21:38:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 818BC280001; Thu, 9 Mar 2023 21:38:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6934B6B0078; Thu, 9 Mar 2023 21:38:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5BCBF6B0074 for ; Thu, 9 Mar 2023 21:38:00 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 317AF81324 for ; Fri, 10 Mar 2023 02:38:00 +0000 (UTC) X-FDA: 80551428720.07.1A6C8EE Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf10.hostedemail.com (Postfix) with ESMTP id A2E8CC000D for ; Fri, 10 Mar 2023 02:37:57 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=WDYD84NK; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf10.hostedemail.com: domain of lkp@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678415878; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GrUG5rLzAPdYSWPgYEvhtK6donrZL7blAOcFgLQoh+s=; b=qE2qXp9kzKsRIoOplRVZokb4gUFFXYpKeuYOc3JsHzeOADvDUTP50niI9WOYAVIlpnFYaz HHJtxTSsJjG/O6pIw9UclRaxa6PRjfeioyPxF7GCCgD9WV7sbeOXXyeONoO6Yg7Ao0lHV0 As2aVykTbsbNH5mdjy5nOqB8yx81gi0= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=WDYD84NK; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf10.hostedemail.com: domain of lkp@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678415878; a=rsa-sha256; cv=none; b=BZmLCDuiIRWRB20kYILjtRBnoXpwJzF4Rf1PSM0bWDHSzAoBMm+NHJme95YLd2WVwM2W8t z/AJwZ3VHM7nI6pYSPdqIsDgd7Ho/qeJd2CYzcsgbGjNDNGLO1NabC6BLVf7BTOPDyAolq jOQ2mTd18u+bd93YKxh9SPkJV+ublj4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678415877; x=1709951877; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=a49MuUqY9uTekKka3fjSfGx7KEeZta0jUytQypcPsz4=; b=WDYD84NKvK+B+1R9dOlEmkOaZCcZH71oQcympBgb+iGP4RehS6tfyu5c 7EiHcD9y65jHw2UrErzgtycuz229fn6GsaxkoVuTWhgF6HGyb0Vyztoe9 h2T8TN12ru7fdgx7OHOURr2GHuZIkAbr99b+89e64HJ5JHpvlWx1rzMsh oON7kPITnji0L9vanmVfOUKTPidXc8MdbFkGCIADbfNS4ptE5herLmr+/ jpmCc+s7qnzsTqD5Tx4diuVF+rBQm7X0EcDmyKNoxsLH962WuMqfYeAcR EiKQ6Tk33IXsA7MYZ/ctWRxYqy1BAgUaoKVZiQsLQ6kceBaRyVhRwGfq2 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10644"; a="335325549" X-IronPort-AV: E=Sophos;i="5.98,248,1673942400"; d="scan'208";a="335325549" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2023 18:37:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10644"; a="801413998" X-IronPort-AV: E=Sophos;i="5.98,248,1673942400"; d="scan'208";a="801413998" Received: from lkp-server01.sh.intel.com (HELO b613635ddfff) ([10.239.97.150]) by orsmga004.jf.intel.com with ESMTP; 09 Mar 2023 18:37:50 -0800 Received: from kbuild by b613635ddfff with local (Exim 4.96) (envelope-from ) id 1paSdh-0003OJ-03; Fri, 10 Mar 2023 02:37:49 +0000 Date: Fri, 10 Mar 2023 10:37:25 +0800 From: kernel test robot To: Yosry Ahmed , Alexander Viro , "Darrick J. Wong" , Christoph Lameter , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Matthew Wilcox (Oracle)" , Miaohe Lin , David Hildenbrand , Johannes Weiner , Peter Xu , NeilBrown , Shakeel Butt , Michal Hocko , Yu Zhao Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, Yosry Ahmed Subject: Re: [PATCH v2 2/3] mm: vmscan: refactor updating reclaimed pages in reclaim_state Message-ID: <202303101037.13QFIjZH-lkp@intel.com> References: <20230309093109.3039327-3-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230309093109.3039327-3-yosryahmed@google.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A2E8CC000D X-Stat-Signature: q51tkm3h1oxj66k75xmro9myspg4ft3t X-HE-Tag: 1678415877-803154 X-HE-Meta: U2FsdGVkX19PWyJ7wZiSvF2INqlCM3CAqWTc+FhiQrUcAiIAxrPDVVdIWZvQoPvv6m/IPpvFEg6xmYNPXmhEobzYF1x6Jza7F7JXwVfdtOXk5e3iIIhNr0WD/Hry32Yr+oFHUy05CBMoxSe2YRv2JQOfyQsSesNtc6B13yMm/o7QDaAfitsmnHdKRszKn/01H818Rklx5COZxlm/YSoREhaVrDvAwfU1zWEdCRch4Ujr4hrGWnjdcBvybue9sIVKe4xvYlDQJnTdxwh4b9lehxVsIVg303RCg1zKepy+dkBx3zWU+ueTVZGRqvu/WbRVdHh6v7ktTDdmmGvGkEiVqycYybB2Ap2T7vNBlzAVpr17gNl06L+H4HsuntBmNYODakBjMmaozcw5wDg8uxQ45+O4oq/KsLR/ZuwDXF4O+HqC2Y7CID2zrgt1yc5kHMNDgLYCjrGJ208vl947zbvGR/C9r9bWJnWQ0/o5G9+RlhOrFwC5ySKsb22bmsgBLwkXIa8HVzs+gIrPoHNU9hoNcaL0i30eVNI17QfzFf8ZhOKHFl2QbHhexy+t3PAjkwdaxttqOR9rlnjH7KBXVlw6cZr2/jGoZMJFLGrbdwLCnDNurwNmE6i1UpV/NrJtvKWupsoYAgBHHaC/3GPfOn3C5cqNALzBR+/qqeab2JD8sjEK5oKMitgER0ln2dgzE4Uct1P+vj4zIwi4OZDba1F1htXiWcbT5F5aUMZRiQO66u58O1UZaBrtKUYrsmiby4EPE1cFnEoCYJvgZqvNPU3vQzElvyILwD9d4LHfAIbs7J9nzh5h9zkRDXuBJXIVJsjbTmupjMUttsjhq59n65fML4CaqN98Gb7JtTqieuBsrd1mWYMoISH53qlWzFnlaPRD6eBSpBPPdyh4Qgfehsbi1meLGlpyYnO3oN0zZXZjpK/j8L73Yvg457lRYxUocB91qra+QlqHEbbAIg6jMeq Rz2lhxFZ fEYehoajfId1ETKy8GXVKI6Yh7td9NhgNmmFzaNYkakVAnRcqR2xqT0zpsRfpuoxLPjrla/mPp6/+euYRP+DV8cIBw5k6cUGfvt3geI2ORIJPipWkazHAQv2avVXIkdBStHuorwRIfuKr8taKMcqHvumrSlD3CrT8iQ0e4P1mYxI85ZN/a2DrcpbP1x57QC94YX6FJI3IzqI54GGBfpQ80npXVztac+r3VzxT06zLKLefccTjnvFXzcX0hpWLpzvK0mdVQB0SRBrFUuEq/EVghKDmkMz2mHSNN3ni3vaCpT7rPa6VX/3BnnD3gaUBFY6TkSO4YDu64wUnYVuRB54j/v2p4bg10pcFwGALC0CPyK4TMWn0nuCTIVqiRGporg4o/5TwEnrOLFUuZimG0Jw6o8NpIZGsxU6IT91Uj8YyAv5/KCQQrBAUpju3lq8Qh96xdHutcxBSVeSa5QGtRMqFJ4TUAVvaPBk5RH0/YA+awNYjtTssHAf65n1Rx4mqeFWEU1+cV+zvvII8N9knMClnejwATc6t7+2L0Qu3q1WWR2rbpKnXP6L/IlKQkLmL5DwYyrQ3c8E6kL23eCQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Yosry, Thank you for the patch! Yet something to improve: [auto build test ERROR on xfs-linux/for-next] [also build test ERROR on linus/master v6.3-rc1 next-20230309] [cannot apply to akpm-mm/mm-everything vbabka-slab/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Yosry-Ahmed/mm-vmscan-move-set_task_reclaim_state-after-cgroup_reclaim/20230309-173354 base: https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git for-next patch link: https://lore.kernel.org/r/20230309093109.3039327-3-yosryahmed%40google.com patch subject: [PATCH v2 2/3] mm: vmscan: refactor updating reclaimed pages in reclaim_state config: powerpc-g5_defconfig (https://download.01.org/0day-ci/archive/20230310/202303101037.13QFIjZH-lkp@intel.com/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 67409911353323ca5edf2049ef0df54132fa1ca7) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install powerpc cross compiling tool for clang build # apt-get install binutils-powerpc-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/63df60b27250f3f7a2892f99f27258b60a6e8e13 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Yosry-Ahmed/mm-vmscan-move-set_task_reclaim_state-after-cgroup_reclaim/20230309-173354 git checkout 63df60b27250f3f7a2892f99f27258b60a6e8e13 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=powerpc olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash arch/powerpc/kernel/ drivers/net/usb/ fs/xfs/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202303101037.13QFIjZH-lkp@intel.com/ All errors (new ones prefixed by >>): >> fs/xfs/xfs_buf.c:289:2: error: call to undeclared function 'report_freed_pages'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] report_freed_pages(bp->b_page_count); ^ fs/xfs/xfs_buf.c:289:2: note: did you mean 'mempool_free_pages'? include/linux/mempool.h:102:6: note: 'mempool_free_pages' declared here void mempool_free_pages(void *element, void *pool_data); ^ 1 error generated. vim +/report_freed_pages +289 fs/xfs/xfs_buf.c 273 274 static void 275 xfs_buf_free_pages( 276 struct xfs_buf *bp) 277 { 278 uint i; 279 280 ASSERT(bp->b_flags & _XBF_PAGES); 281 282 if (xfs_buf_is_vmapped(bp)) 283 vm_unmap_ram(bp->b_addr, bp->b_page_count); 284 285 for (i = 0; i < bp->b_page_count; i++) { 286 if (bp->b_pages[i]) 287 __free_page(bp->b_pages[i]); 288 } > 289 report_freed_pages(bp->b_page_count); 290 291 if (bp->b_pages != bp->b_page_array) 292 kmem_free(bp->b_pages); 293 bp->b_pages = NULL; 294 bp->b_flags &= ~_XBF_PAGES; 295 } 296 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests