From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EC0CC74A44 for ; Fri, 10 Mar 2023 06:52:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4E666B0072; Fri, 10 Mar 2023 01:52:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CFE2D6B0074; Fri, 10 Mar 2023 01:52:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC5DC280001; Fri, 10 Mar 2023 01:52:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A9CC86B0072 for ; Fri, 10 Mar 2023 01:52:50 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3A0FEC0996 for ; Fri, 10 Mar 2023 06:52:50 +0000 (UTC) X-FDA: 80552070900.30.A36161F Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by imf28.hostedemail.com (Postfix) with ESMTP id 8186AC0009 for ; Fri, 10 Mar 2023 06:52:48 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=I57JSnLN; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk; spf=none (imf28.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678431168; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7qEqX21YRrsvSJ/y6xQPPg458jfKZDfNP3maNMRHlbE=; b=qr2615oOGbt8bRvP1LDtmFdXLr11RfewmZPu9edZAx2EUpbsj6crPUJtMlEUmcj1kKDNA/ CGY49f3rhl2c+jPM2ev2GQh0DG7LsB2ue+9DbnTpDJYcnlLO2kbRHdwvkSKki7kvqnBLh9 nk9AAdmogxm/Agb+duWXdouRk5dtVKA= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=I57JSnLN; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk; spf=none (imf28.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678431168; a=rsa-sha256; cv=none; b=pGwnZNvnXOJvATu9o3z5SjwYDUhxrleO+GIPHo7lOVMQVFI/hAO6lH/POHyO7t+FHRHVBM sWGZPhj/EU5NYXW1EYqCJhqXBu2sRJ0g0lKA3AC/kELJ6tf0aF7VDBN1MBRqPD8D7+cQEQ gmZ8+8SWTtxKQHtMqetppAiNtDkvM0E= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7qEqX21YRrsvSJ/y6xQPPg458jfKZDfNP3maNMRHlbE=; b=I57JSnLN/KuTBHkJec9Ueg23yO WAuEjYh4TxVA/K+1XP40YCn8q1pC9rah1z/C5JRl760MBSQ18t1rwiNtXtOfbkTFUh67Ff/TFuBbc /NjFtEP/8cAAacdHIxs2xqLC0/SKHBDPMsQhhdQf6PluDJlNqCNQrUnUCENhCLFgKgSIXgn8m+Jje hCY2o+SPIIq8bKhUjqA+aIhN2gCj77LAVZTv9wjofmBQ4hG4FJp1CVi6xMZADp1B26bzZtiltycOd gqoT/aiNmcqLg0X30jmk17GqkAGIkWuEOiWSJ5S0ZodWyOIxRq1IrDyKZ89EQ0UujH6sqc7MKuCBf JY9DvpUA==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1paWcF-00FEGC-2u; Fri, 10 Mar 2023 06:52:35 +0000 Date: Fri, 10 Mar 2023 06:52:35 +0000 From: Al Viro To: Christoph Hellwig Cc: Andrew Morton , Mark Fasheh , Joel Becker , Joseph Qi , Evgeniy Dushistov , "Matthew Wilcox (Oracle)" , ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/3] ufs: don't flush page immediately for DIRSYNC directories Message-ID: <20230310065235.GR3390869@ZenIV> References: <20230307143125.27778-1-hch@lst.de> <20230307143125.27778-2-hch@lst.de> <20230310035353.GM3390869@ZenIV> <20230310063756.GA13484@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230310063756.GA13484@lst.de> X-Rspamd-Queue-Id: 8186AC0009 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: fgfdebc9cr6basc6yxmiahynr84476wj X-HE-Tag: 1678431168-414205 X-HE-Meta: U2FsdGVkX18wlA3gJX9mSyqwLdarH+gk+N5aC4b+LQZBegTr2GAnkrdBenabPg+oK56el/Zhs592dIi5WxSOpWki+DUuOjdmojAAYUcD0Ro7OFqp89LcWpnsoFAd917KjzfMfotC7gTIZOQohlXw6jlDVOwO8SdUFffwth2m0dQ23ykTXH6A9lWhy6b8PtC1byQtZIlFQkHz84H9Ibc4fhARy/tpCN5AaH4PrmRuTkjZxwI+1+8GA+cnmbcIacALgpxw9mlelaxsVQHeDNtHW5urVRk2gBvXNe7Hm3CQcpP6zajxS2FgyOSKKHYpbrE6mcI5W88/8JtUkQ2yW8ctKwWjwR4xZCCtO0Iq8QQPE2EEtjA13yQjd19uCdosbxQEcWVin5IjN3pbzXjkmV8FO5opxP1jXe/4OhtFGtDoaEjkMynYRvRdirzxKJkc2S+PCXqZz2r4hEHd75IWmvA4/4bsUVdSzgQjlat13CyNzNhCFF9XGs+fg2MBQpU2wQEdWeFMpsJJsHbx3aWt10LBvnSJpKnpwgbW51NcyT/cd5iR/ZEu0aUtoVU5Yatc99VpC625OG5ciN2UoBx8ZbhTfPb/W/OuM/Ve0S/DeX4mhszIJ2HyJm3C6psSJNWq4MtQR8o8JA741ABbigzz++1OOWjROGBSCXgB5zDvwNWCERHthGQMDXFnZBur09ccNYoO1tJO6/8VHONgYp1Ww96YLPIM5JQtL12HD7golghRbv8XxDuG0Q2NWVOOpqo6Cv9VxqCuYGjGyIpYjOUvRxA111ySH9iOZ+GWc9LrtEuMNjPjiXBsRMgG7mDY0trpR1NqKke8RXfFuxxYq7RfYJabh2Rrf6Cb6qvmi+NyDBkSiKXwty7/PG4n0i2WOoj85gtHOtUjDINNgdCieYTm2SQFGLCHZMfU7sSNfdFdufD4a8+1EiRzBwTDrzi953Hn1Ajao7V+N9jSNGefuoZ9Dsq H0EIDaNy dNkurkYvssMui3dS5eyPtCy9IdAQ4R+7b4t8jgHuRRkw6Cd/JRjksWpouzKJU6Kwh5GX/yCdG69doSWYVqzOGQC4nv2y/ZGwbMRugTxcBOyAuThhPF8a4oZgUF8k0FXjp3iOo4yl6xK6FetWJNp+k72aMW0LJ/AhyWSQcj2mua/Wisy4bWlxmckC3hq8GaUj/uqiVYO+jyuZf1CkDlR091gkuSrb4TVXPbFjdauP6KoSXEAtMWjw8NxPcLnbdk9Q33DEkzx6G3+5MbIzvlfgQhX1/R5RCgW/EdO4KApURbUCklAqtpTin4lbpdFKRqwHH6U7IKaZ+xEQjCdufpQCABmYUmW6tqIzbScw88Ws6knqj5dcqAJ4Swvs7Rw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 10, 2023 at 07:37:56AM +0100, Christoph Hellwig wrote: > On Fri, Mar 10, 2023 at 03:53:53AM +0000, Al Viro wrote: > > On Tue, Mar 07, 2023 at 03:31:23PM +0100, Christoph Hellwig wrote: > > > We do not need to writeout modified directory blocks immediately when > > > modifying them while the page is locked. It is enough to do the flush > > > somewhat later which has the added benefit that inode times can be > > > flushed as well. It also allows us to stop depending on > > > write_one_page() function. > > > > > > Ported from an ext2 patch by Jan Kara. > > > > Umm... I'll throw it in ufs pile, I guess (tomorrow - I'll need to > > sort out Fabio's patches in the area as well; IIRC, the latest > > had been in late December). > > Well, the three patches really should go together, otherwise we miss > yet another merge window. Umm... Do you need them in the same (never-rebased?) branch, or would it suffice to have all of them reach mainline by 6.4-rc1?