From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4AB7C61DA4 for ; Fri, 10 Mar 2023 01:54:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 111B06B0072; Thu, 9 Mar 2023 20:54:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C2246B0074; Thu, 9 Mar 2023 20:54:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECBD8280001; Thu, 9 Mar 2023 20:54:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DA8CF6B0072 for ; Thu, 9 Mar 2023 20:54:50 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AEA65412E6 for ; Fri, 10 Mar 2023 01:54:50 +0000 (UTC) X-FDA: 80551319940.22.9DFDCC3 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf03.hostedemail.com (Postfix) with ESMTP id CE12B2000E for ; Fri, 10 Mar 2023 01:54:48 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=KfJmw3IG; spf=pass (imf03.hostedemail.com: domain of yexingchen116@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=yexingchen116@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678413288; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AbKrJaTuxGBwz2l1L0VhQTMXMffewmYTsSHazCC963M=; b=EhdRIZlk9W2qb2/xenv/wcv/Mm9Ky4KWD0GDc2uDtnW8hl7JsFQdGAGvQEuuC6lWTYYLFr +QohV6ieX/xUrM3Vu0F1w2+8Qhjvmz8z5wQO78+y9t8yEkFHmmcHW49qkX6Knlb2ju3ta9 lF7hMy43qQasmKqC+uhjr0CUA1SjPYI= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=KfJmw3IG; spf=pass (imf03.hostedemail.com: domain of yexingchen116@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=yexingchen116@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678413288; a=rsa-sha256; cv=none; b=mtCl/QTuFiI6E4oKgik32XCsAA4XEU3ZpDUaWISA9RrjpRKIBa/cXCfvkCV5v1QNeCCBQn VC5lTUrt735aJpxaqXp0uchIq5KAqpapDVzCUUSRKk45FDc5sbpoXeidFiL9V30VQERkWw Y7elpQksNvSptLfYrpW1uUs75rmO2Hg= Received: by mail-pl1-f173.google.com with SMTP id ky4so4093970plb.3 for ; Thu, 09 Mar 2023 17:54:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678413287; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AbKrJaTuxGBwz2l1L0VhQTMXMffewmYTsSHazCC963M=; b=KfJmw3IGnKc36gNO0L0t7LoWhi1ocXye0xOF70I7kJd6nCwQxyDZDi5EVM0LnW5c29 2vaRSR8G0dEqtxUQ5KvtALY/uC4dp8uX0wmfNzp+g6CgxDbRkl9r0qeVa3gL92tY4Fqp f+6BO04ewEGSPs6xtn1de3+D+tsLVI17kuUAmWNAzD53cGHEpsxAMqHmk6ui35KZBYlp cLHpPbloEtl0eIVpjfK4rh9mZmj7EhzNGvL3Ld0mbiRkl86aXsmv0itN4QdcDUDkijN/ 2un6XQ06P5MAWkkVQOrp3wvAvE2XB7LXtYoDNcSxI/187J00Fq5+xI3rot9vl6is0iAw AIlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678413287; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AbKrJaTuxGBwz2l1L0VhQTMXMffewmYTsSHazCC963M=; b=7HNq2ten8Pw/yxr6wnA9Dydik7A6KjJRYdLT0d4F4NSEDElPvdzTvPiWNx3ij3BLUk 31GiZXJIRbaGjH3Bhe8TgD85mnpXlzoQRpg/2T9Ktsk4moBoPl8g2Mvhdo0ZZu4IZtT5 JnsWT0nplW5QJxpNBWMvVclS8/vm1aIVVLzHShkyFYgB0vLs3ZGrFcIvgprxVCyMV5P8 BnKFCuWkZUVJ7OBIwIAXC8tXhwb5ffeKHY2AFnAPk9445XlIrh444dugrST3tug3UUcL +YLPcnTJLJ6lMVZhIQQwf1jlgmmzXWFjQ3VjHni1Okb7PDfR494IKvkstKxK4HkwV/2K JjkA== X-Gm-Message-State: AO0yUKUW8R1rxiM1oIdZXluOiAtXe8fMX/jIyc3otgsSuy6NMhzvd+58 i+4b6TPkYgGAq9E9fomErnE= X-Google-Smtp-Source: AK7set/EmfQT1M2FmsnIPc47RkYaUhRCbk42tHMoBZu0kIqfZDcoA5djaR/klcAuCJpwYJqkjWSmEA== X-Received: by 2002:a17:902:dac8:b0:19a:a650:ac55 with SMTP id q8-20020a170902dac800b0019aa650ac55mr232742plx.23.1678413287523; Thu, 09 Mar 2023 17:54:47 -0800 (PST) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id ju14-20020a17090b20ce00b002371e2ac56csm221566pjb.32.2023.03.09.17.54.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Mar 2023 17:54:47 -0800 (PST) From: ye xingchen X-Google-Original-From: ye xingchen To: mcgrof@kernel.org Cc: akpm@linux-foundation.org, keescook@chromium.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ye.xingchen@zte.com.cn, yzaikin@google.com, chi.minghao@zte.com.cn Subject: Re: [PATCH V3 2/2] mm: compaction: limit illegal input parameters of compact_memory interface Date: Fri, 10 Mar 2023 01:54:43 +0000 Message-Id: <20230310015443.175552-1-ye.xingchen@zte.com.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: t1hpi9s9z75fm4uhxdugddc9e58d64gu X-Rspam-User: X-Rspamd-Queue-Id: CE12B2000E X-Rspamd-Server: rspam06 X-HE-Tag: 1678413288-371574 X-HE-Meta: U2FsdGVkX19K0HCt47ARmiGjK1cwrS4QHIWd+w8pJ8s0G29QUQUyrYmavIwDuegIf5LTYWQyl4kRIHUQ1nQiG4XuR03GWegNMNr2tlomwr+ZSSODds8FawDXZjEYZHNEUnhS+eJlEWXYEwQz4XKaJNKjcKYlHUOgTTWetXuGhN2z2JeH08hChDoldkZeQyyG+8ss68g9HLeNvlDN5om4N41XSvGEzt5LM10PPBGQ1nlyTCsH9UfxKVo3AlLRXIb5VUaw4DGT8F2QD+y2NWRKKmvQegk5VxOkWB5N2bM+UhOStHFschjxbzXw1AQhZT24pGciDpNoV3K+AWYzi3R5Duh5/x4dr+CBv2KGDLWAWUh1l7XhhLjMla4wxVKcTCpoyyzNPLl+IG9zmQUdcMEzIePlEQ2Ktykry3t9BEtI8qz5T7gh8Ctaw9fEkqDzBRsBm5Bgl2Wu9tOVAztTk35GXsjUwmOCcDwEP+D7THQ4To0KfZHdZ3lvMOJ9A10jO0NRGwIM5IgRpVrgP86gbxhzIRPnIUhzccZkP0I+hjrMFKhuw6Ka6bCcCkI2sZB2Gur1AcPZeuDJ3sxZYcA6vz3yTZexb61SFtNzRoE5kMHn1u5ddwkwCVtykVk+mqpBWAD5r6BPwjxFHhQ7YrNY2UARVnDCsHSa0B1zsxc9bopKPpkV2sn7uw6waQ8cb/xbw2UtJd5qFBduPgHQJQZkz2IWwdFruu64VPYVm3Lh6bUUZW++y0GOYdUXeO2C3Xw37l3sxBJHiCOWuENs7Q4OYU8g71+UR34f0ZbfCOw+jJV+zQ7lb1JK75yohHLa9lWoTVVQVth2ybfgFHhzRXDO2OaUbC7bqP7bQ/UbOwBt37U6GwWXcC99fBiL0jJyToKw6seX3/MZP7dOlJXVdE3Qx0v/sHAnZ8SZAR9EDOOOXOC6F9XTy+GB7aSCTkxC2yeOvBIJbPiP2JBie8ha7VpAH7c 55T5IFX6 7MFFBLvCR9Cgs3RL/EbB/1mTrXcUu8urm//vXXqxpKl227z8riER9SD2jOx79XNz4MnqAcTv+2w/7gAQb2UzcInyi5XM1rfkxfflM9WLTP2k4SyrseeBJKdeKLlq0ZadppFZqoP/RTFTdshCv6oFA48s9+OiDcDkCoylnIHJ/AY0ai8xL9uHVfgWJQiRmHLZGreOeAn3XbqYYec7RRu95HC5igY7hBA8luKBIbMEYgMNFYDFTrScTnKCpBB/97d/I9AepxVLsjf2+DbAkXeLO/wjzj08sfq0plgny4YO9X/kw4I3MZIMyww6YKMgANOXqZzvQvsiX6FC/LsEQXykXuNAQ8fW5wHEuoMBbMTOX6GFbOnx8cvIDo/maKIOCIqFPfGA7NMSc4M+SnM48+hEW6G8IyOQ0lI/5NbQoRszDYwNlM+jdn3gijdXZZxMmd66wh5mxNHd5/UBP6+pnh6aCbFToT2IrklALW9HZrP9t1fLHVeXnuyvbXqVfZ9BLB1vpjlAT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >> From: Minghao Chi >> >> Available only when CONFIG_COMPACTION is set. When 1 is written to >> the file, all zones are compacted such that free memory is available >> in contiguous blocks where possible. >> But echo others-parameter > compact_memory, this function will be >> triggered by writing parameters to the interface. >> >> Applied this patch, >> sh/$ echo 1.1 > /proc/sys/vm/compact_memory >> sh/$ sh: write error: Invalid argument > >Didn't echo 2 > /proc/sys/vm/compact_memory used to work too? yes > >Why kill that? Did the docs say only 1 was possible? If not >perhaps the docs need to be updated? In Documentation/admin-guide/sysctl/vm.rst:109 say: when 1 is written to the file, all zones are compacted such that free memory is available in contiguous blocks where possible. So limit the value of interface compact_memory to 1. Chi, and Ye