From: ye xingchen <yexingchen116@gmail.com>
To: mcgrof@kernel.org
Cc: akpm@linux-foundation.org, keescook@chromium.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, ye.xingchen@zte.com.cn, yzaikin@google.com,
chi.minghao@zte.com.cn
Subject: Re: [PATCH V3 2/2] mm: compaction: limit illegal input parameters of compact_memory interface
Date: Fri, 10 Mar 2023 01:54:43 +0000 [thread overview]
Message-ID: <20230310015443.175552-1-ye.xingchen@zte.com.cn> (raw)
In-Reply-To: <ZAlY7jsj4daalgcY@bombadil.infradead.org>
>> From: Minghao Chi <chi.minghao@zte.com.cn>
>>
>> Available only when CONFIG_COMPACTION is set. When 1 is written to
>> the file, all zones are compacted such that free memory is available
>> in contiguous blocks where possible.
>> But echo others-parameter > compact_memory, this function will be
>> triggered by writing parameters to the interface.
>>
>> Applied this patch,
>> sh/$ echo 1.1 > /proc/sys/vm/compact_memory
>> sh/$ sh: write error: Invalid argument
>
>Didn't echo 2 > /proc/sys/vm/compact_memory used to work too?
yes
>
>Why kill that? Did the docs say only 1 was possible? If not
>perhaps the docs need to be updated?
In Documentation/admin-guide/sysctl/vm.rst:109 say: when 1 is written
to the file, all zones are compacted such that free memory is available
in contiguous blocks where possible.
So limit the value of interface compact_memory to 1.
Chi, and Ye
prev parent reply other threads:[~2023-03-10 1:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 3:42 ye.xingchen
2023-03-09 3:56 ` Luis Chamberlain
2023-03-09 6:58 ` Luis Chamberlain
2023-03-10 1:54 ` ye xingchen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230310015443.175552-1-ye.xingchen@zte.com.cn \
--to=yexingchen116@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chi.minghao@zte.com.cn \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=ye.xingchen@zte.com.cn \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox