From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94BD8C64EC4 for ; Thu, 9 Mar 2023 14:36:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDF946B0071; Thu, 9 Mar 2023 09:36:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D8F4B6B0072; Thu, 9 Mar 2023 09:36:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5715280001; Thu, 9 Mar 2023 09:36:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B32D76B0071 for ; Thu, 9 Mar 2023 09:36:48 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 86B24C07B8 for ; Thu, 9 Mar 2023 14:36:48 +0000 (UTC) X-FDA: 80549611296.02.B03039A Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by imf14.hostedemail.com (Postfix) with ESMTP id 1E71D100016 for ; Thu, 9 Mar 2023 14:36:44 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of tsbogend@alpha.franken.de designates 193.175.24.41 as permitted sender) smtp.mailfrom=tsbogend@alpha.franken.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678372606; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2Xkv6vtxJy2nOExp5TNgPH0x1EBNPxJ9ldhId1y8sxY=; b=6SsCjNiiA6Lqs3GvH1X2Pn4clAKS2vRB+BBsEHMMNiJr2U+KY9KihnH73kMeROoHq8pJd+ A1ebrn8ldmBOQ++2LYD+3WaS4TqIbZtcbRU/rPZZ9cxzZsIRE7PY/4vkoel0vWYGr+5oEA J3nvu+fBGjOoAyBZr6qnle9H1u3N2YA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of tsbogend@alpha.franken.de designates 193.175.24.41 as permitted sender) smtp.mailfrom=tsbogend@alpha.franken.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678372606; a=rsa-sha256; cv=none; b=UQC84MzsyQb6sGk/RwYeSVRCipQQikiwPUftizKftkxpRBx6ii/C7gq54z7+7/MaBOo8Gb MUygBz1VE6O2IahOflXjTVmuA0tRvlRStRYbXKM9LlEnN4bqu5/2X4UEol3wT5uNRrLYkN zZG1zQszLbVO3YQbssC+4VAa22lHl54= Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1paHNg-000885-00; Thu, 09 Mar 2023 15:36:32 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 6CA12C123A; Thu, 9 Mar 2023 15:36:21 +0100 (CET) Date: Thu, 9 Mar 2023 15:36:21 +0100 From: Thomas Bogendoerfer To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, mpe@ellerman.id.au, geert@linux-m68k.org, mcgrof@kernel.org, hch@infradead.org, linux-alpha@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v4 3/4] arch/*/io.h: remove ioremap_uc in some architectures Message-ID: <20230309143621.GA12350@alpha.franken.de> References: <20230308130710.368085-1-bhe@redhat.com> <20230308130710.368085-4-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230308130710.368085-4-bhe@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 1E71D100016 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: ihmxbagksdxnnt54w5y6u5bcp4mfutzw X-HE-Tag: 1678372604-43056 X-HE-Meta: U2FsdGVkX18pvr+/TAzXCsq47efyAV661+I88Bk66a1kl1WiMGPTt6TVv/xTlbtgN/3Z0ToJmjM0Ps+PtyemUkeYYIGtpQ8PTC2vzUALdSR+ngx10YBckWPvYDLJYHjblETyzsNj2+OgezCGPyMrZcJCat+SbPW03qP8/g3E8W5I84VFN2Y/yiF6wlYADlKP1K7j5DMhlSSuCrdWQGv5m0h46vOaEDOMhiURJVUrof9hQwTX9t8qk5hBgKcuRbx6NxBuvbSS+IBuh+o8bh+6Vu7M3a93mlSJPK5YbtFIaY0pQdxlO0zuPH0FxB9fzdRvg1kqLQYns8zAem9pbEYLsm9cFhUGsRNKZH+klEdYBYM3ZiGYgJjy2n+LNF9J61unLNviM/WhdsEhuJKeH3qHG7gx1+KtSnnNyC5JcA1P1aTZIJgVzpXH9xkHpez49aSeOxsFj2nLoNVyCzYGQbArJnseHClmADk4CPgkkurpyCggzMUnz780fFMDwIc2MWxxyd/8K8xEt5/FcrZOtQpIO2gw9I4A7yEU/aTueHqAgINIhxyjsxEnJmLfviR3Q00XVc6lriQk2tXfnbtL1xmRHcEs4Z15JxmQzFveTdE1byrJZufR54DCB/eMd1q7gzhJtMRQ4DGeOShTMsyZghpW2sRtMCIF7SdmGUOhWA71OUmKYXivci2CapJQ44IKhQF43e7vmsSYmER0tUZLQV5EsyJXu1MLU3NVKkFc2rKvFolrGvtds6KbtIevI4pIf9fe9Lzo9syJdJYBXDUwG2aOhkMoJl8unlLLCjbW+QVZ6VcQc3CFT94iySptBCnTjvJj/nvYEOWnZh5Ik7XdF6Wu83pvnSMkzNjvC9oXtOMjHJ05jIyWsHfYVMj/YJXzzvD2V2Wl91pzLKNO6P/X7FKs1a6iH+eCzPUfw93z89Sp9dUVMAgrdLQTEq1p0VR6GVnQhNhV0/QT4B+pRauEA3q MgQIYDCD /ZdCFcbQaZStybvsyDa2haO2F6uBHSoZqF+tf7LBvCA1StVbvtM2Bx/VgNRBLNU6xiA5KfWOEiWyp0dYQ7H+NAjjyORBUsaoEpQ7x0OD/D/0dwAahCgjhiLC4bPjNEN4ST4gdrqKt9k1epRAL8K2AaivMaaqNXcKc5BeDCE/pJtbedOR+Ni1hyJ3BRrCth/LRk5DUZvPD4b8PQ9uBpARoMQEWBRgnUu8nGMrmZjw7OiKFLj1mQTh4mumcaUGPhUSOGV7Jns1LEWmUk/bHOFqUDrVEFnOUbrspJs1SZJ/W9TgQimY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 08, 2023 at 09:07:09PM +0800, Baoquan He wrote: > ioremap_uc() is only meaningful on old x86-32 systems with the PAT > extension, and on ia64 with its slightly unconventional ioremap() > behavior. So remove the ioremap_uc() definition in architecutures > other than x86 and ia64. These architectures all have asm-generic/io.h > included and will have the default ioremap_uc() definition which > returns NULL. > > This changes the existing behaviour, while no need to worry about > any breakage because in the only callsite of ioremap_uc(), code > has been adjusted to eliminate the impact. Please see > atyfb_setup_generic() of drivers/video/fbdev/aty/atyfb_base.c. > > If any new invocation of ioremap_uc() need be added, please consider > using ioremap() intead or adding a ARCH specific version if necessary. > > Acked-by: Geert Uytterhoeven > Signed-off-by: Baoquan He > Cc: linux-alpha@vger.kernel.org > Cc: linux-hexagon@vger.kernel.org > Cc: linux-m68k@lists.linux-m68k.org > Cc: linux-mips@vger.kernel.org > Cc: linux-parisc@vger.kernel.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-sh@vger.kernel.org > Cc: sparclinux@vger.kernel.org > --- > Documentation/driver-api/device-io.rst | 9 +++++---- > arch/alpha/include/asm/io.h | 1 - > arch/hexagon/include/asm/io.h | 3 --- > arch/m68k/include/asm/kmap.h | 1 - > arch/mips/include/asm/io.h | 1 - > arch/parisc/include/asm/io.h | 2 -- > arch/powerpc/include/asm/io.h | 1 - > arch/sh/include/asm/io.h | 2 -- > arch/sparc/include/asm/io_64.h | 1 - > 9 files changed, 5 insertions(+), 16 deletions(-) this doesn't apply to v6.3-rc1... what tree is this based on ? Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]