From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C665BC61DA4 for ; Thu, 9 Mar 2023 04:08:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 444C26B007B; Wed, 8 Mar 2023 23:08:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F531280002; Wed, 8 Mar 2023 23:08:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BC99280001; Wed, 8 Mar 2023 23:08:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 19AC36B007B for ; Wed, 8 Mar 2023 23:08:25 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DD50C1A05CC for ; Thu, 9 Mar 2023 04:08:24 +0000 (UTC) X-FDA: 80548027728.06.DE7BB78 Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) by imf10.hostedemail.com (Postfix) with ESMTP id 9E4C4C0019 for ; Thu, 9 Mar 2023 04:08:22 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=QR3kDqRb; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf10.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.53 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678334902; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KOqFTH5u/fVVsKVxp4qKRwo0vsAjcMeltzSVwR+wC7w=; b=DeacLF+WyOKJELsWWwNuoS0LmI8P9zoU7cpfNnp33O5iQDGlk6HRxMsANBaeGpy4oDmc4L 0zowbAgxEZVAYkJ8T1r6Wg2ZXp76TmY469Zfhofw3EEou2xIyhp7R7bZW5PIH2bboZEXl6 gN2qsNqc7QRuAtr1hwNH/Ua7S4EVFVs= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=QR3kDqRb; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf10.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.53 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678334902; a=rsa-sha256; cv=none; b=Dz0h5KWoupoYHPB+mP3JJXfle3R7AhgOyPK7RzNrS9vW9OIYCLB99xZoogaOAxVrAbTf9J znTta7g9WBkEghXawYzlpvsFATLhZNcksemWPnS2fSMjR44xBZWNO0GAXlHYK9FeZNwQba 08shs+cpVPiyLmcoeoAcLNYuWNz8G5Y= Received: by mail-qv1-f53.google.com with SMTP id ev13so638902qvb.10 for ; Wed, 08 Mar 2023 20:08:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; t=1678334901; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KOqFTH5u/fVVsKVxp4qKRwo0vsAjcMeltzSVwR+wC7w=; b=QR3kDqRboFFNYKkzTvJrai95dT3dZTs9cGDwwec8U7dvf/bHtU8JEPYSUNwNi/A46B gBI203InsTfsnZw9Bv6K1Tq2dpzCPmP9irezZNzKvopRnWuhHByck3EjMdnV8UYvu0MF pkOF6VyERI42m0XRvCUT7r3ELRx0whQS1NVs41INaHDKAHjqKKYfZ+5LCMR0HTol4O4c 5ZhWDegnCqEQx6vHB0EVkpKmVt+qAJQ3GFLh1WwsqiXGzwYR7AR9t1UhDO9N9doLFdtd OCVBDqZ45fI2Bac3OyAY6RRjSMFpgAXGdNxKPvkbVt02jFWGaIMcLg4vJO1MbhB/sBZt Qliw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678334901; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KOqFTH5u/fVVsKVxp4qKRwo0vsAjcMeltzSVwR+wC7w=; b=P1kCFHxMKf2EYMW+TYLgLvWPguytDgC7xpVlzSdeCQHpQzuV8WsS+qsUG9Xa5KslaJ 8tFTgWpJloQY6GIwsBIkuyJdKG8SifZYqzMkWkvbuB/FLsnN2RvRZFh6wL94ElIF9as1 6phVoUt0MsxFZeDASiQW8aqoHGZSKMmcQjao4c8bhWeMqXH1SP/LQd49wGZMQ/wd27yt O7g8wUYgF2+65ybp3DJJFTdT6R1PkhRMxvqoI8Xd9NmXlD6gPw1LpU8S3wmldUEBoLGN Ixu/awdzuo17uvu5felgy2vyNeKUZxkpT+8l3ztSsj6ZJmtRhBQ1FgwpVUIDDGUL/93a 4wLg== X-Gm-Message-State: AO0yUKUM0uhOXxlDw1CM+EyqOZuk5/w1tJMcC1BoSQ1GAD/ahRmpm467 VF1u7M/OMSNiVmlwUfm/z4mXUQ== X-Google-Smtp-Source: AK7set+r5PhASkThXPj+BSSKPFPWT2nq8eT+XeY2DnDOIzh5J3uIhZ9LayYCBBwqIwSzebzHBCuiOg== X-Received: by 2002:a05:6214:518f:b0:56e:aa11:da91 with SMTP id kl15-20020a056214518f00b0056eaa11da91mr2203393qvb.14.1678334901632; Wed, 08 Mar 2023 20:08:21 -0800 (PST) Received: from localhost ([2620:10d:c091:400::5:d32c]) by smtp.gmail.com with ESMTPSA id r8-20020ae9d608000000b006f9f3c0c63csm12698858qkk.32.2023.03.08.20.08.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 20:08:21 -0800 (PST) Date: Wed, 8 Mar 2023 23:08:20 -0500 From: Johannes Weiner To: Dave Chinner Cc: Yosry Ahmed , Alexander Viro , "Darrick J. Wong" , Christoph Lameter , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Matthew Wilcox (Oracle)" , Miaohe Lin , David Hildenbrand , Peter Xu , NeilBrown , Shakeel Butt , Michal Hocko , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v1 0/2] Ignore non-LRU-based reclaim in memcg reclaim Message-ID: <20230309040820.GC476158@cmpxchg.org> References: <20230228085002.2592473-1-yosryahmed@google.com> <20230308160056.GA414058@cmpxchg.org> <20230308201629.GB476158@cmpxchg.org> <20230308212529.GL360264@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230308212529.GL360264@dread.disaster.area> X-Rspamd-Queue-Id: 9E4C4C0019 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: eyfpsb1fzmjp7g6cifhj5as4e5guo5ep X-HE-Tag: 1678334902-197180 X-HE-Meta: U2FsdGVkX1+AJQc420YJxk86T8CHX81gDTjfPpjzlloEx5Z3QlYKvaSReiHpOeWn+pjgVGlcX8OjYo6IUq/9+DLr2aLficg604F8nr1oa43U38B6QjZBQ5U1RmLRssP8ts5PxNmSRc2EcSkivYXyodoSRv3g19lQv8oDNWHsUBlsrUucYiksqXfWgW3nIWiicifwF3Y9tc+AIippxEiHtqboshSHUuK7JWM9EoX9xCnNuF9xgKLkhdV7CrDghuN8c3FkfWeWoZHUzeWwQF11i6EW6WhIO7tYHKc+R/+ft3B04t8mGrHo5usr6gGAQcxgcc9jVPVRqSusn0wtYHDl99XSRb9EzCBczIAXYiLV/OvXBKUKt7qzRaDomjmN4SGhnoiPSM0XC0wYMydpcjg7Dr154nSziWFJsmPUcRuvjhmw71EjvfiSp4Q1trionjEovNTdm43V7wWp9bjMzT13/1pG65aZB9bgryPr4Y59D1S5FbtIOlH/Ol49I2jM4Ra8RoTbKOMUKl+Mxm/GsCJx0g+Pi4Kcn5M6JSm2OLLRRf41SNdZ+UVpatMxVBSeK1q/Yj/J7ahHY0QeKS3K9/C0VXUX4OLQkTqGku9182wi271yhfCJl8OLiBR59gQ5ZY86MM/cxuBuTpNz1VxO4rV3II8abNns2FBBeLopjlxNKWycm6LHIg8FtLe1GfolbamhG5q2rOGEPPs7l2KWaz/uUFjgXExdVYBZ5uq9PCLrUKj2xbwPj3ZhHKtywkydj1rbBTf3478GcYlXCgbtBhWLy+RWSBTlcjp1jzF+usXcsYdtPefrq83w2PRw+leKsTNPkGmrtwNERZpQHfni78gqYI22ABc8kTT1+q0GIbH9M/pgyEwWd5Okei2QQ35n7z9bD17m8qLZwS8tWDdkoVLbK3WR1ysviYBZsv08QN4g4RN/P9078ylTlatC46PFUPim29Umy5+wfL5zf2iMxxg awgTLQ1x VuJKFj+ZOzxos64cihcDvGl5k3NOiRc0mS0gFQVCpZDRR2ve8Td1kYTXMDHlXladv2IwJyTdKglzSg7nxjh7UbRKt50/19+MXdmxR6mGwGMWzmcztwpx/yqilCFZugiSJDkAFqmHShWHxtbdMMwXBnv+iNB7GebkSB3RAIf6NbLREvb155pSHAfXsKR+wlrq9vuBehZUWJl47CX2Z1ZeRy7NNzd/xyyGJfuubWOYmKnYCZhnImDxXPQ0hmbZpRJUH/ohxsdGbrxSR4/Ff6e4ugGa/Y6kXT4+CbjyZqaB9K4+2l8eW30IIfbvhPxRBUonzkbKSjMnqQPMxLC3brHRh584Pm80xA+cCJ/uEzbTBLDH2+PCLDRTH46anehAgKLK/47oYTys1qwYhW5ag+B3jZjNlICWE3ZMpwMvnR4A+/qyrXGyxIMyNUKGbKTf7h8Bl7GNP4ngiC7HreOX4x63b0XsjXUAq/qg+MlaCsCg6DsyyOm4p3yYBfW8f8qz5vaRD5gZSscRJZAFrwoX039U63u9cAA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 09, 2023 at 08:25:29AM +1100, Dave Chinner wrote: > On Wed, Mar 08, 2023 at 12:24:08PM -0800, Yosry Ahmed wrote: > > > I tried to come up with something better, but wasn't happy with any of > > > the options, either. So I defaulted to just leaving it alone :-) > > > > > > It's part of the shrinker API and the name hasn't changed since the > > > initial git import of the kernel tree. It should be fine, churn-wise. > > > > Last attempt, just update_reclaim_state() (corresponding to > > flush_reclaim_state() below). It doesn't tell a story, but neither > > does incrementing a counter in current->reclaim_state. If that doesn't > > make you happy I'll give up now and leave it as-is :) > > This is used in different subsystem shrinkers outside mm/, so the > name needs to be correctly namespaced. Please prefix it with the > subsystem the function belongs to, at minimum. > > mm_account_reclaimed_pages() is what is actually being done here. > It is self describing and leaves behind no ambiguity as to what is > being accounted and why, nor which subsystem the accounting belongs > to. > > It doesn't matter what the internal mm/vmscan structures are called, > all we care about is telling the mm infrastructure how many extra > pages were freed by the shrinker.... My first preference would still be to just leave it. IMO that one line saved in a small handful of places isn't worth the indirection, obscuring the `current' deref etc. But mm_account_reclaimed_pages() works for me if you really want to enapsulate it.