From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 662CDC678D5 for ; Wed, 8 Mar 2023 22:48:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 034EE6B0075; Wed, 8 Mar 2023 17:48:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F27136B0078; Wed, 8 Mar 2023 17:48:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEEEA6B007B; Wed, 8 Mar 2023 17:48:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D1E7D6B0075 for ; Wed, 8 Mar 2023 17:48:37 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A16A2410CD for ; Wed, 8 Mar 2023 22:48:37 +0000 (UTC) X-FDA: 80547221874.07.FB7269E Received: from hosting.gsystem.sk (hosting.gsystem.sk [212.5.213.30]) by imf29.hostedemail.com (Postfix) with ESMTP id 650E4120011 for ; Wed, 8 Mar 2023 22:48:35 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf29.hostedemail.com: domain of linux@zary.sk designates 212.5.213.30 as permitted sender) smtp.mailfrom=linux@zary.sk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678315716; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BV5FnIJstHJ/F+wYIPIp0wQTl03HERzVvtfHE7cWrpU=; b=7Zsw4nNEz5PWqp9zQQCrYjYvanMlMd8lPAJLZILtwZ5aI9LaEJgSw2j/NBoYz45p8mWGlz grkZn9yMwua4ZqcwUkDs67jP2OgqHeG7ZTYIa66YdrGKGX885QmB53qRm3KKPfn3YgjXFi AVEJjSRRUjnmr+TDelCY52ENO+aCEdE= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf29.hostedemail.com: domain of linux@zary.sk designates 212.5.213.30 as permitted sender) smtp.mailfrom=linux@zary.sk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678315716; a=rsa-sha256; cv=none; b=r/ArRkJ10n6kcfMNM7kY8RPgY8oq/qHSerxOc/rAttMt434NDHaar0lV6l12eB6RGYqh2d mnrMjJKS1BaqhFllWnj4Fzq8P3+J5+6o7u1/lBqoobQ/5YdCGzhT4499Z/qblE/EtfK3Mm czftC5MbFMaamhkNxb7W4blQZeJ6ZkA= Received: from [192.168.0.2] (chello089173232159.chello.sk [89.173.232.159]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by hosting.gsystem.sk (Postfix) with ESMTPSA id 631267A03E2; Wed, 8 Mar 2023 23:48:33 +0100 (CET) From: Ondrej Zary To: Luis Chamberlain Subject: Re: [PATCH v4 1/4] video: fbdev: atyfb: only use ioremap_uc() on i386 and ia64 Date: Wed, 8 Mar 2023 23:48:29 +0100 User-Agent: KMail/1.9.10 Cc: Baoquan He , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, mpe@ellerman.id.au, geert@linux-m68k.org, hch@infradead.org, Helge Deller , Thomas Zimmermann , Christophe Leroy , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20230308130710.368085-1-bhe@redhat.com> <20230308130710.368085-2-bhe@redhat.com> In-Reply-To: X-KMail-QuotePrefix: > MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <202303082348.29416.linux@zary.sk> X-Rspamd-Queue-Id: 650E4120011 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 3tnu9ut1w98kjauhknig6ycrdedku719 X-HE-Tag: 1678315715-325160 X-HE-Meta: U2FsdGVkX19rxXQy02OxVvVHGaZN/V5/YqlUpBkiboq2sPSzeh70sgQscBGn63LnqHoQaZypzKVQ/A7i9kL+yfz3h2AyzkJf0iKcvMxPL0LZ1gja4azLaOVYJIfqvxwDQI4zvoMuz9Ka1hxQKclU0J6u1NZ13CFg8d9pnIDhAylThufcNo+iNxVzch33oK/e2tlEDMMM+3wVgoGkn4vjPf0VjngNiCD861kUBrE2YukOjT8NDIb10zDm4Opco0ZeYey8prVMeqUsz1gHrn1Ik+5EXc9n82cYz0DnOFJdro13KrP6pSGszwmKIZy+1FxpKbfp+ZWXEgBTQFgg0ziFteIZLgJL9E2wqdclHY7OTjB8eG832VN09MSzz0aR3m5mb7MuG13+xbizP5Xx55Vtnt68aAFyQi4MI05tJwKMMKzyYs/ri568eOfM5JbN98zC+VpRcZSpW9yWgrzYQK5vVz5CsaiUiCBLSzza4zhCMqrAavn0evBpwU4jMUjYX1fPfRgrscHexJMSoHu9buu7XADKEU4gD9ijPkP0vDmdzxURiSHOqKST4VIidlgxv+shkBRgViCDcbSlK0ECvzMWN1bl+fthzfKN2jiPfXk7xAjuaGTlyNLz4LBj6GBdpAr6ZXRiZD0PdqkfbqbtAxeBDtcStqOydivgMXXxeXVjvbTadubjIFRDkbN3YbJcDZLlreB3zQ8nM/VqGooVxHNl/3vroq0ZIFiJzRWWEKXv2IXuin/1vvqYu7Ch4upaRaz2kD1G14K0AOffiHdOpNp+eoFAUiDeShGRy+dGvsf08SAf3izPBfMjGI5Tzd0AoLGkD3mWMZYn6LSC/C7vXj1xyOoWmQZyUco3z+2gRoNXksZpel7GO6s//inLIEPfbREnrAYaNIG/vhTA4esj42kN3zle4pNeKEfhep04VfET1GrloOzsPOHVMtFhwafAjNv5AKjufua0axax7zS4anQ DgDcJTtF GNQ7iwNel3dIjVATXFmfSlkiSRkBuqClCsHp63P41+Nf5F2EvQvt0EO+G3IIzBNStnAXTTupLu3vMSYtJ+/L2rcFh1XbVIECJbKxjbavxyBS8IXymW9fcrstaDiHCoR6iBsGGTyDoac4nol1V48hLMGQ2dc1dTFp2ijHMGsWR0opESLGIpJc6AB/BPFNBNjsQgji9dVHhAZL9dkA6+TxYs3cdnezfJo4mjlItnUYz4el3JoikK/NLZSqa/hzKAaw6OdDrLCELuiciXUnjl76atobY08AOE4PLKgPvShfXoyd0nTQy608Es2U1hSaLm7SqtLqXS2tILXNepe0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wednesday 08 March 2023 21:01:09 Luis Chamberlain wrote: > On Wed, Mar 08, 2023 at 09:07:07PM +0800, Baoquan He wrote: > > From: Arnd Bergmann > > > > ioremap_uc() is only meaningful on old x86-32 systems with the PAT > > extension, and on ia64 with its slightly unconventional ioremap() > > behavior, everywhere else this is the same as ioremap() anyway. > > > > Change the only driver that still references ioremap_uc() to only do so > > on x86-32/ia64 in order to allow removing that interface at some > > point in the future for the other architectures. > > > > On some architectures, ioremap_uc() just returns NULL, changing > > the driver to call ioremap() means that they now have a chance > > of working correctly. > > > > Signed-off-by: Arnd Bergmann > > Signed-off-by: Baoquan He > > Cc: Helge Deller > > Cc: Thomas Zimmermann > > Cc: Christophe Leroy > > Cc: linux-fbdev@vger.kernel.org > > Cc: dri-devel@lists.freedesktop.org > > Reviewed-by: Luis Chamberlain > > Is anyone using this driver these days? How often do fbdev drivers get > audited to see what can be nuked? Older servers have integrated ATI Rage XL chips and this is the only driver for it. -- Ondrej Zary