From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 276FBC64EC4 for ; Wed, 8 Mar 2023 21:25:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 886526B007B; Wed, 8 Mar 2023 16:25:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 835D36B007D; Wed, 8 Mar 2023 16:25:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D6D66B007E; Wed, 8 Mar 2023 16:25:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5B9896B007B for ; Wed, 8 Mar 2023 16:25:36 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 220824108B for ; Wed, 8 Mar 2023 21:25:36 +0000 (UTC) X-FDA: 80547012672.05.E0A820A Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf11.hostedemail.com (Postfix) with ESMTP id 3D72640019 for ; Wed, 8 Mar 2023 21:25:33 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=fromorbit-com.20210112.gappssmtp.com header.s=20210112 header.b=x+EOuqn0; spf=pass (imf11.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678310734; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bmzOoZCs46sKhyhk59+DKFkb2aMBcXcrxeigQ+YCTU4=; b=PyTiPst9m/79lhJByxZ2s4bbLtCcNIExn6HhfYwhj3Zc/9qXXumMSRMwsioWe45/UUNKm8 h+ekNmwtWRwP8q5vaqHmdiESaP4582rqJ0KHfVXdFkC9E0CCoojUS9/7MsIeZO6yTFyQwK t/CrmFbJJAiQoYmau3MwbvgKq+ZTcqA= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=fromorbit-com.20210112.gappssmtp.com header.s=20210112 header.b=x+EOuqn0; spf=pass (imf11.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678310734; a=rsa-sha256; cv=none; b=2cdKwZXlU0hkhMtlXdWaNgdydg4uWtqbhHBwkBthsa++sM91q7MBY+ONpdfil7I8hz8+Gt fgBI4YL7ZOF4qASJF8QIV8p/jrhz4lvbzDpF3kGE5iB54yGLgrt6SGDMoLFgq3hURVL1XN qrR6m3P9ke74yVrNl8Ayn9b3kJx/1IY= Received: by mail-pl1-f171.google.com with SMTP id i10so18966889plr.9 for ; Wed, 08 Mar 2023 13:25:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20210112.gappssmtp.com; s=20210112; t=1678310733; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bmzOoZCs46sKhyhk59+DKFkb2aMBcXcrxeigQ+YCTU4=; b=x+EOuqn0mahV8jZh36jVG1TqrbzDt4BkgHSUp64S/nzFR4bMgwuOV+A7UWHRqC1Fra tJNV4Gs3xd3tNPygxRby1lh2exQb1616GniHerwmF1ZZwPVmRqRz0uhMm92Qb+5s/JAI w3SM2Q/oHxZdVaAMVsOu00dzNvekOlF+Td2IBs1We1cpDEA6JK8w8K0rQUnLC24xJP+Y HJuvddvXWtILX8pClXLxfRdn3HZinj7K5mCAImuLcIt0LBOO0t6jJSwLO5RRtNPDLuSs aSnkU473AdphasIATUDAV/md8kxR7DoOy45rEy+1dHhLdX6mK471kCuchTCeYjqL6e5P ew7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678310733; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bmzOoZCs46sKhyhk59+DKFkb2aMBcXcrxeigQ+YCTU4=; b=ba7WtErcOgM5zGEch64fqsZhHiZbh306DET7Q+pGL45cMWgSup8GkJ81rBP6hiP62b hoeZ3kKitUhYgAc7rbd4a0XWccpTMuirr84zFMWNOIgDPHN01PHlvQsjoLAkGo7hMk/H RBawCws69ukS6c1Nli+FfQw8XIl1CyhPmjx6uOu21X7L2p4aNY6CVl4tuf6TUvAXT4IW 1gcVlBbYEzrc50RXQ9eVDisJroLfGYfGQ+gqV9dFLdX+GqjdRUsp/8zk16Flpf4mnk8k 602pAxE31vhdOSGhdwo6Z18ym3ibl6oCVXPn+eiaUfcKUr+sjASAqmRKhw8j0ct2CzbX vlrQ== X-Gm-Message-State: AO0yUKXBC69qohFTWlyEUKqOjP2rzTzJjr0QAFEVKxYAGBa/z5JZpC7C ZGuXqiC4+Ogqv44q7Gl4OroKgkj3f6ITXwi5eiU= X-Google-Smtp-Source: AK7set8yE4FKZ4iGjtNFh1nXJmjGKqxf5HRTViI0SSES4LOMIfUP8zBqmb/iTGtU5aDyftUVC3B8oQ== X-Received: by 2002:a05:6a20:a624:b0:cc:92ee:b119 with SMTP id bb36-20020a056a20a62400b000cc92eeb119mr15111745pzb.45.1678310733057; Wed, 08 Mar 2023 13:25:33 -0800 (PST) Received: from dread.disaster.area (pa49-186-4-237.pa.vic.optusnet.com.au. [49.186.4.237]) by smtp.gmail.com with ESMTPSA id a14-20020a62e20e000000b00582f222f088sm9837681pfi.47.2023.03.08.13.25.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 13:25:32 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1pa1Ht-006RAm-Na; Thu, 09 Mar 2023 08:25:29 +1100 Date: Thu, 9 Mar 2023 08:25:29 +1100 From: Dave Chinner To: Yosry Ahmed Cc: Johannes Weiner , Alexander Viro , "Darrick J. Wong" , Christoph Lameter , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Matthew Wilcox (Oracle)" , Miaohe Lin , David Hildenbrand , Peter Xu , NeilBrown , Shakeel Butt , Michal Hocko , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v1 0/2] Ignore non-LRU-based reclaim in memcg reclaim Message-ID: <20230308212529.GL360264@dread.disaster.area> References: <20230228085002.2592473-1-yosryahmed@google.com> <20230308160056.GA414058@cmpxchg.org> <20230308201629.GB476158@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: 1zgnryzrxy9jm9x83bnkjdtymhy8ouuy X-Rspam-User: X-Rspamd-Queue-Id: 3D72640019 X-Rspamd-Server: rspam06 X-HE-Tag: 1678310733-948746 X-HE-Meta: U2FsdGVkX1/DgGMm95mAT/AQTJ2u6FUc2KFGfIL+4BSStxC1yFwrpQi6VPR7stSG1fRziK9n4GU0YaLYtpuZdxmfBO7BIK5i/Jd9Q4hxvt7bCJeDzTQ6zd8eGN4BqhAPx/YOArkCKSf363v032PPt37RObVXFIh7Ah2xcrEgt+RX2BjRXbBy5+5g11Sh9uhhwAEHsqsiz2WD3uISnnIwZLJebSCcX+xEumOZICvS9Dc+xp+mIS/Tf2rg/D7xMdCYcKoxNg/Oz2D7jfNJj316naEaWxFrMRqZLsldKUhLC6JraH4xVp+lhi44ZTHlkbEEleDGBBtR2wXCWc+e07w3BmjejHrzbgqTYUbBbi3Z7OmWVuxTSKWSbpucDwt9pPLUEV8sWsE5wydWWliF/GmNSksalus5cEgyLt8GkCLZk9htfvT/Ef6x/xK5PLVGtj7gUv5W5aQbRQ1GtUpjmviJxxJqIfizciS+ULABGUooHAmA0sVSMLRacZttIpswirnhzybWX41j9GXzI/pKV7urxrofsjrsxzMQYTcP/PKi7scquthCCweOtIP1EZG7h/5TVxUu4rWkva9rztJV7GP7s78QUuIIURTkUe3z5XFJ3EkkgKDbjGDr7jX5tKoWHxG0a8m3giVF8oQrbhyBe70EVaJ74wtSmBVWfloGejG7eowf91El3db3bNdpIO+bhQ/pSgcZX6kdOIHx1uz0gHfiygm2nhTye1JnrKbhF0NKNAvRwfyA9+kBElCzdZFbuSJHHl0QeN2GDNCtga8BjeZCm4FeFoPwcBPugjbGHEKVw6hHJ733W0PpCSp6RCEv8Nz4rHXN2vIsfYkulmMmaikn+7/Hnij3N5K4cXRLWXHqzEivD7sivgkIC0ngDlzhFuqYL1tLByTgmK+CeTikeeoU/zoN62Jos2criMTq1ig8YR7FoZgRGfD0Q3RKxRCchmrVcygtSpt1Yd+dq27r14F iGaPSnsw dT/JHxluK6EriwlWE7rt0rqOs2f4+xQqRRtX+Qm/e8XHvW3dOaiOaaVEu+mJn5gAliOI/SXeRWe87KoE9mJdp/mLDHtO/w2tAWPvQ/uwYquGku5bCkJZm9IOYrbue7SqLPumLrStJ5giJxXuv7ZJbFo8REmbrdwB+j1q+EdV2WqgNHp4EHQgCgRYbFDPDsjAFYU1oR2H0ZIaDACFk5zqcwINgoaAAzCfMuFpA4vg1N9reN7qBQiHtBKLSZP1WFdDtNlY057mLp9D2HyNHrW3QVMfzx6b1gDLf3ajFXPWYOnSrTSxjr7iLN2XdDcxrISka+jtEeE2JrWRwjENNYfTQjj+tcRMXCGz63wD01ptHjBHf1vmVj0lX1cJ9ws0DTiM2tBmKhybmtXrZVIiccDd8PGLdYX/rWKiX61QVpSZZTsP4SLJ/zQzudDaKwzpL5PIqSvt146UKV7UaRej0EUfxdKMnJmkPW1Vlm6K8pBbv90Us9/mQ6jffHHNR/w8rdS+6IWUqpKgZC6LSBo9apc0QdEB1andDvc5thqbq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 08, 2023 at 12:24:08PM -0800, Yosry Ahmed wrote: > > I tried to come up with something better, but wasn't happy with any of > > the options, either. So I defaulted to just leaving it alone :-) > > > > It's part of the shrinker API and the name hasn't changed since the > > initial git import of the kernel tree. It should be fine, churn-wise. > > Last attempt, just update_reclaim_state() (corresponding to > flush_reclaim_state() below). It doesn't tell a story, but neither > does incrementing a counter in current->reclaim_state. If that doesn't > make you happy I'll give up now and leave it as-is :) This is used in different subsystem shrinkers outside mm/, so the name needs to be correctly namespaced. Please prefix it with the subsystem the function belongs to, at minimum. mm_account_reclaimed_pages() is what is actually being done here. It is self describing and leaves behind no ambiguity as to what is being accounted and why, nor which subsystem the accounting belongs to. It doesn't matter what the internal mm/vmscan structures are called, all we care about is telling the mm infrastructure how many extra pages were freed by the shrinker.... -Dave. -- Dave Chinner david@fromorbit.com