From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 011EAC64EC4 for ; Wed, 8 Mar 2023 21:08:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 957896B007B; Wed, 8 Mar 2023 16:08:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 90705280001; Wed, 8 Mar 2023 16:08:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D02E6B007E; Wed, 8 Mar 2023 16:08:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6D3396B007B for ; Wed, 8 Mar 2023 16:08:44 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 41B4B1C68E7 for ; Wed, 8 Mar 2023 21:08:44 +0000 (UTC) X-FDA: 80546970168.05.9D07AFB Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf19.hostedemail.com (Postfix) with ESMTP id 558661A0010 for ; Wed, 8 Mar 2023 21:08:41 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=fromorbit-com.20210112.gappssmtp.com header.s=20210112 header.b=DC948+R6; spf=pass (imf19.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678309721; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uQjAWnx5lQ/2cENFz0YdGZbVbhOf2bedNqDxQZfmLmE=; b=yQv+1N4bq/SapYFneRFpsvONZUNTCo4iG1B47PKPjIPahZpneBguK9kW7fl2xI0YdTD/u6 sQtu9qwZ/I36dWsBdlmdJRPpI23vc69+AbVtpjKIsX6YT09cV1huiiJzX72XLSI/R4vP5m a8FmhU2mkEXzYaO6uphf0cosMOAEsGE= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=fromorbit-com.20210112.gappssmtp.com header.s=20210112 header.b=DC948+R6; spf=pass (imf19.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678309721; a=rsa-sha256; cv=none; b=5b7NmFqyC6o7P9qvaRxhEnqpnXvmgntDgCMLZn1aJDASYI+8vE2yH1MHQ1b5s2MY5LyI+u evR0sA3ilCxFn19tczV1RFCSSpdMLnGLBv9Z/e561+l5V457WyvPYbEyKHEMr2FHu2gjBG WkQbjtHq/jk/HE79sMEsRF2nVTh/kaI= Received: by mail-pl1-f172.google.com with SMTP id i3so18942557plg.6 for ; Wed, 08 Mar 2023 13:08:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20210112.gappssmtp.com; s=20210112; t=1678309720; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=uQjAWnx5lQ/2cENFz0YdGZbVbhOf2bedNqDxQZfmLmE=; b=DC948+R6ch+RYEfp2Fh69Wc5fEuezDxGyjm5a2ojDEmAJabOsIgx14BASBdNePqbO7 A1sw5VdAMlS5De8EQ1Mm1vUNzQNIf8mMGPmHf6r/y99zKv0JSCyUIT8mU6KxsnmQiIGd 2B7JuvDg8ms78MFJG+iPG8At90jWfpGWObImE5SBbRydaL5IUtud20x8Y8wdTtN/9Z/W FzgSTkckrxVQvBO3vI9A4viY2HXPPIyGkYnjb7ahWkZxK/znzbWaSMEhWHYPxrHDOVw0 dduyixO5zIoWd/R5IIIWgSjIMTiv4qyyJ8WE80iykm3ooAeKS7B1hW5TcRKXHes0mAAN iYKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678309720; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uQjAWnx5lQ/2cENFz0YdGZbVbhOf2bedNqDxQZfmLmE=; b=Cwqe8JNmwg8bCN3VjcYAtQLYKEm6INDXGrJouIBH6Vt4tJdSEHbMm/2osfkgzo2ron dGIzA+zWlo/Yqc8otSwaPQCAQ1P/rcbhoed7r5EaijDlx+y590exqSBqDT+imOOIWMNG t1eTCZbIMeVzZt+WRs8aYia5pRUfD52Cj/BfJ77UxxzRKgi7uWYod+7JeI1uOB/D/dxc 3oJsfctLlCTJfzlRhJ3SAzN786bs1Kgk5rjlUpYKAoa0Wxn6cl1sCTWTEbq3dN5TAr63 q/oJwk/DwLXAGqRQYnS9q9787S7FD8tdQliXqAYDPK0MKXGtZ96kIEbk00wXYgKLUUiN lx8w== X-Gm-Message-State: AO0yUKVi6dlHYooQG369rSTGJLyBvzvAsGBX7hp8jkavxEl4+XYb4kvs 6i9L/F5oh0QBGYR1gk7P3xuTCw== X-Google-Smtp-Source: AK7set8/nCJPbgdHyS22yS22YNGDj4za3NiHgaPgzaWsI9o9vVTaHqTsc2ZqcZJtvgEtszxlzM/WcA== X-Received: by 2002:a17:902:d38c:b0:19d:16e4:ac20 with SMTP id e12-20020a170902d38c00b0019d16e4ac20mr18011067pld.63.1678309719618; Wed, 08 Mar 2023 13:08:39 -0800 (PST) Received: from dread.disaster.area (pa49-186-4-237.pa.vic.optusnet.com.au. [49.186.4.237]) by smtp.gmail.com with ESMTPSA id kq3-20020a170903284300b0019b9a075f1fsm10217942plb.80.2023.03.08.13.08.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 13:08:39 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1pa11Y-006QqV-6V; Thu, 09 Mar 2023 08:08:36 +1100 Date: Thu, 9 Mar 2023 08:08:36 +1100 From: Dave Chinner To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, John Hubbard Subject: Re: [PATCH v17 09/14] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing Message-ID: <20230308210836.GV2825702@dread.disaster.area> References: <20230308165251.2078898-1-dhowells@redhat.com> <20230308165251.2078898-10-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230308165251.2078898-10-dhowells@redhat.com> X-Stat-Signature: cm1sr45xs18jgcg15ag58jkwtc95bnoi X-Rspam-User: X-Rspamd-Queue-Id: 558661A0010 X-Rspamd-Server: rspam06 X-HE-Tag: 1678309721-363084 X-HE-Meta: U2FsdGVkX19r727HgzYdsGt8/EEBXCrd1YSsMMprixZu9iatwakn4/0KUMtOcA32ueEFsTPSzCXxnBMAV0WiNnP7tLtr3S50uRLZOnyMpuiKlrTEMD8tJFQdOvfP6MUGMl5T7LxzHXOv1/zmVycI9KM+RT8OqbZr761YJQm+pTMXG4HcaMmcY7CW4zoDzj7v+V3gWImHF1SYh4cDqQ6xWBixUKaPxI3vIHaLbuzAaqIHWjhYTILSpE61jOLIg/Jk74NL++ZEfhLgjW42XjrRUhwQuWe/P30haUyosEceYKYvL6z6ULRn+jRXAE6U+C83y0kTOyDyxn0XtoTNpglB03X0jNWoglhr6vyXI0E5K+j/zwaQIcXUyaL7W8z45Zg1xkLEdaZlOpA+Zet8vPc9Vq93gH+2eTcE+5XF63B7a4EFfh6OWHryRANjiJMRWE0rn7Y2Nr2syVk1T2FGmrBJGeHwRs0lAhLWk8no8k0cuV2q82lGpsAR0jIdGNyiaUOI+WHbAvG5DEiLbkI5zrKn+G9DHXkY5YwlXb/4mOZ4DagT7LAZrZuqfi27GBFf3ML+OsI/JVANbGMYYqeqFuQZvH9O+OKmsAUddHV08+85wqrTFraBSAlvBzfcO8hGy+4LTkPNrz0l+Emt140/goXoKGwkK7ZPVJgXWmWB21Bjl+3bp8h28vM83g9U1C+v2I3eUHkAHgF/45GzotMfjbZd6eqWCd8+VAySyxwKV1+SgvRZVIcZ+HrAkMGdbsUxcazhO93Z04T0KUiMawEUxtTZh3wsG94brxzD8QPHcRbds75xAqtQngPRJfTU8RZCjxUK4xeLGfAd+ccq22L/xVBsXpngVcsl6QQemy9deNvuuKr+712Vwg6l2zyRQpb4ZDt7HIJ2Jkj6V+0SEtsQi4LVn/aMkCvJt5W7B7EaPtlril/5Wz8kkXlTafrBDgLX7KTAAJhYN4nxeqtJUU2rcGB YaKuI9Gg gJzpSPOO9OygnP3Qe3rXeId2S9+77tqOGeJcS4AzhPonuh4m29OpA7foRKQGcMHVzf7Q85ehPWRT3trYXDiVJYT1FrjAnRA1zwTN+ZOHCa6MzVm1BTDV3eDl35F8FfjYJKp50+1AnYtZk8V+EW4UUq5+gkhcCRVuKjPb0tEChYlGR1Xnp4//UWL6IqskH3l2LKiAiIOavRwg4v80JCU6OeAt7TvAOe5g2UuIHB7FwgkyvG8CO5kxLNnHA4oeDsMqF1o1+nFceTnojcuE33/vsvsirx871fuXb7i9B776V1V0ZjKvAPsNFVQdcu0+0CAUSi932cwrTsyasmcqzFOOF3TWkXQx8nkm0otKCapYEktyCUNq7SNO8afr4dY9KSdRLcf36ymcRY6K+OnmFE6nLZRry119OJs8VSEPyZyLF/fGSRARBA37u6OhT7Bjao7KXnGUjUbLN1YS1vcL7OPXpvXh4XOcztmbeUv2pO9f6vaY8y2OIk7tRose6cDA+Z/8veephOaIVVVdrelDSB6gwdcu3HBjaCYi9GG1//k7JwGRIIr5smYpQjrQWuNjAp2A42CfNtPBXUal7v4XlkeGONDTaxTfPHtBB9iF64JpjL6nMIYgx9rC5f7sjarcjIxyQY56rIFnNKv6YaDZltgBzOZ7+YCUzWgUSxn/q4NUDvhShtNw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 08, 2023 at 04:52:46PM +0000, David Howells wrote: > ZERO_PAGE can't go away, no need to hold an extra reference. > > Signed-off-by: David Howells > Reviewed-by: David Hildenbrand > Reviewed-by: John Hubbard > cc: Al Viro > cc: David Hildenbrand > cc: linux-fsdevel@vger.kernel.org > --- > fs/iomap/direct-io.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c > index f771001574d0..850fb9870c2f 100644 > --- a/fs/iomap/direct-io.c > +++ b/fs/iomap/direct-io.c > @@ -202,7 +202,7 @@ static void iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio, > bio->bi_private = dio; > bio->bi_end_io = iomap_dio_bio_end_io; > > - get_page(page); > + bio_set_flag(bio, BIO_NO_PAGE_REF); > __bio_add_page(bio, page, len, 0); > iomap_dio_submit_bio(iter, dio, bio, pos); > } Looks fine. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com