From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 503BCC6FD1C for ; Thu, 9 Mar 2023 01:55:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E1ABA280002; Wed, 8 Mar 2023 20:55:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DCAE96B0078; Wed, 8 Mar 2023 20:55:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9264280002; Wed, 8 Mar 2023 20:55:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B5AEE6B0075 for ; Wed, 8 Mar 2023 20:55:57 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8447A80EE0 for ; Thu, 9 Mar 2023 01:55:57 +0000 (UTC) X-FDA: 80547693954.26.466524D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id CD3B880008 for ; Thu, 9 Mar 2023 01:55:54 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=q2PEfWYK; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678326954; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RiX0++HfBn1ZPG1rmdYkQBV6J/WOboewcYUvctDd0aQ=; b=LCYERIfbQ8HsglOMTLEDVqMLo/kaWtzH38VHEQMYGYoOseUrBgcNPQEp+dB5szHG6zOriv BPm2ZWtn/xxzEcalauPSqfrOASf/7zspNgQ591eqDoIzm6NN6v5iHSJhQ2oGoEZMW9zNuR qqDMl1yc5ybTSEnGTxEP23SmrN7g1EQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=q2PEfWYK; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678326954; a=rsa-sha256; cv=none; b=frZsDcr6muTAdkHV2GIkum15pC1GIr6fLEUrGzYUpdUTxlCOpPHINUTwLHjsBq9NH8VKl6 mYrF/HXIODZlTbWAAjHJlIBWezSt/7GwliV4cYZdYA2s7HXQIgs0WcdGAY1hRyC/jPi6RA nRJnmDDTt7/kh0FtRyqbc7rpMPCasVM= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9880D61A00; Thu, 9 Mar 2023 01:55:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9083C433D2; Thu, 9 Mar 2023 01:55:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1678326953; bh=7K1zDoYHvERoTGV0MPG9gBDxpCQuGkPoP45v7mpT59Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=q2PEfWYKPm4UftxTQMS0NtgdbFDjMpZPEq9z6PC2G0Tbsfa6H/7zu5eHEgcXY0Toz wUKN8kuqZdtL1C3lz2nsuhTukTqBhLGHDdpeRcMaTQHzalm1pQCUlAPjcLDVlY7aBR sJAS9g2wAOAS6HeoLA26926K+A/Ta1k7a3lVdaKE= Date: Wed, 8 Mar 2023 17:55:52 -0800 From: Andrew Morton To: Peng Zhang Cc: Liam.Howlett@oracle.com, snild@sony.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, Stable@vger.kernel.org Subject: Re: [PATCH] maple_tree: Fix the error of mas->min/max in mas_skip_node() Message-Id: <20230308175552.60b3f6a3efda2289dc6c5bc9@linux-foundation.org> In-Reply-To: <20230307160340.57074-1-zhangpeng.00@bytedance.com> References: <20230307160340.57074-1-zhangpeng.00@bytedance.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: CD3B880008 X-Rspam-User: X-Stat-Signature: 5uix9ctm5pqjrszwtcqq9a936n61k8xh X-HE-Tag: 1678326954-631121 X-HE-Meta: U2FsdGVkX18woNA5Xj4UZ6G8VL5P1z9ziXzbYvrdxq46zwb+j5vK64SCJ8o5VuSgbaoKbhwYbmUMDwOYTLthPrLQE28hO0vHpJHR0fy4cNv6epaw1/zatcfeWTmXdDCffvhEFBYomkh2+IpDKYRacOADS+VqTIWphTugimOeO+QmPKsenRFSUbYHD6Ia4SxJE0VVlihEVNuomOXZw9kbzRdh75QRjhhJy78SMziEemS1pAXRdWJn7ELaHrm/C+uOo3vqueIvyYKV+8/al5Od2EH4ByFlx2CBURQcFZz7mhpUfQ/YR+qZdIkyiDopESyiLeFUlHQmguAeQ8iXrA+6GapVUmmLPWAYZYpfpQeb5gYv+BBzCNu3URR9e9kvYu+bwn9nq6dIVqu8BVfzcSOdAgmjo8Cc48Gb7BzTU/A3ZjVJ1ecHA8ETLYMMSRwK0ZJ/1pDWP8If6sGTB2k1MBWFKtLVH7p1VVBP8g82JdM7e4q6BakNGdM1EmwWARntLo6BaSDYJx+vNE5KivUIqYtMcJkgaNu0ZDEQbRARHjWbZNK9BXsuaz6Kj+4sxZOe/mRa9ivwdgYidhsbSaKsBf4T987z4EbmH+Q+c0T2iZjO1UbODJ22qG2tzDIEk5M1wtiw1zxz88i0kd5AGmA1S2xtgVkzvwnC8Us9tSRM52ZFyDJCWHlxN7Ak00u5xNP7cu8IxvkEkRUNQtVICmxxkJJ5y/c2p4ImgEqLze672rQqQ0tV26p3Bu+0AY1kuJ3yzUfSKGgMAX7IVPay0mMjwWEAoNIWVxzjPvcfWH7FPp5EUZ9nNq8N8mT0N8A2fnr6Px8D0uR0ZZ+Z0V6CqYfqOz96UGXlR6ZkP4Y87X4bOkwOez+v5aV1h6GuFcpyO81FahmDmRWQASY/34tFJU/RdegQD141JwqNLnPva88gfzkrUyK2V0dRwOOtzBnjLStwJEMXhI/z7wBig13XkhtqPXo Ix7keX2q Ktgb8bD6xKscYg+249zF9prbJgE9E8PqvLIauF0NgvGVrKvF8QqNaREqV20/mI9RBT07ZJV2yF54VJKAYfGru1Wze/KvQ9s+W4rksuPaUSWr30mnt3X9xHkYzhELQMRTBCLgkb+CVXTV+x1df16zxlNRaYPB+g+88PV5FQzjVUGxgZMzajZFxiHWxNHsUYeTC919D/+CAhKJq7wrsXoADDEo/ZXU1Wv9cTbhOCPiO5DknYFrBdbuyctXKhFWn8Am+YrDZdTHbgdGJfomnrgywkGU56dzr9jizGYuWwsidI6v+mfmEWLISzz3ww/6bXlVdzIaXNc4EVRptt/Q8WS7CcnAnATFVjvXjmS4aHFrsFHctAUApq4NestSkKKtEozfU2NmNOswto3JJGFRpLjmNyER8zEj9FI7CxTFsf6gWp04Wbs+ZLD9eH4DLVewjGxSAOFsg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 8 Mar 2023 00:03:40 +0800 Peng Zhang wrote: > The assignment of mas->min and mas->max is wrong. mas->min and mas->max > should represent the range of the current node. After mas_ascend() > returns, mas-min and mas->max already represent the range of the current > node, so we should delete these assignments of mas->min and mas->max. > Please fully describe the user-visible effects of the flaw, especially when proposing a -stable backport.