From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 205D9C678D5 for ; Wed, 8 Mar 2023 16:26:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7649C6B0072; Wed, 8 Mar 2023 11:26:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 714BB6B0074; Wed, 8 Mar 2023 11:26:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DE2C6B0075; Wed, 8 Mar 2023 11:26:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 507AD6B0072 for ; Wed, 8 Mar 2023 11:26:15 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 185E480FF4 for ; Wed, 8 Mar 2023 16:26:15 +0000 (UTC) X-FDA: 80546258310.19.0CBAA19 Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) by imf29.hostedemail.com (Postfix) with ESMTP id 504C9120016 for ; Wed, 8 Mar 2023 16:26:12 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=CNf5LmES; spf=pass (imf29.hostedemail.com: domain of findns94@gmail.com designates 209.85.219.45 as permitted sender) smtp.mailfrom=findns94@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678292772; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references:dkim-signature; bh=PWwMHeJpend+hzpuPqFIQzMgVunHLYMAMCx5MYeNU2o=; b=2us9aQqq0VuQrj46q2L5A1XuADdSOY7PHqLfds474wCuGxJeAvuSwu4msCJs0nftCPEHvZ vfRR8AxgUDLzsusLVCA/Eh0SCRlOAZE5wLboIDkZMhOkNhztdmx6laBWne07hYPIkX5BHd BGCjv8bHLSz0rTYBShRUys+LZD3qkVI= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=CNf5LmES; spf=pass (imf29.hostedemail.com: domain of findns94@gmail.com designates 209.85.219.45 as permitted sender) smtp.mailfrom=findns94@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678292772; a=rsa-sha256; cv=none; b=CDPISnfi9UY39V13vv81j044GIUOTZcEwNpnIXJjjSjMtGGqUmie4eYwoLDMbBY5A3Sxow VUMFoxI8YPvEb/6PVl3mgjqR2ywPt1cZ5S0QutZpjLp/oKOmV4rjMt2OIhHK6PPDzOgZ30 PtfKYE1Skcuo4fQIUuSFarCho2eaOjM= Received: by mail-qv1-f45.google.com with SMTP id op8so11410631qvb.11 for ; Wed, 08 Mar 2023 08:26:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678292771; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PWwMHeJpend+hzpuPqFIQzMgVunHLYMAMCx5MYeNU2o=; b=CNf5LmESb4+kOCQPbjMP3umJWUrWFr7U3y+v8xZk5znqjCZWCO/16aFonllNQHNRat Z2dON/28zs8dIvG93QXsMc8SjqHPhwmN/CEm+ULLN7V3peF9D09lEhm/2OMLfA92Q39I hQ7D6o6MgkuomYj5Dmzoio/OCP1Ym6QmxKFpFadpIpSXZtvbyTicuMJX2ucI4Axzwjjh 9xsz2lXZR+ynHCDTZ830xdWISm4rQF89FOJbbiTjhcgfeBMsfgwTUp6X4eLFzxqMn2lb VE72KXOQ4EXPKjmYmVa8Cc4zqMO5BZpM6TyRJGTv6mXp6qoYE9oeg2vmrsP+GZnxY/dS OQkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678292771; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PWwMHeJpend+hzpuPqFIQzMgVunHLYMAMCx5MYeNU2o=; b=Jq9f6W9bqk7h5wAqqizP8OvzKfT1gyoUhD6F/K/lHhumoUy+WkQBHk4vmHXIqmj8Q2 peGCMygrlPz9Z3C1osD4NJ1T64ez27QJ7GGopbBBfqkjQgTCM23rRkr5w/Z3ruaXhuu5 JVps+ZSpT1Vx9Xeq5rgZJk9cx3WncVEfjM4nLJvDqPlz22Jucg7mOsf+X96ZC7C1sRYN oH8Sh+R9LspJ6CFU1idvn3fMB+ow+iHOGC5LPKxfIsuoEZYs4IXgKlE+WFdJ8PZs8pIL v0arLZKBM36C/4unE0Sr+eegt4Pjq1+510V2/RbBi+RPZ1LXuUJ1KvR122ojcQlSd8bA dQ4w== X-Gm-Message-State: AO0yUKW/8q5+BfNQT0O9LWsyopCUNRv2yzUOLiWUTrxdwoOz7GVK38jU gVH/7fPnHLb8euwB1qrbKa4= X-Google-Smtp-Source: AK7set/as0jc+PLnDcLadk3eqz5UZsoBO2dp2eM+0xhER+r6ezgdGVFNJO6maPLojNxiR8j6ovPReg== X-Received: by 2002:a05:6214:20c4:b0:56c:240d:3015 with SMTP id 4-20020a05621420c400b0056c240d3015mr4615645qve.32.1678292771444; Wed, 08 Mar 2023 08:26:11 -0800 (PST) Received: from MSI-FindNS.localdomain ([107.191.40.138]) by smtp.gmail.com with ESMTPSA id w20-20020a05620a0e9400b0073b8459d221sm11619813qkm.31.2023.03.08.08.26.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 08:26:11 -0800 (PST) From: Yue Zhao To: akpm@linux-foundation.org Cc: roman.gushchin@linux.dev, hannes@cmpxchg.org, mhocko@kernel.org, shakeelb@google.com, muchun.song@linux.dev, willy@infradead.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, tangyeechou@gmail.com, Yue Zhao Subject: [PATCH v3, 0/4] mm, memcg: cgroup v1 and v2 tunable load/store tearing fixes Date: Thu, 9 Mar 2023 00:25:51 +0800 Message-Id: <20230308162555.14195-1-findns94@gmail.com> X-Mailer: git-send-email 2.17.1 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 504C9120016 X-Stat-Signature: cit1h9to7f4wzw1rb5w6nqqxp939k3ku X-Rspam-User: X-HE-Tag: 1678292772-680150 X-HE-Meta: U2FsdGVkX19BwApZODg9O5sTtqOYMrRC5RokosHjdH9lDTkFie0LM46HDZJdnZfzgVJqBKyU+mfMUVGrysxmQD7L+TlrH4A+llHaJ6VUeXzFv26r/86PiHBjU1Z4Mbzi6Xkt7/KjBZPOFIiV0P7t7L/Uy8fyoq+YAF+QJMkoQYCk5dpbB5B0t20WfPlbKBQSoMy3xduy3UyzrCKBB2+MIUoKUyRDElgTUTZyc1GaUtPnLZELWFEHGs6YUimVnJZ3mMPcLVZSdqde8mspduCHEJeQNUdhcDIbRgcX9qWOire7mmtLEUMC0xVyHua6sjrQqUkl3a0BnMwltM8/Jkc/Hrxa8j9RE0kDjCTDRYT8fdgcuLF+GvHPuoUEj7OJ89Ox7UYoFqwwmOgfQrMpNVHnCVS3ags+3ZQLKcMF1XaA4/BnJiwA2pJWNZVCTbRCe/Iw2/rLvjxq72wjj8Ft3DBu65rS/FLVjDqeSiLgcQ9Q+nV2Tz9OgtPDk7NQYmd0NpKwMUKPKrhUD3ytgImmZ6kyXqTANyiIs5yBB5vv5SKXIat91eVx/zIzmqPLcieXesJNA7JR6X0zj8zMjSzmUXl2knaIFf4WrlwQOttFmvlGfdGr2Vwzw97TRZjOzqnb3YJaWbxD8ManhcGEXDpg3v0UqAwf9RZ5d3Rgnb+3uPE/GV1ekzu1z6h2c8ZAZsJybMMq5Dfw66PJ2gwWzH9eT43HiSn/cJXe+3ICfXrU+/2XakC1hfsLIDwSZjtb9WoKykyp6CEB8wkpdRuHi/UdyJnMqtLP88FNla2IOxY8vX1AcibW/yzoqFkR6rnlqeejBO7uV88nIOY0BEBVfGvVQ43ubamSCAvBX5hMdMgR8NpQWiigMBPSV5CcHXjRetAy94RrJTfRGd/AiMjadSqUgalo/jUJskbJf7giuAg3qbSnKXa+QUdAg6JMAs02Q3Vdc2m+6Z4+wRwyRe27G0gx9/o oxCrVYiW 8px7Pzm2xKZsOCP8Xps6K87f3STdlJmPU0kzk/VNXvQzfXyrHen9bVYJFnzH3+eysZFlFbAKWjBDy29gleixxB9bGGvHukCQDLNAXYUTG7InTaFm6DpM14TT0jvlHxI4PsuxEA3G+F1pBCq8vSugEQSoZFX2j+mg1LsKW4vskDZIff2xeScoSxPnRaA2sGuGtvhFhPDNydoOXSepn14auVf7HzvXE6mNrD0uth/4o0WhUC8wkCUl13t9KJxe3fTYXExsRvvbwXX8YYvBiSOYwk5u3s/0KKBSGwYfzFSU6jpECVlPyjN5KlhNQvEmjs+T07lnqg0gpkhgAPxGI3YzIskj4rGcrl9tehRmII5QoLvoA8sETiDo6VOJnmKvxCPDNO7iZypq0QrEy1vqBdgWwedCfbWUCtw5r1uEewNxmqn0HeOiZz41CJTHK4EnVroo6AZFhcHEsUfXuk1PorBkg6YoH8UvXZ+ZWjEQmEIcd9hKvJPg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This patch series helps to prevent load/store tearing in several cgroup knobs. As kindly pointed out by Michal Hocko, we should add [WRITE|READ]_ONCE for all occurrences of memcg->oom_kill_disable, memcg->swappiness and memcg->soft_limit. v3: - Add [WRITE|READ]_ONCE for all occurrences of memcg->oom_kill_disable, memcg->swappiness and memcg->soft_limit v2: - Rephrase changelog - Add [WRITE|READ]_ONCE for memcg->oom_kill_disable, memcg->swappiness, vm_swappiness and memcg->soft_limit v1: - Add [WRITE|READ]_ONCE for memcg->oom_group Past patches: V2: https://lore.kernel.org/linux-mm/20230306154138.3775-1-findns94@gmail.com/ V1: https://lore.kernel.org/linux-mm/20230220151638.1371-1-findns94@gmail.com/ Yue Zhao (4): mm, memcg: Prevent memory.oom.group load/store tearing mm, memcg: Prevent memory.swappiness load/store tearing mm, memcg: Prevent memory.oom_control load/store tearing mm, memcg: Prevent memory.soft_limit_in_bytes load/store tearing include/linux/swap.h | 8 ++++---- mm/memcontrol.c | 30 +++++++++++++++--------------- 2 files changed, 19 insertions(+), 19 deletions(-) -- 2.17.1