From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46D64C64EC4 for ; Wed, 8 Mar 2023 15:56:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CABD7280001; Wed, 8 Mar 2023 10:56:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C5C2B6B0074; Wed, 8 Mar 2023 10:56:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4AFE280001; Wed, 8 Mar 2023 10:56:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A4E596B0072 for ; Wed, 8 Mar 2023 10:56:16 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0D2BE1401DA for ; Wed, 8 Mar 2023 15:56:16 +0000 (UTC) X-FDA: 80546182752.18.4572681 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf24.hostedemail.com (Postfix) with ESMTP id 10161180017 for ; Wed, 8 Mar 2023 15:56:13 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=none; spf=none (imf24.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678290974; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1bSplfxMkfct6BqAwFxVXteuhipBs8vPIWG0WPClxSI=; b=DTUR+vywJyKUJvCY8X//c1tLrDD4grK2B7tfTKFDjHoNibvCLaNyHgL9bFtFAeAjo0vKU9 Q5/W0riI9jLcLnFm9fPmW1m2kANwgz1E2YObgVdbK828p7wuIDgMojYjUg1FCS10yelc1r rDM29ZaFjKwi+BvGIaE1lk/DVpQUDGs= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=none; spf=none (imf24.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678290974; a=rsa-sha256; cv=none; b=fhB1Es2JtVnvAtII5AzYd8jJORFW7RG+NXp+d+q/FU70k6WdYiHmu14MjFB0Zd76zFd3ER b75P0t03gSz6hsl5386pS5HaDMzzT4NCRVFr5tmXc+hvDP8WxZdkH8fnZyKvTGo3s8gxef BU+1rp1sUpKMg0+7IPw7Kkft3FJJyJU= Received: by verein.lst.de (Postfix, from userid 2407) id 4D71F67373; Wed, 8 Mar 2023 16:56:09 +0100 (CET) Date: Wed, 8 Mar 2023 16:56:09 +0100 From: Christoph Hellwig To: David Howells Cc: Miklos Szeredi , Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard , linux-unionfs@vger.kernel.org Subject: Re: [PATCH v16 03/13] overlayfs: Implement splice-read Message-ID: <20230308155609.GA21508@lst.de> References: <20230308143754.1976726-1-dhowells@redhat.com> <20230308143754.1976726-4-dhowells@redhat.com> <2011735.1678290876@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2011735.1678290876@warthog.procyon.org.uk> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 10161180017 X-Stat-Signature: 8opf3qj86umpepzu8spn4e7j9zofkd9y X-Rspam-User: X-HE-Tag: 1678290973-734371 X-HE-Meta: U2FsdGVkX1+sYkNXT2x5g1W0tMKTbLa4Vs3Ar5KB5tr2qe/FvSIvay98V7YynZVWI6LXiyUcm4CsZnR2Mz7M+kEqC9h9nzfX9oKteqTmu0tKFwXbL1/qGNdm9DIJoTc8xyUV+jYFzMyXwuDFBgw0uwqJogPYVfsPkFLZEbhwNbXUwfhG8qI7aB7fVmYDfP4lq9Eh7PZ58SNyom/81AJUmKnPIuKuH5detvRBeRu+4Lbmm2khDP+EIF8kEOjoAquitdH+Wj5UgccZyeAhbczMWq/lebIJ9EDGMO4MPTPaQXoiSWeBNH2ZteMC/X5MSkJwC5+B6Hx6z3GzKF7+d5Y+ds41wvN8y89OiQlhVZQ3aS/AmbfYMYyayGuX+Y8vkFYOPnnfO44pwb5oRwLCbxAenO0KTZEc1+4y3ZvQfclSM9AL3Hmt6dLrmPuOSl7FTlguFdlHrhiNemgooyM9AENYUJl1Zs97M3pEiIVSjlOJzHbVXLb1nhXosUy5wE1BEnvjr6TV3+6QHR6wjfUGLVDhLZJQQYEKO7EBMkP2LCHo68bHiR157o2hhgcCOyX3R+ey/z2HrxVIo+dic6WH1+Ftv3hUQrCvO0+X0FAh/1Bl8Sp0ckkxwEQBvblLECGAd0Shm6DgL2Tvgj2nQb8z/yQTOLpLC/7tTkt4XjggoBjEudG9fmMdbWOh7cC1hIlCrdJDFDOLrzM2/YLgXVFRfAFMEKsOFQnU+RF1IZZj7NABhKlPS5VVKsGelpazyJLh+EISF6l/aZwE9zerFZJi1kz/efzU56jxd8Fju0tzGR9LJmjKbYpQlhOjyK2Q/9w9ekvNKWBcj7Rf2j7Dwzh4RAQhLY2KOJv34dp3Rk6/bgBHp7FHnR/LWbRwE8d8rhrTlKe6pRuuENoP9RlQH4Aj+Tlpbhz69jGpttW1R7uDh+eCiFoEOKFRJkDt9+l6jEXKOHwPRneeByp0bCueIXBkAPd XnTxf6nw Q4zDy8tERcrSx80MsP9mU04GWZgN8LwhNX3xoXl9+SgNs8K7EqQbMbW3lFHoDVJMrvbitdh27LH4MJmk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 08, 2023 at 03:54:36PM +0000, David Howells wrote: > Using do_splice_to() as a helper is probably a good idea, though both Willy > and Christoph seem to dislike it. That's not true. What I'm fundamentlly against is pointless wrappers like the call_* that add no value. do_splice_to adds useful checks, so if properly named and documented, I'm absolutely in favour.