From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8595CC64EC4 for ; Wed, 8 Mar 2023 14:43:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E821280002; Wed, 8 Mar 2023 09:43:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 197A5280001; Wed, 8 Mar 2023 09:43:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 087B1280002; Wed, 8 Mar 2023 09:43:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id ED4D9280001 for ; Wed, 8 Mar 2023 09:43:49 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CFDDD1A0108 for ; Wed, 8 Mar 2023 14:43:49 +0000 (UTC) X-FDA: 80546000178.30.257BCC3 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf08.hostedemail.com (Postfix) with ESMTP id D7A6C160015 for ; Wed, 8 Mar 2023 14:43:47 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=none; spf=none (imf08.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678286628; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P8LRoD6p7gETYAipDCWy0eYjslkugqZruW6DSscKUSI=; b=mGDYSgN5HFdnZq5+iwEQG8y2N6tdpqy0FVcbtj+8wSE6Ig+ecTRruKScX+oHS398IvCVqU FHQnIgfTi9jbZIhqPudBQpQ2ykvJYxJL0SJdmM/5UwEZXDdCJGabwXWn/Ftf2eQnBFlBEI 3Q5d6rMrL1BA7oIOH8vEYv51xRTOosA= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=none; spf=none (imf08.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678286628; a=rsa-sha256; cv=none; b=JEm402KUPvo7+J8W+SIUaxBoMn1S4U6WsD2Je4/2BKYnKXprixxR/eWzZFz0NRCooMiYLQ ntJgt5oHkZE6IDwZVdwzZPN+ZzoWM98T/ATTz/kfHOn1yCIhC3wH/4KwG+BLeHOmwZyru1 yMFxaz75aYVDb9V0upcVt8LmhZ2Tn2g= Received: by verein.lst.de (Postfix, from userid 2407) id 8740367373; Wed, 8 Mar 2023 15:43:43 +0100 (CET) Date: Wed, 8 Mar 2023 15:43:43 +0100 From: Christoph Hellwig To: Danilo Krummrich Cc: Vlastimil Babka , "Liam R. Howlett" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, Christoph Hellwig Subject: Re: [PATCH] maple_tree: export symbol mas_preallocate() Message-ID: <20230308144343.GA16259@lst.de> References: <20230302011035.4928-1-dakr@redhat.com> <20230302015242.xi3y53okc4skmonn@revolver> <9abef101-3a9b-0bdd-7139-ced7d5e28ebe@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D7A6C160015 X-Stat-Signature: 4wxgag1h7jzm3tkqziftb185h66ceymq X-HE-Tag: 1678286627-987496 X-HE-Meta: U2FsdGVkX18ogp0XmS4E86j7QTlnpbCD+ElD3Mx31b53ZPHEq6OEPcQ4fZ02pxX27YcVSSAvkpyAb2c0aLjB6VL7MsEsi3n8YMcXYfm4LcfVYQlhX63xdnwoXTyT0J5x5A9sxAHmkBHgkVd8356mVjj0cDC5aWlExERWuxWpMzQuyWItALQH9d/P0GJoDjV2dqEUtaX2DcsrQDu1q9ryEmPgXgYcddGKBMbNAIaNbu7wrXI3XPZi0Jk+xyaUyZcE1Zb1qdf0elvggeu6lR6mUpNfwT3EU3PLckSxUuZfo36dHEYVMNEQ+cR/X1JHvnZpVoko0AeS97H/I78o7mDdeOAZyHb0v1iOyfxwiAVvSjIXYyEkllYY3dweg10/dQIjkYo2J42qNyYB+vu5nGV/iUiQTzqCPRH3imDYzhOIErpJxLPpxuSog2581OaUWWtlRUuQ9uC6bJdvjsz+YLziEosfgMU7a8p9S5ZMGOahn130seslt4yV+uKF+I+5wghSgTH+BgOFuaWcxUYfRNkk3XhoW9uYUPj+TAb0+mP+oWgq1zKGvAzuguyNSynafo0fhgo+vkQDzukDnKMqr0B5gwCgKbT2BC2ue7BWXGeHQGw7fQcNpUlUUlfskfaQ0wGHkA1vWxbUuXCOGCaDaZrOKVXMNj0d8Ah1BXsQ68CZ+DVUX3JpiCtYWziGqhIqiWq6DUvkPDAjCpTqS9cucOwt8VhE3PMigCpFVAUWnGHg4mjIrGYpW70axiRFkRC7TodtcCjTnrh0i1V6iCkZ/jnwGFuyruFYmgjnNV0/cJg428ID1b/4V61bQOHo2TNm5FqMRCNQo+MZVXn2MgNyGRn4QfwHm76fQKMaUaEn07K7kVtsCPlo+wdpGFktfCzyOOVCoz7W6M6CbC6XRUcGb5yIRz4j73d1x1j8r+/r18Ise5Fkv8ER91SBK9GVEPBw4jxHw1PdETb0SN9rnhJQS3o frT9sYyR zo04VF0eE29CRG2+FdqHpx387rok0p2m/2EokYpdysTE/04jyY7y7FLt7tMA5is1STttE9ALYJhkTA+f+HfIdIRnYWXwhIbUcprCg4T5dNR6hjE6hYZPXBqWp9qMVu57EiRxzwIy5qqIJK/s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 08, 2023 at 03:34:29PM +0100, Danilo Krummrich wrote: > On 3/8/23 11:59, Vlastimil Babka wrote: >> On 3/2/23 02:52, Liam R. Howlett wrote: >>> Thanks for the patch. This should indeed be exported. >>> >>> Reviewed-by: Liam R. Howlett >> >> What uses it? Don't we export only things used by in-kernel modules? > > mas_preallocate() is part of the maple tree's 'Advanced API'. All other > functions of this API are exported already. > > More specifically, e.g. mas_store_prealloc() is exported which doesn't make > a lot of sense without mas_preallocate() being available too. > > I don't think it is used outside of mm yet, but as a generic tree > implementation maple tree is pretty likely to be used in code built as > module, e.g. drivers. If anyone wants to use they can add the export as needed.