From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DD09C678D4 for ; Tue, 7 Mar 2023 18:00:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C35A6B0071; Tue, 7 Mar 2023 13:00:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6721C6B0073; Tue, 7 Mar 2023 13:00:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5616B280001; Tue, 7 Mar 2023 13:00:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 46A9A6B0071 for ; Tue, 7 Mar 2023 13:00:31 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EB5A31A0D62 for ; Tue, 7 Mar 2023 18:00:30 +0000 (UTC) X-FDA: 80542867020.09.DA57D89 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf11.hostedemail.com (Postfix) with ESMTP id C1ABD4003E for ; Tue, 7 Mar 2023 18:00:28 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rVF4MQ75; spf=pass (imf11.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678212029; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2LtUPNvCffTWAT9MlClBlxzqfhoj7e3LAcQkt5Rf6RU=; b=SaW3sfTPzSdXFm7Vb1TRNH1eokd2Ft2LeN4+VAiYt7kdaMsxxYsxWk/RYK1EfnRyWm2wQk 5iquzBGWAtKUVLum4B8R8uT726w1vZj9qSfpInNgDT58AwQiwUBAu8kM6ACzuuld15mGco qyBBhMwcV8ol8/9EF5GQc98U7iOi4U0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rVF4MQ75; spf=pass (imf11.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678212029; a=rsa-sha256; cv=none; b=3Fwe+SeYY/G37RxVW2ME1IlLO+g8ZvOpyPW9tNE+XODRqZtkFtkZbckcLdm6bWm27lEqx9 K5QkaUCamk73phmQcMcgSw2fgmUBb6NS39Caqsul3FpnjnWBVgWavW6eSd1CCplbOUJ2V9 AUEKvndOgkbbnxNonNDhkngK/olYYj0= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 149F3B819C7; Tue, 7 Mar 2023 18:00:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 403C1C433D2; Tue, 7 Mar 2023 18:00:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678212025; bh=UuWWRa7phftyu9Sfq9ZLAYegSNScAE2RjSDpFqcaEE8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rVF4MQ7556nts+aL/5Xxa+DCyrEuvFbDQHJCKafOaDtXVEuk2ezf3thG6t+5LUmpv rXYOHmhYdiRvTq8cNn2E29mpscSFYtvVd3ACXaYlTi6hBhxwI7nIgiDuxAdcUi8KJo D0TNvMXywjDHtS6MH9YgeVfmOf3SNwuxzNkul9rPZyJ/WzXuL9Dj9gJhEk6TXRvpI+ lGaAsWhidNDHWonS3g4fiCIuJjQNVtfSNFhz2sOFLAFkpdjA28cGeysP9dc0HANnc3 Goj3Mmw0F1SE7mZ5Jcw3huvSiSpfhRG8PwL5wiWQ34bqHRGBvzWh0eTujqoLrxjIHd vi+fZUZGAfJiw== From: SeongJae Park To: Kefeng Wang Cc: SeongJae Park , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, damon@lists.linux.dev Subject: Re: [PATCH v2 2/3] mm/damon/paddr: minor refactor of damon_pa_young() Date: Tue, 7 Mar 2023 18:00:23 +0000 Message-Id: <20230307180023.152415-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <174e75a4-f03c-a542-5f6a-651abb5dec58@huawei.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C1ABD4003E X-Stat-Signature: 9tkyha8xt3mowkccoz9wsxw6ipme5c8f X-Rspam-User: X-HE-Tag: 1678212028-606145 X-HE-Meta: U2FsdGVkX1+0/jizEPJcniQs44c3mxuDJA/9zQk0G7h/bMULtXpjaiEs8yaZKWqURLGJ2U5a6WBW5z8FnBeeCMqK8OTjCxMexKnx50Yem/jnQtlI2tc2gpxhQteSE0sXRbDjWuK8P6IWQuKxtSkVHl0+mgJrdmkvU840J/Yr0GbBA3Gn0Nsb+1m4foH2SegIQn6sDtQvvNOSlS33b6nrKOhL/AvKQqDlMptjoIW7mBAVxTJgbPPy6a9qSBfIdwKQb+KknIGqamZmcpg1getEpO4lbhCsndUVKDYQ3p+k5nyzoFrpornNl1KEHNIzkARfbKmBEn7/BQ8pTQc9DgvIYsxgh0HxnNvaxwuPHjkPM/xtDXvDGSx7zvmwBf209qtt/19rNBggJjrskfqR30W5gtbY0/dfVNhBOZuQmvkMeartXJ3aQHDnjhJ1ybarpFoEV3WMyw3cotvYCjD5+PGgmHJai4ufjkB8f9LWN080jVX17iJMvTXiLxR5j5kDcWfwLyGwTIpjlVOBftZor2wVgfQ66gY768v11lIpxXsdrYrxLRWhdf4CF437biiNLyKmJ9DtZyt/MMd0++Dd7NS1uj8P2H0bnIicNzV/VvnkvtWiPT33sAmRn0m6/l73D/WZHmbJXQep+YwFMq+1E1La/qNU0WnOLm4mEJgI6cW5zJEw2PjdVRuKnDr4Tfx/C7EZHcIHqD7SjCzWhWegSXcmpfHRsERyk7k2ZDebzaz/Wr0M67iTCGkJAbEhM1ubhvMpCzIpMreMKk4HkB590Db9HFxMm8lPAsxAREf7KqJNpxrkQKcrncYb5O8dH9OdAeln4f2ZM0I6uIAQZUy/VNKB4K2y9vD3iZEN2bVUIO8HB6806uOr8ik4oQAzS43d9pXB+BNrsQfDbGpGLctWD8/91JjApJ8tZh9A+Bsvu08uz3j9mgVPfSAFfUzcZYw4ehoZM4Hg5yzPSkbK+fhsjTZ RnZmRAzQ d5ExMr8qzTYYum1l4p900M87FYionuolNhrWgcb14pUftYnkBzXhZLra+dNh9GKuA4/mty3jfYA+oPIPql7i0pTAbZB9aslSALrvcJtRZXsg7uDZQwCR0tBtZ2qHI6YOSeZ06mZKim+8bIWjjULxeS3TsGau4TpGQiuY9k4SwohQaJNEq4k3xZ+TFtJPLkIdc/kKRuLqlto9GfIa38NM306AvIO9r9JK4QpMTxpfEfvPt0KfXNFksdMdswQIxepJJ9DWut0VEHU9AG+7wylIzMGk4MH5dgBu1h/Kqp6YwUnMdBn482qSnvhTyc/yZ75byfLOOTx1BhF0Y5+8RNYVDu4/KNf491i5VbVbv6dzcwtyyhHi7gbb/5noRypAFOP8mxp0fsBzZJ9THMMJnjPoXe74IeQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 7 Mar 2023 09:22:33 +0800 Kefeng Wang wrote: > > > On 2023/3/7 5:27, SeongJae Park wrote: > > Hi Kefeng, > > > > On Mon, 6 Mar 2023 09:56:49 +0800 Kefeng Wang wrote: > > > >> > >> > >> On 2023/3/6 9:10, Kefeng Wang wrote: > >>> > >>> > >>> On 2023/3/4 2:39, SeongJae Park wrote: > >>>> Hi Kefeng, > >>>> > >>>> On Fri, 3 Mar 2023 16:43:42 +0800 Kefeng Wang > >>>> wrote: > >>>> > >>>>> Omit three lines by unified folio_put(), and make code more clear. > >>>>> > >>>>> Signed-off-by: Kefeng Wang > >>>>> --- > >>>>> mm/damon/paddr.c | 11 ++++------- > >>>>> 1 file changed, 4 insertions(+), 7 deletions(-) > >>>>> > >>>>> diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c > >>>>> index 3fda00a0f786..2ef9db0189ca 100644 > >>>>> --- a/mm/damon/paddr.c > >>>>> +++ b/mm/damon/paddr.c > >>>>> @@ -130,24 +130,21 @@ static bool damon_pa_young(unsigned long paddr, > >>>>> unsigned long *folio_sz) > >>>>> accessed = false; > >>>>> else > >>>>> accessed = true; > >>>>> - folio_put(folio); > >>>>> goto out; > >>>> > >>>> Because you moved 'out' label to not include *folio_sz setting, > >>>> folio_sz will > >>>> not set in this case. It should be set. > >>> oh, it should be fixed. > >>>> > >>>>> } > >>>>> need_lock = !folio_test_anon(folio) || folio_test_ksm(folio); > >>>>> - if (need_lock && !folio_trylock(folio)) { > >>>>> - folio_put(folio); > >>>>> - return false; > >>>>> - } > >> > >> Hi SJ, apart from above issue, it looks that this branch need the > >> folio_size() setting, right? > > > > folio_sz is effectively used by caller of damon_pa_young() only if this > > function returns true, so this branch doesn't need to set folio_sz. > > __damon_pa_check_access() store last_addr, last_accessed and > last_folio_sz, even damon_pa_young() return false, the following check > still use last_folio_sz, > > ALIGN_DOWN(last_addr, last_folio_sz) == ALIGN_DOWN(r->sampling_addr, > last_folio_sz) > > but last_folio_sz is not up to date, so I think it need to update, and > update last_folio_sz is harmless, which could let's unify the return > path, correct me if I am wrong. Ah, you're right. Thank you for kind explanation. I was out of my mind for some reason. Maybe we could just do 'goto out' in the branch. Thanks, SJ