From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A56DC678D4 for ; Tue, 7 Mar 2023 10:33:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 099586B0071; Tue, 7 Mar 2023 05:33:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0490B6B0072; Tue, 7 Mar 2023 05:33:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E533E6B0073; Tue, 7 Mar 2023 05:33:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D373C6B0071 for ; Tue, 7 Mar 2023 05:33:04 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4E5161C5524 for ; Tue, 7 Mar 2023 10:33:04 +0000 (UTC) X-FDA: 80541739488.26.00675E9 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf20.hostedemail.com (Postfix) with ESMTP id 0FB401C0016 for ; Tue, 7 Mar 2023 10:32:57 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=alien8.de header.s=dkim header.b=L1XBCtD2; dmarc=temperror reason="server fail" header.from=alien8.de (policy=temperror); spf=temperror (imf20.hostedemail.com: error in processing during lookup of bp@alien8.de: DNS error) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678185182; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TSaRNnuYPMpqfKbVyvY5NfwUuBAd5KNTO4zFjqwOrxs=; b=G3434S+LpEtFo00zoWpPuYno5/BFmHKyYPj+AOG0LaiwCbMXeYRORR74jIoRWwlcXKaezl 0B+gYipkY/F/AGQ0ToKpGB72kAzF23LtD3T8BICegoZ2mIVTPLB5G/SYeLqqHz0yVJqyaT ZWjRceDcO63a4Kyb6Z2mqq1BRg8OdzQ= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=alien8.de header.s=dkim header.b=L1XBCtD2; dmarc=temperror reason="server fail" header.from=alien8.de (policy=temperror); spf=temperror (imf20.hostedemail.com: error in processing during lookup of bp@alien8.de: DNS error) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678185182; a=rsa-sha256; cv=none; b=PUkz/6nA8bNa0DDkgy2v56YFJdG1rTZGdtRVMu+SzzkbJ6rktgTuMrDXd7h14tqt0equ93 9sCqYetCd7OdcehXfyTc+CnDKiQ9CTBQcooDBzpa1qEhvILTVYsttAxp1wNnwtyTZpmwEL valz/fUq+uVZcbbQcgNcEenb/gzDrmY= Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id D9B1F1EC0683; Tue, 7 Mar 2023 11:32:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1678185175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=TSaRNnuYPMpqfKbVyvY5NfwUuBAd5KNTO4zFjqwOrxs=; b=L1XBCtD23na6R3E13elS6V0ZP5T2POm9e9hiV/ka1IMvkPwbFMAaKSQRD70gxI+wvR11FF roVJC30ow7iteUYrsOIzCJ2K4IwqmiCNeCZ4S7YrnBe99Ta9WPZTuwVAKPjZAHFH6BfcSS dQ3+Z1erhtgZDIYxF6Y1uAhTxiZbhgc= Date: Tue, 7 Mar 2023 11:32:51 +0100 From: Borislav Petkov To: "Edgecombe, Rick P" Cc: "david@redhat.com" , "bsingharora@gmail.com" , "hpa@zytor.com" , "Syromiatnikov, Eugene" , "peterz@infradead.org" , "rdunlap@infradead.org" , "keescook@chromium.org" , "Yu, Yu-cheng" , "dave.hansen@linux.intel.com" , "kirill.shutemov@linux.intel.com" , "Eranian, Stephane" , "linux-mm@kvack.org" , "fweimer@redhat.com" , "nadav.amit@gmail.com" , "jannh@google.com" , "dethoma@microsoft.com" , "kcc@google.com" , "linux-arch@vger.kernel.org" , "pavel@ucw.cz" , "oleg@redhat.com" , "hjl.tools@gmail.com" , "Yang, Weijiang" , "Lutomirski, Andy" , "linux-doc@vger.kernel.org" , "arnd@arndb.de" , "tglx@linutronix.de" , "Schimpe, Christina" , "mike.kravetz@oracle.com" , "x86@kernel.org" , "akpm@linux-foundation.org" , "debug@rivosinc.com" , "jamorris@linux.microsoft.com" , "john.allen@amd.com" , "rppt@kernel.org" , "andrew.cooper3@citrix.com" , "mingo@redhat.com" , "corbet@lwn.net" , "linux-kernel@vger.kernel.org" , "linux-api@vger.kernel.org" , "gorcunov@gmail.com" Subject: Re: [PATCH v7 21/41] mm: Add guard pages around a shadow stack. Message-ID: <20230307103251.GAZAcS0zpon573Ox3N@fat_crate.local> References: <20230227222957.24501-1-rick.p.edgecombe@intel.com> <20230227222957.24501-22-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0FB401C0016 X-Stat-Signature: da7ibsjnjn9gku9dj33ad66ticwtgggd X-HE-Tag: 1678185177-968957 X-HE-Meta: U2FsdGVkX1/BahC56Junw8++7fhxvzVVI+Dqev8YNH+gDK7Q/VG+68laAF4NV+fFHYx73iPeS/hBbYHUOiYlCaCJr4MBi65spe/strg3MZwbJ5zflM/uWlhUiK9HIyUgzRQdE8D//ClH1+oPeG8g6JLatCB2dklY+bhbdIzk03287eAQiJwEkn+KFD6/Q0V4eAPAboG0EXohI/Ra9Ru8x9oqjEbOdi32+VXS5f1Ecj4M5QKbkaYzok76sP/C85H/EkvnY+oo2c1bCQe2hI33Nak26nGOTTBZA1lpUrF0vlU8KHaMURLTV0XiOhGhIFUB9c5x5WH0T5+obrUbCpyrlKoGj1PBpkwws+yLLq7zXVjLeQDkjZv5+GYdMxHUON3NSNAH2y28TsifsjdnN/B5Zc1yV/zqs8/nYxJ/LnIpj3zuFEQZkc2ZT0UeY9nr+7xP+CrP5+w2xMLLFXJBmqpQifyX8+D8B9C7Ne7ip9mylXTTCLOvAwJgn5voyxtC9psXGqQocYCtVwoNcuMrg5J1OXEPtE+kstfQG3XJZGTuNquiPT5lWs/3j0CWdJV6hSDz4myirrLPkNOkfkrtGkzc4gKUPNDqr21EIr6SQ43YOY/6TYleCiNdNqUG//0GaLQbORKl2FumWp4lpZkHvsthZoICPWHh/HqMWDO5C/346HTfArUT7OJV3NIcHK7+0/JZ4ZUiFrK4KszWqzjD5kVTIn1AhSAdtMV/peXiEh8b9L+SoPurkyJQDsQxrzaijPmKkrHgfIufXuEEEjYnZs24Y9CEP5HPIG0+3p57emc1lRBlIUqY2uSY04Fv4QDiBaXpD3YTVCmp4qUQ1D2S4T25qy3TxBUheZ6F7eovrWOvQ1hmuKzCKFfHz5k2bJRtmsSN4BLPujGpi2HDcJaLZB61utMN14rw2nPA2XhcpzFT4F35zBl2jShKWbO4VWXooD3p7i1OJxxszYQLpNOif+4 o2fiwJNs Zu0HZp6hxte9qUywer0C/hmgQZN9J/8d+HvgxStZ0Gy/dl6LKTEH5b/i5NaAtBzxRxSzexORlIIe7KBn8vkB6oi2ZDv2y6+fPLSkw1P9Ru5zpEtN7gVCYT7bDzJBD586d+Pzbt2exKn8WqBAJbRnPW9UbXDHodledQtJn8y+STHFpnZeyvV1xCX4dUNVLLfgRr002G2tjVvIelfXw8rm7+8I6LSuwG51t/OfUQK7zUBOhHTFYEuSqnkdmoe7B9UtIeibFkK8ldVCwkTQcm1seDb5ic1v7hJbzjeuGh+JunB9YTb0EcFadBBD6IPF2eYfkKYxmhujG+2QFDII= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 07, 2023 at 01:29:50AM +0000, Edgecombe, Rick P wrote: > On Mon, 2023-03-06 at 09:08 +0100, Borislav Petkov wrote: > > Just typos: > > All seem reasonable to me. Thanks. > > For using the log verbiage for the comment, it is quite big. Does > something like this seem reasonable? Yeah, it does. I wouldn't want to lose that explanation in a commit message. However, this special aspect pertains to the shstk implementation in x86 but the code is generic mm and such arch-specific comments are kinda unfitting there. I wonder if it would be better if you could stick that explanation somewhere in arch/x86/ and only refer to it in a short comment above VM_SHADOW_STACK check in stack_guard_start_gap()... Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette