From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D1E3C61DA4 for ; Tue, 7 Mar 2023 00:31:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E47576B0071; Mon, 6 Mar 2023 19:31:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DF7446B0072; Mon, 6 Mar 2023 19:31:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE59E280001; Mon, 6 Mar 2023 19:31:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BE8316B0071 for ; Mon, 6 Mar 2023 19:31:27 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7F10D403F2 for ; Tue, 7 Mar 2023 00:31:27 +0000 (UTC) X-FDA: 80540223414.22.0B6C696 Received: from r3-24.sinamail.sina.com.cn (r3-24.sinamail.sina.com.cn [202.108.3.24]) by imf27.hostedemail.com (Postfix) with ESMTP id C8B1C4000D for ; Tue, 7 Mar 2023 00:31:23 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf27.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.24 as permitted sender) smtp.mailfrom=hdanton@sina.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678149085; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lpuOGVjRVDx954DCDiY5xhmWbvUhkh2Z2UJSaX4jZkw=; b=w/aqefXT1rqOI6qxYks/IirVW3mP8BHwAY8ELev87qjSYnmjWYjBRMTXLo2HNqLkiOTDh1 xl8T09M/jMjr3cwL2PRMLiL45aJRjhTUEyU4R/2xmDk4eeRBfjVBPEv/EJ4YkEuFBx9ZGI fFzmQM2o3rNr74BqYpGAiN4u0BNcQwo= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf27.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.24 as permitted sender) smtp.mailfrom=hdanton@sina.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678149085; a=rsa-sha256; cv=none; b=XPp45XWCPzWQc5Gs34+WLW35ljxrqAg1WMOQeV3J3UnoLw1QIWC8srEn3hZEGL2pLQcydq pQOIudxcA/3/zZ092BCL5kxJq7xdVuFr7WvwqHWiZI60C6jJ8ghDUj5zZ0oKKwZL+RS8at 7WQU6Zn6f2aIyWqZR9ybRcStINLQYiU= Received: from unknown (HELO localhost.localdomain)([114.249.61.130]) by sina.com (172.16.97.23) with ESMTP id 640685C300028B4E; Tue, 7 Mar 2023 08:31:01 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 26237554920491 From: Hillf Danton To: Steven Rostedt Cc: John Stultz , LKML , Wei Wang , Midas Chien , "Chunhui Li (=?UTF-8?B?5p2O5pil6L6J?=)" , Kees Cook , Anton Vorontsov , "Guilherme G. Piccoli" , Tony Luck , linux-mm@kvack.org Subject: Re: [PATCH v2] pstore: Revert pmsg_lock back to a normal mutex Date: Tue, 7 Mar 2023 08:31:06 +0800 Message-Id: <20230307003106.1768-1-hdanton@sina.com> In-Reply-To: <20230306102844.1293adfa@gandalf.local.home> References: <20230302062741.483079-1-jstultz@google.com> <20230304031029.3037914-1-jstultz@google.com> <20230306010323.2909-1-hdanton@sina.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C8B1C4000D X-Stat-Signature: rqmi9mfi3raxdnx3qbuoftz8xar6j3ko X-HE-Tag: 1678149083-740374 X-HE-Meta: U2FsdGVkX1/QimzESzxNGNYobKOB2yoKN39IbtxsXS57ZE4KTfn1FMe7AQCLLqXcQfoq3H508Xw1B1YT1gAjCDdp2vZC9cv8BujsfkwyS6Yp4RX6IBu7BEvWJ2vQbK1mxoY/7U9rh0l0yTB9/3WIz/BEUC3oLUOOLILxyhXNHRnOn2Nz0Y1+bA52CHPd+7gh3TWqn1wjQoTNBGCy1hcxbAtphPHHLco0+/56MhzcD/ruBsnKxCgY/5karcB2Ko9n/6gkd6EMRglBs6SsPbBE2azIizs+eOTNPL+lFmViTpXsansHy1wmotxDmFf8fewu9NuXjUCsrXFqzvJ3YsQlblA018YzP8mJMM/0kPSgXIws90u7OWwxKNKmQWl0Uqqpeke6lPLJGMQ7cDYEyHplcFFz4YUAdY3xn1hdH72ca99anq9i5fXZPlmsq1d58J+lMrBnJD7uhK9T+6+9c6cmO3kH6/pX7dnbANoKCgtMH9Zcu5l32ow5zjMK/WwbZOvnqXrRm83B8OzAM+CPmeLBmBH2d5EBKa/mK4cBekc0Y9eAuVOcZIBpqTUXNWwMzOJENJ5LLHQr3UUGjqKiZ+eJ5d0ln7e2Wjbz6vFJpaofeQw0zalRY8mEgk2nUX9zOYev+FILPosF7j/w/0Tuib5qyAniieBrAnpqseu2GJ1UuV1aMLdAnnwkh0DqHDnT+Y7m5lTUNLdLIc7RXWZo0QXrcwbV0oAXJdep9X1QaOucxvW5u4vVJk5UQ5Y/NKeH5M5/qDWi2iHGuqVWpyn3DiH1xIs2ZxjKJ0hG0CCVdwat08End+X4wX/S7xTEFgKb43+4kmSFZVkQe3h80FEnxmxi8ODB9gzZ30UDQCSUuskim3U2Q3OeUsNLSXm3yK4XnOwvjMD+/vRclNU3zbIQf0+tUz2djvN6WOp86vwKSG1I/bbQBlDXw22Zg0w6EpyGQNTgFw1eGYLi14e5wduweBU p/uLfCQ/ HdMFy5Ip5dNbSeEjzE+F6o3nWrQcGhRTohGUB23SiXNaVYVSU07v4qwWQCVi4nbTGOMPPNEKDzWXXrNrREz5F40ykejXGFVAHIjRYQJ83hQ4/b9r3749GYBJ53DvWdjEV7XR/BKVGklBu3wKTRMlLfvaNj7kbovMfRA4XyeoBXrKpLb6ntQ4H5ghlxQuiw0QiR2fsntNcOlq3Kqcc6Ah1URgFj2t5/DQBjmg7xW/s8UqbmozBmAkcpA2VQD98HADwtTWD+hERF9HGFIk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.025346, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 6 Mar 2023 10:28:44 -0500 Steven Rostedt > On Mon, 6 Mar 2023 09:03:23 +0800 Hillf Danton wrote: > > > > PS what sense made by spinning on owner until need_resched() with preempt > > disabled in the non-rt context? > > Not sure what the question you have here is? If need_resched() is set, we > want to schedule out. Given the critical section under mutex could be preempted, what is hard to understand is the wakeup of a ten-minute sleeper could not preempt a nice-10 mutex spinner for instance.