From: Steven Rostedt <rostedt@goodmis.org>
To: Hillf Danton <hdanton@sina.com>
Cc: "John Stultz" <jstultz@google.com>,
LKML <linux-kernel@vger.kernel.org>, "Wei Wang" <wvw@google.com>,
"Midas Chien" <midaschieh@google.com>,
"Chunhui Li (李春辉)" <chunhui.li@mediatek.com>,
"Kees Cook" <keescook@chromium.org>,
"Anton Vorontsov" <anton@enomsg.org>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
"Tony Luck" <tony.luck@intel.com>,
linux-mm@kvack.org
Subject: Re: [PATCH v2] pstore: Revert pmsg_lock back to a normal mutex
Date: Mon, 6 Mar 2023 20:58:18 -0500 [thread overview]
Message-ID: <20230306205818.5a2bc51a@gandalf.local.home> (raw)
In-Reply-To: <20230307003106.1768-1-hdanton@sina.com>
On Tue, 7 Mar 2023 08:31:06 +0800
Hillf Danton <hdanton@sina.com> wrote:
> On Mon, 6 Mar 2023 10:28:44 -0500 Steven Rostedt <rostedt@goodmis.org>
> > On Mon, 6 Mar 2023 09:03:23 +0800 Hillf Danton <hdanton@sina.com> wrote:
> > >
> > > PS what sense made by spinning on owner until need_resched() with preempt
> > > disabled in the non-rt context?
> >
> > Not sure what the question you have here is? If need_resched() is set, we
> > want to schedule out.
>
> Given the critical section under mutex could be preempted, what is hard to
> understand is the wakeup of a ten-minute sleeper could not preempt a nice-10
> mutex spinner for instance.
But it can. Most wakeups are done by interrupts or softirqs. Both of which
will happen even if a task is running with preemption disabled.
-- Steve
prev parent reply other threads:[~2023-03-07 1:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230302062741.483079-1-jstultz@google.com>
[not found] ` <20230304031029.3037914-1-jstultz@google.com>
[not found] ` <20230305113632.26de0a4d@gandalf.local.home>
2023-03-06 1:03 ` Hillf Danton
2023-03-06 15:28 ` Steven Rostedt
2023-03-07 0:31 ` Hillf Danton
2023-03-07 1:58 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230306205818.5a2bc51a@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=anton@enomsg.org \
--cc=chunhui.li@mediatek.com \
--cc=gpiccoli@igalia.com \
--cc=hdanton@sina.com \
--cc=jstultz@google.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=midaschieh@google.com \
--cc=tony.luck@intel.com \
--cc=wvw@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox