From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A92BC61DA4 for ; Mon, 6 Mar 2023 18:31:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 040CE280002; Mon, 6 Mar 2023 13:31:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F3305280001; Mon, 6 Mar 2023 13:31:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFC74280002; Mon, 6 Mar 2023 13:31:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CC345280001 for ; Mon, 6 Mar 2023 13:31:26 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 984D7140C49 for ; Mon, 6 Mar 2023 18:31:26 +0000 (UTC) X-FDA: 80539316172.11.A11C6B0 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf24.hostedemail.com (Postfix) with ESMTP id 99D8E18001B for ; Mon, 6 Mar 2023 18:31:24 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=d6W3uSP4; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of zokeefe@google.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=zokeefe@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678127484; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Iizvtg68lyx86Kw9qy0rXsUsJPZUaHrLw5tLos/TKTM=; b=tus6o24avUVuUzGAARelqOgdQcR1XkldUguhfK/z1DAmruS92/0SVoNDf30T1JvE4eS8xy CIYHMs+LtfzhAuiIsDR19SXDo99n71Cv64P7TemnRkXjML1hkJlzXfpYuUfIMbo7gb68Dj +aO8skBhbgfgammb5Np0NhbuaVx1XHA= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=d6W3uSP4; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of zokeefe@google.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=zokeefe@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678127484; a=rsa-sha256; cv=none; b=5DYhYhooU09yMuy4ZlJKKoKqiKSXTiUli+gFGPklUnp3tjKbrdYcMDHQSymshTegoqD4GH 3P5DpsxPhtDA4I6dAANs93Y+GUHGHxxlNzjWMnzcxluQpQJw3rs+12JaphaSf+xhxzanhg fql92kIKE8J42bansyvXhFenrjedTgs= Received: by mail-pl1-f169.google.com with SMTP id p6so11495067plf.0 for ; Mon, 06 Mar 2023 10:31:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1678127483; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Iizvtg68lyx86Kw9qy0rXsUsJPZUaHrLw5tLos/TKTM=; b=d6W3uSP4iBw3OI2cevFx2OYlEKgarZeDqsRFR0NhhlohwME9gwJEG3Mx8E4NVsF5VP WrTyb488Sl1W2AOCT8GG1jtVTBVivzP5hzi5DslbpGjrnpTkf6K4n8n5pWZ48qCH9Ejn f5J0o9MB/KoFNmyKHsCzkhUIK/4jt4eto18kJlpVMPqWVerWzwk8v9uWa6A6TpgDIj2S mYE1w1QkxveDdbG4Nb8zQzGoxSXCNFR6Fn6SXvrpjqTArX/H/vshlGP69KJZpO7wEcqQ g3NJntBLCBR30hMz1iV2EdRme2bfZJVPrwuY/MIN/SDH2BqCVFXd1rT9nqEUTT5NXHXw pjFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678127483; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Iizvtg68lyx86Kw9qy0rXsUsJPZUaHrLw5tLos/TKTM=; b=PHnuzJkWo+S/VpWS7f39ingYDDKX6IKrAWVJvHniJp0CwyDAULRna+bT1Ltcmrqrmu zj3u/R1FcscTO3f1y0j45BMnbX+6SQxRSH4t2QpKWR0LK2hW1Mg7INT5nXeDllhvMkdo N9eCKzS5ZgqX7V/xaf7mxsMFbuGqxeHrsKaC/9rLejwE6vWQYO2ElTe4krGNLtlechNX kmujUfSdnZSFHVogoXIj14+pLUlR04I4h5OkjdcbrgwM+l6X++ru3BLMc3d4cipuKSXU drFh2/uOE0Ha2VyXe9TqpcHvshR0GcYAx7qGFwXNZ4tHvnQwOTh97n+m5e4bKpMoqmBt 5Rvw== X-Gm-Message-State: AO0yUKVq2mTejomm/B5V1nuBdPtfBObClw5PtHoFIuA4EJshjoJJv2Um bYmg3j6x6CQcGKbpExTn+KxR3A== X-Google-Smtp-Source: AK7set/9nLGBsaVaVqUCwr4yTobByniqdrZzZpR0yJ13wdZ24m7Lzy6HSWTyA1Jkij4pbT2nvOouWw== X-Received: by 2002:a17:903:6cb:b0:198:af50:e4e6 with SMTP id kj11-20020a17090306cb00b00198af50e4e6mr848900plb.12.1678127483181; Mon, 06 Mar 2023 10:31:23 -0800 (PST) Received: from google.com (33.5.83.34.bc.googleusercontent.com. [34.83.5.33]) by smtp.gmail.com with ESMTPSA id q26-20020a62ae1a000000b0061998311344sm4392559pff.211.2023.03.06.10.31.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Mar 2023 10:31:22 -0800 (PST) Date: Mon, 6 Mar 2023 10:31:19 -0800 From: Zach O'Keefe To: Zi Yan Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan Subject: Re: [PATCH] selftests/mm: fix split huge page tests Message-ID: <20230306183119.igudzgqj5bemqkox@google.com> References: <20230306160907.16804-1-zi.yan@sent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230306160907.16804-1-zi.yan@sent.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 99D8E18001B X-Stat-Signature: j96uyse9tjomp6fdjw35nc1takdgy647 X-HE-Tag: 1678127484-825353 X-HE-Meta: U2FsdGVkX1+GFx+nm7mu6pSR0XvQ9kgZsi3dR8NyIvsWEwbIpyPbd0Buk7VW9XjCTphGY8oCTyUoruHWg22wk/yIKCroHzswchN6jXc3HHW0FqxEPNZO/YxF8Z+bO/ysY79//dVG2JTcZ4ev8yocLyeAvTCCEptJNT2hYX3EwkzWzLCwf7pRa4Dw97w/v72TBovKJG0zB9stT7zeBtUBRzOyFID+ZXCiMHKynDrLMZTnIOKc9LS4KyjDWtt96p5XGnta+7GPAZ0AicQu3gleeHAhQ7hTapLQOxSxnju4wQdUi5hytdmNdXsMogNtRPMGyeXXCzzXGr0aT1gCYqlK5FWFQLfoh931U4KJAwShvr/or4lwLBuZ4pFBqW5hNnBqxC8Y5YYUrPRYX+gGjQIHzFR4lIh7GKHNcmgwvgGJ3RbrE8EMJBa30NzJmvQWe+XIkVfXFj7FYRDG1HAgEH2SiZGiVaj2Q/i5H1x/k/O4ig8DvkDbsd+NODYhyJyZqo7PrarUAJ9pEjJgxnEqJT3zIgAZFAy/t1agUNJBIsNl1P24JKoVdOmtU19J1nFEEtHMH1frVXF01C/u/9IlcMoG/wW8NCa+UoVjv5pR4bYlhilLGvCCS2B45O/SeZ7VI9x10ZqcPxAbYV4+KZnd8E5L6HO31zPXgQgru7HrgAQQMxuEt38/Ctkv9JZFy4fgKhplDy0ZA2E8gM43LdNgL6a0ZK7///2GbF4GF5Z+bEMzRpfD+iWIXTZkr+LwHMpUC9m5zxgasg46/nq/j8g8sy022A4mTAR3rkvN10EMWrnQA0GqERV+8yXA7bbqtt/a5SWMK0HVW2cNfvV1UW2RcbjJLg5xLNunS0dn9BKq7TM9hNcTqAMBl55/1hmvoeE+sXHPXAvKMvygBh+kPCNx8wubRaf3IwKlYhDFIwZaMuY0xElQtmV1MQxLgUjl4Sh7yPOJdmP0BdD96CYFDGQZn6d jg0XeSsr hGbgs4eSPDhA3DsRxNBwe5UtfrMM3OhP1fOT01hgwv9gE/R8lXDG4GJlneb4FTAjLXrLDiLR3fkZa45MK9cvVQj6W75nGZANJpb7vd1W/L4oVoLURK2zReODi7FEAqdTWrd8qP7KMj1Mzw318IKPmyhRhBJ0U9rXA8raYV0NFUaj0Dx33zNzCkIxmUxgSIT1Ws58NQRmYgJTvcTcDDsP+ib0rty3Dqj3mu07qdCSznBKR0XPksLUfe3LrhMo10nodZSVfx2BFBSI4LgjbEwZ5LREic+e65Nwa312hU49LLKbQHJVYvnwepxpcG7RDKh6DynnylXGPW6FTrI+1y1py3cE6Y9nD4Z2zp45KN9Wta61bzgjo/5MZ5Oz7mDFDHtCYNsIY9O5x6t3zVQM5+rgkvdIxVW2WG4yk4XmcOZRMyn7q0lc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mar 06 11:09, Zi Yan wrote: > From: Zi Yan > > Fixed two inputs to check_anon_huge() and one if condition, so the tests > work as expected. > > Fixes: c07c343cda8e ("selftests/vm: dedup THP helpers") > Signed-off-by: Zi Yan > Cc: Zach O'Keefe > --- > tools/testing/selftests/mm/split_huge_page_test.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/mm/split_huge_page_test.c b/tools/testing/selftests/mm/split_huge_page_test.c > index 76e1c36dd9e5..b8558c7f1a39 100644 > --- a/tools/testing/selftests/mm/split_huge_page_test.c > +++ b/tools/testing/selftests/mm/split_huge_page_test.c > @@ -106,7 +106,7 @@ void split_pmd_thp(void) > for (i = 0; i < len; i++) > one_page[i] = (char)i; > > - if (!check_huge_anon(one_page, 1, pmd_pagesize)) { > + if (!check_huge_anon(one_page, 4, pmd_pagesize)) { > printf("No THP is allocated\n"); > exit(EXIT_FAILURE); > } > @@ -122,7 +122,7 @@ void split_pmd_thp(void) > } > > > - if (check_huge_anon(one_page, 0, pmd_pagesize)) { > + if (!check_huge_anon(one_page, 0, pmd_pagesize)) { > printf("Still AnonHugePages not split\n"); > exit(EXIT_FAILURE); > } > @@ -169,7 +169,7 @@ void split_pte_mapped_thp(void) > for (i = 0; i < len; i++) > one_page[i] = (char)i; > > - if (!check_huge_anon(one_page, 1, pmd_pagesize)) { > + if (!check_huge_anon(one_page, 4, pmd_pagesize)) { > printf("No THP is allocated\n"); > exit(EXIT_FAILURE); > } > -- > 2.39.2 > Thanks Zi -- I had this in my TODO-log, but was slow to get it it -- apologies for the clearly buggy code, and thanks for the cleanup. I've ran these tests to confirm (as I should have previously), and it all looks good. Can have either my Reviewed-by: Zach O'Keefe Tested-by: Zach O'Keefe I don't know which is more appropriate. Best, Zach