From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F8E0C64EC4 for ; Mon, 6 Mar 2023 18:17:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C30796B0075; Mon, 6 Mar 2023 13:17:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BE03C280001; Mon, 6 Mar 2023 13:17:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA7CA6B007B; Mon, 6 Mar 2023 13:17:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 973766B0075 for ; Mon, 6 Mar 2023 13:17:02 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 71E0940491 for ; Mon, 6 Mar 2023 18:17:02 +0000 (UTC) X-FDA: 80539279884.27.F09ADF3 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf05.hostedemail.com (Postfix) with ESMTP id 5D1FF100009 for ; Mon, 6 Mar 2023 18:16:57 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b=ehbCHpwq; spf=pass (imf05.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678126620; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KEn/bkUTyalqJG9ZpefG0CIHtAi6+t0RHXyrbGtbP2g=; b=V1IsRqJ9DbemoB5UHeYx+YI0D6R4M7rC9JusU7e+XJB1RT2ZPHKmcP9eLen1CzcpilOzfU tw2g6IBbN2ym4tOrHX8iSaQFAS9gKDhCfTmh/RnW3tFQZIYjFCBmSW0gTGB+58qyftCC9X lUBXMuTZxiDOQam6Of3nFEZ6T0nIA98= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b=ehbCHpwq; spf=pass (imf05.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678126620; a=rsa-sha256; cv=none; b=jaCqNsctlTDV7cv0QWODdi8CwxiZ3G2ZG1SHYSQsgURvv9RCixHq13BnRhKozuQFrrUZuI pcbdSKQxw9DVCOaMNVCyFt8DGTHs2i7jl2kpOhPZsABhSkgKgt7zB74jXjldmp+yFbxcfi qrCK4Bt02jVDSl2UFZWdbRzTjQtMxz0= Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id CA80D1EC04F0; Mon, 6 Mar 2023 19:16:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1678126615; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=KEn/bkUTyalqJG9ZpefG0CIHtAi6+t0RHXyrbGtbP2g=; b=ehbCHpwqHzV6mptlGefZ0+7syjRW/Z7m0Gfw9mmaY4P5op+UQRUSO2WXe4prxJAEZr0lMF oycliX6YxTbIDSnAEZBZ3f/5cwI0pJwZCDzK8zrLFN3WHYQ8Es2ZISqv88QM6o0rGoiTdp CmEpUiACjbz+0ISQfFpN1AmRrv0BSKs= Date: Mon, 6 Mar 2023 19:16:55 +0100 From: Borislav Petkov To: "Edgecombe, Rick P" Cc: "david@redhat.com" , "bsingharora@gmail.com" , "hpa@zytor.com" , "Syromiatnikov, Eugene" , "peterz@infradead.org" , "rdunlap@infradead.org" , "keescook@chromium.org" , "Yu, Yu-cheng" , "dave.hansen@linux.intel.com" , "kirill.shutemov@linux.intel.com" , "Eranian, Stephane" , "linux-mm@kvack.org" , "fweimer@redhat.com" , "nadav.amit@gmail.com" , "jannh@google.com" , "dethoma@microsoft.com" , "kcc@google.com" , "linux-arch@vger.kernel.org" , "pavel@ucw.cz" , "oleg@redhat.com" , "hjl.tools@gmail.com" , "Yang, Weijiang" , "Lutomirski, Andy" , "linux-doc@vger.kernel.org" , "arnd@arndb.de" , "tglx@linutronix.de" , "Schimpe, Christina" , "mike.kravetz@oracle.com" , "x86@kernel.org" , "akpm@linux-foundation.org" , "debug@rivosinc.com" , "jamorris@linux.microsoft.com" , "john.allen@amd.com" , "rppt@kernel.org" , "andrew.cooper3@citrix.com" , "mingo@redhat.com" , "corbet@lwn.net" , "linux-kernel@vger.kernel.org" , "linux-api@vger.kernel.org" , "gorcunov@gmail.com" Subject: Re: [PATCH v7 22/41] mm/mmap: Add shadow stack pages to memory accounting Message-ID: <20230306181655.GCZAYuF7uBaFtKke9j@fat_crate.local> References: <20230227222957.24501-1-rick.p.edgecombe@intel.com> <20230227222957.24501-23-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 5D1FF100009 X-Rspam-User: X-Stat-Signature: pdt14hyxpnjyk85d9w5bd4of7ku785dk X-HE-Tag: 1678126617-970496 X-HE-Meta: U2FsdGVkX18KxCaFmucaiDbw4O4gv6fEVxMGUuUDd7KuFgRU1dSIp3/rfPlol/lmmiVRruBs1vOBOTnFJbSOlIdnj/2j87LuY/oam9c075gYou0C4bLTRGrI4d/FGMfbp9QjnmNliwQ/FW0SjSGoGBPNtxbcTLxrT2BVLHJKWiM9/MNjX8EKdZjlNCZ+GrG7NrQQ13OJWrKPe+eJ51toSjPsG7lKwyOMrn7M5/SsUWspEM8OX6v01REf21ZtC3FEF0PUsZq/HKrKBzTUXkhP8UgxB5u87Sxz4qfX+1JI/sOp7BdwM+rZA3e15wglbYItpEiFjjOhoqgCzdSwj5Ehe09IYPQ3fHDnPQ/FLIZitVb/wXZA+nRBX2XoKUG5Kx57Ahg0D1bZ4PyxuqFYYHFNn7h8ASj1f2pVBYH7Sjhs8UdACcyj3rxj8Crn87NcMTg7en5U07iTCI5taWQjyT9LLzAvssexrxXkDWGKVZaeIV4tLdsoMw9ifp9Leg8DcTDXGxLEz1PhDeTkiPEgEajJ7F7boMPCSDf0dr6A+kuupsxVzclacBwV6JvcGCRpoXoUKX7vv+7Opeil89y9SAxfEJ19ySJW8xYwf+fYb7MoIuZvTx46YPCFxX1z7u6H9Vbt5z8efW6q1f4hQWDhyOwEmZGPsgkHa+ws3Mj3XA87XPiw2KyeOr+Fxwyj6gsIwYxTmMC/3MJrAWrPP3mzsDeZ7M7Ur0NwAQ/zdVWPtlkzSarYpFS/EpDqwO2ycukLScWfvc2YvOUOVLwVbeZk9QXgWDuSHO3MNa5hOM3wAqbtfyXU0U7+vv9JvV5hsndzaFokRkz9Ivsgi35Q6yFfmR0LPef5uesfXE6JiTJbGayMx7Cp/dtV4HeVtZrNNmiUafQTrRk9ewavYJ1L+iCRwagXoVOntbVSNqI6u7e+nPOlCZ/7Fdu34YmKAFIILy9MNR+YmFbqIfsK9BdFpqJ1gd/ c5dgP1Al U3DBnFMF+o1qYyEfDQtr7LVnOVlYsnwM2qs0WAOuyl570lVtkYMGYlF1EsswIVT17HSe2r3SY+SBTkRKsrPw6Ox5HkJf9harNKKCmnAGK1xpzdeso00HRDZjhKmzMfPtBIsxdnX5gCgpsjhTzpaQaN0rkZ6OJxMs6tF5sohAgrdFkC21VCogG2JKQDabVO9k5QKAkK7onKX/jtlLGGKfVpvNp5/MNKi6AQXQAaqzc88URFWS3Qs4VWONTVjEpQuI2VNQ7TvDxwWiLGqXdh0AjSC5It8XNDnBHjuAY2BLcL3xkTxhzBWWiRNCqnz0RWnpHAV+/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 06, 2023 at 06:11:32PM +0000, Edgecombe, Rick P wrote: > Before this version it was open coded, but David Hildenbrand suggested > this is_stack_mapping() solution. Should it be explained more, or just > dropped? Well, "adding a VM_SHADOW_STACK check in is_stack_mapping()" is what's in the diff already and it is kinda obvious. So why write what the patch does when one can simply look at the diff? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette