From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42C68C61DA4 for ; Mon, 6 Mar 2023 17:10:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 893BB6B0072; Mon, 6 Mar 2023 12:10:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 843CA6B0073; Mon, 6 Mar 2023 12:10:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 731C96B0074; Mon, 6 Mar 2023 12:10:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 670836B0072 for ; Mon, 6 Mar 2023 12:10:14 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9FD041206B4 for ; Mon, 6 Mar 2023 17:10:13 +0000 (UTC) X-FDA: 80539111506.29.DD56643 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf27.hostedemail.com (Postfix) with ESMTP id CBE074000D for ; Mon, 6 Mar 2023 17:10:11 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=K2yeJ73m; spf=pass (imf27.hostedemail.com: domain of brauner@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678122612; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QD9FWHYKU3psilSvIKDRi7MNHM/02p/K/b0uhnNdP30=; b=E7ov+7xLdwUWEcbKR6yzdbVXD4D2rHHXRKoCwE5jrw/vVqkZe64CobyZdaD+RLY3p3K7ld 7OkjAw7duR6zLkobimjSkdg6sK6WVVTVNcooo5ocB1qplfMOIrz/MNSWE+0yJ6wV5U58c5 D2AHKOcIblJggtsiL09oHSn3s/99sm4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=K2yeJ73m; spf=pass (imf27.hostedemail.com: domain of brauner@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678122612; a=rsa-sha256; cv=none; b=xSv60dhOuV8P8TosXNzTkrcrBVqsx4nM2tKmX3jKJqRlcYPLYKj815TvIrILX5BuVXXLco xkqjUx38F1gUaQGWZNduB77fdrkVff0UyNoPImCACMx8aj1PeqAt+NsW7tvMPMZHJ8x72l t9XJPEUUvwU/xhYxwHy9myfLXMpXUNg= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 72C89B80FE9; Mon, 6 Mar 2023 17:10:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6489C433EF; Mon, 6 Mar 2023 17:10:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678122608; bh=dz5CyE3yXjvIolQRfz3Ul+YWATCmkUS4k4JFSEnWwfw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K2yeJ73mYnQwNzeW4rqHF7Y+K12+AFhBxNkRMGiblVGDlf3mUdjz5EO53AiBB31LX Nv16PUlqC65cgm53mG0uXqgp8KA5y/4z7s4ae2bCePg5ImJtIaBiiX7IG1maahw5DX MoGCsjzzlQpxTTLzIAhJCzwhjlqSr4NHFG4LatWAlpDOn9cO4t0n9PvTAH9YUaSnax poLXQXabAQruPqshgXycp7sZVkEtM70S/WoeQ9SBj+yhyaOZ3qKc8X8RhbaB6ET3// g7GqrUiQ1iZMRGHgnE6pKI+VqmwC2s/bRk+LI/z8HEm6/6WAQToGl3DYuN2tYk3JRP MB+jxmIGZk7aA== Date: Mon, 6 Mar 2023 18:09:57 +0100 From: Christian Brauner To: Luis Chamberlain Cc: hughd@google.com, akpm@linux-foundation.org, willy@infradead.org, linux-mm@kvack.org, p.raghav@samsung.com, da.gomez@samsung.com, a.manzanares@samsung.com, dave@stgolabs.net, yosryahmed@google.com, keescook@chromium.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/6] tmpfs: add the option to disable swap Message-ID: <20230306170957.tk6pbx2ma3kb4qi4@wittgenstein> References: <20230302232758.888157-1-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230302232758.888157-1-mcgrof@kernel.org> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: CBE074000D X-Stat-Signature: 89crocxc6orrb1z3rqtty135kxukebmp X-Rspam-User: X-HE-Tag: 1678122611-797566 X-HE-Meta: U2FsdGVkX189ZxquZ+71lFD8+TAUWyMi6RnwBVutFajnq1GovnDoRVPcBMHyht3Wo/+DPCL2KOASV4vhzxqxlJEkqlSyB3EhRiHWUPSo3GE1AYaVrX1USS4WN8BKOGhATG7uH4s+wteulLZ9FxMkycCGHG+4XbCTulUrTE24a4mjmh1yW9WXnONYgHxjtwm2GC1W8GsnVJKX9h/bO3metiqAVc9kTO9XY991VLnvuzA7K1tiJ/OCWg+YiPVReh3BV7NwBdA0Va28nJvBr2PSHnroD6btNQnpaKQXtw116eG5oZmD5rfbi6JC0dCJqOryiHeyBaYA+xjBLyZULulaft/Wc7gIEyZbQJ65p/fKCXUmtblQgZMqQxnVVJrIrkEnPaT39HE0q6VX6QWhCJcAra5Vtmt77wfJXneRpnmbY+vv7DvcwitC2tmbepPhrrY9yXRfAq+7PkutbUjfLPCMam10k0En9MfcnllPvFUFqqL/gROwAu+ej8tkupwDwPbh0UeGVkfjMd/SnIIz37bFSBdfCN/3TrdTmyol6VNccUVDL836ZDzStUUxGUB906OKYgNfDgSWo4ASsyWprMmxzwERrrMJzxd/UU51TYZsgOZA8+7JfaUwCSEYoZPbndTIhQZuUe6gqmXbhcq0ag0AeVBwKBSGbWQ+1E4lnAsULqznZfKUTiF3dIyD/7/XtdSrDSwapsrTsKkktzujh/GDx4Lw3LsfnpjZP2RkqMbaaze1JZ1jKhWU0mwb0P20lq9nasxS4KLSso7YfddKCixg/w0eY1TzN5JIN+TrZAnjXZrjsfLEBoK9HrCD/R7Wv8GLvsNTCMJJlHxWxAdAwYpmVAVT40IkbyMc97qn7+1qAzE+O3dk+J0GJETTe5ooRDg5jabipPUjRukFhe+HTmvrdey6Tv2whnB6H2NqpPtYVVwDvm2LdPiTAZcWA5ydi9ddDKD6p7F0inLg2QdAhPh jRorghtn /UaRUmPTMwOTUQiEnTNqK489rCdVxbYx5dunaohY7N43+pmjgGSOrF6j4KCWb1Jr2B8Pdnf4ovd9Ad3uywWOwytMOwKOIrmjHUAnRkhCRfaaBDehyil/oTFvXLK9QLTmv+NiLIwISOFPtVIOC7TM6YHRGXgshckhdq8CKgM+ls20K3UhwQJbCGMkCeYKeibk+VDaES0apWZgfgdKZNOVSpK3KEr+dU/KfCTdXCN2dJDmUYwoq6jN38lwX3nIm0gyG59ShIepdw/Qnz3rRoY68lI0hqbs7TYVO6qTwER/5DoCX0hjcJdqcy4EqR0X16ifl0tJLTLJjURgVlgsoKqeay7oHp+XDC5wgPcH4TK5qhdorgb4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 02, 2023 at 03:27:52PM -0800, Luis Chamberlain wrote: > After a couple of RFCs I think this is ready for PATCH form. Review > is appreciated. Below the changes I also list the series of tests > I performed to verify correctness. In short you either create a fs > with swap or without, but if you can't change that option later. > If we really wanted to, we could work on accepting this change on > reconfigure (remount) but its not clear yet that is desirable so > for now keep things simple. > > Changes since last RFCv2: > > o Added Christian Brauner'd Acked-by for the noswap patch (the only > change in that patch is just the new shmem_show_options() change I > describe below). Sorry, didn't get around to the rest of the patches earlier. Not an mm expert but even the mm changes look straightforward to me so, Reviewed-by: Christian Brauner