From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 124A5C61DA4 for ; Mon, 6 Mar 2023 17:06:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E4396B0071; Mon, 6 Mar 2023 12:06:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 893BC280001; Mon, 6 Mar 2023 12:06:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75BC96B0073; Mon, 6 Mar 2023 12:06:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 65AB16B0071 for ; Mon, 6 Mar 2023 12:06:46 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 129468026C for ; Mon, 6 Mar 2023 17:06:46 +0000 (UTC) X-FDA: 80539102812.08.CDC1CD5 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf26.hostedemail.com (Postfix) with ESMTP id 56246140023 for ; Mon, 6 Mar 2023 17:06:44 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=f90ZNGNU; spf=pass (imf26.hostedemail.com: domain of brauner@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678122404; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AqOXUz+q1VjH18Be4HGz2i+R77xpfqWrnGc5MQZHITY=; b=L7Oah6jhKCf5T/0rdFlH7Y3nRiui3Lh5riCyb7n8C8y9K6PRxM1qpOPNVD/z3PAvfByqm5 fDztEhywuvkQR43D28YEJdAsjR6b1kcS/gZvCc9f15bnXM3eTUAsIOB43PBo/r3+FtXUMk gH3RD+BKtLKQCfXnUPLJ5ummn42biPc= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=f90ZNGNU; spf=pass (imf26.hostedemail.com: domain of brauner@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678122404; a=rsa-sha256; cv=none; b=Qs/SFlkQyEAUYJghbzPbaUOKYlMtbNNw/ZXy5da5zuityw+BaxJangNIw4JN7krAROkEKL nqsvmk7rpr4b0OZfewY5/Qc3GJ1ktFMVET3WytEI3EFwAl/oudo/6ab24QgRqkSNvc1sZh 2krNapXMlhDimqfC8SO5dagaQOHMLxc= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 77731B80FEE; Mon, 6 Mar 2023 17:06:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A77C8C4339E; Mon, 6 Mar 2023 17:06:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678122400; bh=qGdVAD4ZkJ8tf7kr29quaFsf4ncMyN1P1BEMi/uGyZE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f90ZNGNUeDRqh7KYRadR5jHUcHCaMA+cx6zqvk3k3YAvXwlyYwTnZEXFYR7Q6zBYl gU8qwICJ7gQqTr03jUcpJpl0Y2ml3YqJo9wRlNpN5SHWsUnqsa3GYpyfqYVqm0zH52 dbCLXgvCajopkfhWvndAwjatOIlk3PIW2KW9Nv7l63tWOIW1tEwmwCzuu2CaQURK7S eYzmeyMk+b2A81QmV+FwBtlUpB8VaM72zhgPRD7kvfDvoYw0XNjF5z+4f20swXcKH+ HCfoRB7DX+aRTcu8+x6Frt7mkZBYKgHKY/n3ObR1eE1nkO19vbS3LPoWGT0nGAtg25 eXvmQ2DAnFzlg== Date: Mon, 6 Mar 2023 18:06:34 +0100 From: Christian Brauner To: Luis Chamberlain Cc: hughd@google.com, akpm@linux-foundation.org, willy@infradead.org, linux-mm@kvack.org, p.raghav@samsung.com, da.gomez@samsung.com, a.manzanares@samsung.com, dave@stgolabs.net, yosryahmed@google.com, keescook@chromium.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] shmem: set shmem_writepage() variables early Message-ID: <20230306170634.logjdhk7z25sivpn@wittgenstein> References: <20230302232758.888157-1-mcgrof@kernel.org> <20230302232758.888157-3-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230302232758.888157-3-mcgrof@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: ekcz63xn3b734hbwjfw9wwpstwb9zcxn X-Rspamd-Queue-Id: 56246140023 X-HE-Tag: 1678122404-205615 X-HE-Meta: U2FsdGVkX189eGUTFJvMNuwOHBMHH0wXqx1e6tSWN0Nnhvm62WsZlJY69GRWBKT43tQ6eiEfDLcaK1jOHklEecTW0N4W3pxZ7M4imgo1K9wqkdW61Y2glDjhArvtiOqrUPLn8cHVUOdh2iHR350kPMMk7Y6+uHEvA1tPqpCMA0HjkLjGW1YWUqPyqXPOrK32ZT0qLcp8dH0Ri6xLCn4xJxfSd9evlb60LkfVPA4Pywb7yKYW4ffwUs1Fc39VCcuES+TwI8SwRAEE+Vgjpi4RscEz9tp5Obug/AaPHmbBZ5QoEsJL6+ybTym1x+CtegflOSeFF0ARLefuqIvFMstaH7pSdAJu3y9kgU7RXHT8uPGAmQu4r3YW0BtD+k/YA/UweWKsThWVQjKKp1C7Up0YGK1D+mDr1Yb3qnrQ2zK54nmfUy9qDPfc/YIYMmSAT4ei9tQJ08tR6ou/BY+otGBRtmte4vxBWgiKfiYMduFRVEEixr5/ZG3x11tBW189Z/6yRl0LBpl02U+USzPjwJ0Lhfk5u/jdf2ecnsyGMm10sD1Sh5NrAg89Zr7MU74k+EGsiaq8uwaUzNxUZ1ZNOj49+1VwrV4nZeXyh+Uy4vp7tI9D02T9KuMpSpg0tmY1h0xfHjcw4BQzW7QKbW6HKNLKHz6ihASUlyR0VQEw19UV0neD7RStng8AScrPKMcPy79q105Mtyg30zCteo5ygh6jerS/fYCLE6EmgGgLTOI2XZsJTOdvxaIqDuHuofj7umhyNe+OlcQqPuXrZvpnwcWQwsVVRrlW32tMKQvzG4JpdZB847SrxMwa6OUR7bzzsthuHiv+vdNr5PKsnsEgbuOiM1wYuntKWQG10rkFGa1eB3+a4xS13N5z296DlRU7Rd7H1IDdzEhIK5xsFZ4qmhSov39B8kAQahOoq29oxhpJ919IAPH29xg7kaFQM6tWplM2Jk1Q++RSlo7TxYyWUCc JYPg07qp 96HUi95siPpcSaRFfM9QyzHZHZqckkCs0sO2y4VVumwHPhRf2gj0gAtG4+EKUlJhKjQ16UfzHb6eGZgGU4O/vzrW4gFvhLUt1/aoGN5n+DVR0v8hN23l2UV5Sg91CupBD2BMt/qgqZcINSANIscP/4LZGmw0Cf2pUmPwB+7RvOt9uXK40VAYMdV5ph0Bws4r6OxqMXN6nr1GDP7A3RkvZOuV1lveT3UK46yTVzUdJHJxIvnkoK2eZo+A2FUod4MX3zvuyZgjHekG5LzoA2fiLmeDntw66rXrpDyh/012kFhF5OXGnzlwTGnV5wTft/cO/fMJp/3PPTLL6g22RnXnqWrd5I5KIrdu61qbyP1/u/Yv55n2DqeBICYJKA3nFFS779jmUaTFqgKmRBtessJ1A91ynBEn4vT4iLPPO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 02, 2023 at 03:27:54PM -0800, Luis Chamberlain wrote: > shmem_writepage() sets up variables typically used *after* a possible > huge page split. However even if that does happen the address space > mapping should not change, and the inode does not change either. So it > should be safe to set that from the very beginning. > > This commit makes no functional changes. > > Signed-off-by: Luis Chamberlain > --- Looks good, Reviewed-by: Christian Brauner