From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99F66C64EC4 for ; Mon, 6 Mar 2023 21:12:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D53E86B0071; Mon, 6 Mar 2023 16:12:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D03606B0072; Mon, 6 Mar 2023 16:12:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF34D6B0073; Mon, 6 Mar 2023 16:12:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id ADC2D6B0071 for ; Mon, 6 Mar 2023 16:12:50 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7A57F140C9C for ; Mon, 6 Mar 2023 21:12:50 +0000 (UTC) X-FDA: 80539722900.20.CEA498C Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf13.hostedemail.com (Postfix) with ESMTP id A3E2920009 for ; Mon, 6 Mar 2023 21:12:48 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=lyA5srgo; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678137168; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OHEFfeBffECS3S66SyhMWiUK6Y+vnFbfCPFnlqVRTnk=; b=q6dVtP2W/fUITvd4lT9vXlDqLO4xXH8S1CKROpSVr2vF1tjQQXkeDVFaoqXC/POvsKh7hZ zgU6V7ukg+EKhtdr+XkeaR52mgS+vR5tLvbcSNKQlHHLBZl2SWmuv6psLGBUKJEyHxFNHf bp3QQPnTYyVLttKLdHpFLDMCqFYuwhE= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=lyA5srgo; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678137168; a=rsa-sha256; cv=none; b=JXI4VnfkmKV/I6qzBPVUOjWTGCfnHLe4mDdq0nvNhZ9Qml9/AoEFfOtcyIq1lQiFiG48M0 +vXDHt4fk9NQA6XdaUZ+xpJuXFcM2U49FpU6qXOEE4wuHLZaYMpwQmITPX7eehvuDl24NS bjP5cAxUKmMVnbjDF+JgVCgxdmf+lgE= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 22CB1B8112E; Mon, 6 Mar 2023 21:12:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 877BFC433EF; Mon, 6 Mar 2023 21:12:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1678137165; bh=0AauRHt3x9RU+SV6a6NBU+NyMTS3jZ7+/Vx7DrgDivM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lyA5srgoGTejBlS6L7Whsw9DmmiCZ51ipVkpKAadtoqAzjVkO7EcM8uLrYp+P0BHQ lEGrlUxUOkbKcO6mekX0Yg2ul4BDDhxMydZTzWk2QWx+oZnit+C8xqMhYx6v7Ug2dM DLSXR1QAoRgj6qF4OjsUSYQ96BiWerwZjjA0udZc= Date: Mon, 6 Mar 2023 13:12:44 -0800 From: Andrew Morton To: Yin Fengwei Cc: linux-mm@kvack.org, willy@infradead.org, mike.kravetz@oracle.com, sidhartha.kumar@oracle.com, naoya.horiguchi@nec.com, jane.chu@oracle.com, david@redhat.com Subject: Re: [PATCH v3 0/5] batched remove rmap in try_to_unmap_one() Message-Id: <20230306131244.6873a02146b3a5b78d86e02e@linux-foundation.org> In-Reply-To: <20230306092259.3507807-1-fengwei.yin@intel.com> References: <20230306092259.3507807-1-fengwei.yin@intel.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 6ieyx9ok6ku9fonb1ummkguojd4kxcod X-Rspamd-Queue-Id: A3E2920009 X-HE-Tag: 1678137168-616878 X-HE-Meta: U2FsdGVkX1+zez9BMNDY7iGDpQjPpqDEW6fa+7jsKm0JLgLSknrXfocxA6PwDhylXOTn1XJ4jhRWo7AldSSvvzRQw3dSjrBiP4+SKEDt5vARrYPpFxU2Xfij2kVqo9TsEeNHXkdVCK3qie3v8v0MOWqICmBkPibHk08nNmDjfD/yUxgpbvc4GNcbJZ9IYzPMh4gYZRLhL4edNRBCwDhW0fIo2AOAomHp5HpJSm+QuQsZJMdW6+kfBC/6v6w5+FcaGYA4zc7S/Hwca7n4WBNxXEDs1Rn25c1a4i1v7v0v0LIJoHtxqG+Zx5o5jVJSfW6QYm7TCT85NyjBm/cU5TOjx4vkzzlMhy9ahlOXvQwBv4q7oLOY5F1dATgjXYn6V0kEGoyDjRus1bQQ9f6uj9IeHw6nwWmlCgshUZt93pJexGcw3+DwiOkHhDi29EgZGMwCj787uE4sYpzO+iSX7IWdntqmXKC7kK14Hfrbn6h28al3M+tLDsu1Bq69h7Y57tKYqnDTYyV6QfB5GoldcVTmR+mOBZU7ZcIYlyefCUv5lF2AxQbQ2o/kNTQjZThSZbGkhWqQGqhYrXgukD+ZgqSJJpyIt7RGbnpxOA4JuDwYQtUzTZgpnRrYlz8DiwAInxyLlMKl3mXZMJtxmzQavxRwcoEO4Cn6YUFrZfA3tnZTBVQxYjDRzlelYxUMTyUEnJNshyywKNFMxGoAEWCio+HeCdIrZ9HHjfMGD96v0934qRXPf77NYNTvfryQMyPb2g/5urUosUNswlYXUrSOpL+gfUkrvikjzdCe0MokB9bZmMhqcg6ds0uPobuNCny2abV6jRU2N/TR4upC5nMY2nxymUk3MKVT/qae/BcMb9xkSP1uEOFVh3IL/mFYgRpfzerAXyt+IBk6NTh5jjevQ+zoFtvWHpLPiuuhtZ5WgjMKWih35DpofUYMgyiLFbcUFswmAZyEPTD330L6zgeQCOD AlakO7BL 3noT4lA2jYR+pnLL4vTZdAeZZYHTC/BelTQkBCMBmPvgn89Z1kTE6vn0q0F66P6dPHQYtg/n+8QYO+DBVkRCNVmmGKZxJZveVGlxdDkyl2Nvxor/qOsCVZyS8nfY3I6e/7mXmE/vYD+uVGq79/VvW+bN1QLjH+ZK5ny9srtbjLuCRkqubJiUEv3lvQGdNEvEiiGXreFn04vrwKCNueT2MiGbe8E9k/UY1u55A8prNERmfvS0DfWSER57NJe2/t6gC85r/2bUwNlj/deIxMY0IowiM7axz3p7aJ2KUSlaudCbhD1A76hCxU+Vq8h8XiIcqlPmbAfzW69OgyOxPqv09LOjtU2J9e/BoiaPgAD40MZUuqeIKCL2F7Fza2lot2DQ6PYKEqJCh2ZDLbWyWVKWvcXNaps7boNWCm4QO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 6 Mar 2023 17:22:54 +0800 Yin Fengwei wrote: > This series is trying to bring the batched rmap removing to > try_to_unmap_one(). It's expected that the batched rmap > removing bring performance gain than remove rmap per page. > > ... > > include/linux/rmap.h | 5 + > mm/page_vma_mapped.c | 30 +++ > mm/rmap.c | 623 +++++++++++++++++++++++++------------------ > 3 files changed, 398 insertions(+), 260 deletions(-) As was discussed in v2's review, if no performance benefit has been demonstrated, why make this change?