From: Andrew Morton <akpm@linux-foundation.org>
To: Yin Fengwei <fengwei.yin@intel.com>
Cc: linux-mm@kvack.org, willy@infradead.org, mike.kravetz@oracle.com,
sidhartha.kumar@oracle.com, naoya.horiguchi@nec.com,
jane.chu@oracle.com, david@redhat.com
Subject: Re: [PATCH v3 0/5] batched remove rmap in try_to_unmap_one()
Date: Mon, 6 Mar 2023 13:12:44 -0800 [thread overview]
Message-ID: <20230306131244.6873a02146b3a5b78d86e02e@linux-foundation.org> (raw)
In-Reply-To: <20230306092259.3507807-1-fengwei.yin@intel.com>
On Mon, 6 Mar 2023 17:22:54 +0800 Yin Fengwei <fengwei.yin@intel.com> wrote:
> This series is trying to bring the batched rmap removing to
> try_to_unmap_one(). It's expected that the batched rmap
> removing bring performance gain than remove rmap per page.
>
> ...
>
> include/linux/rmap.h | 5 +
> mm/page_vma_mapped.c | 30 +++
> mm/rmap.c | 623 +++++++++++++++++++++++++------------------
> 3 files changed, 398 insertions(+), 260 deletions(-)
As was discussed in v2's review, if no performance benefit has been
demonstrated, why make this change?
next prev parent reply other threads:[~2023-03-06 21:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 9:22 Yin Fengwei
2023-03-06 9:22 ` [PATCH v3 1/5] rmap: move hugetlb try_to_unmap to dedicated function Yin Fengwei
2023-03-08 21:38 ` Mike Kravetz
2023-03-09 5:13 ` Yin, Fengwei
2023-03-06 9:22 ` [PATCH v3 2/5] rmap: move page unmap operation " Yin Fengwei
2023-03-06 9:22 ` [PATCH v3 3/5] rmap: cleanup exit path of try_to_unmap_one_page() Yin Fengwei
2023-03-06 9:22 ` [PATCH v3 4/5] rmap:addd folio_remove_rmap_range() Yin Fengwei
2023-03-06 9:22 ` [PATCH v3 5/5] try_to_unmap_one: batched remove rmap, update folio refcount Yin Fengwei
2023-03-06 12:39 ` haoxin
2023-03-07 2:45 ` Yin, Fengwei
2023-03-06 21:12 ` Andrew Morton [this message]
2023-03-07 2:44 ` [PATCH v3 0/5] batched remove rmap in try_to_unmap_one() Yin, Fengwei
2023-03-09 13:56 ` Yin, Fengwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230306131244.6873a02146b3a5b78d86e02e@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=fengwei.yin@intel.com \
--cc=jane.chu@oracle.com \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=naoya.horiguchi@nec.com \
--cc=sidhartha.kumar@oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox