From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2149BC678D4 for ; Mon, 6 Mar 2023 11:22:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98CFF280003; Mon, 6 Mar 2023 06:22:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 93DF1280002; Mon, 6 Mar 2023 06:22:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80542280003; Mon, 6 Mar 2023 06:22:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6A76D280002 for ; Mon, 6 Mar 2023 06:22:56 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 388DC80139 for ; Mon, 6 Mar 2023 11:22:56 +0000 (UTC) X-FDA: 80538236352.13.F3310BC Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 8770A1C001B for ; Mon, 6 Mar 2023 11:22:53 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=fQ8QVSw8; spf=none (imf20.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678101773; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EbnwuiRgNY/kqdziXwSmOdmeqiqTjUlKsqwm+bsd9UQ=; b=zrSDaCRoaOac7ff6IqTOr1wbD8Kvgml+NvSbHg5LLhTvQDowTWFaqdsQFG5YJctDg0YEzE 8pv3IeT1Gs8bbNnVeETLzGkMAkmjJ7haUAh3tzB/pxqEodiijhUySaO92y0l9CNPLpSbeK eygrGw8kEkDm6EdFi6lYbo1c5hKzvNE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=fQ8QVSw8; spf=none (imf20.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678101773; a=rsa-sha256; cv=none; b=DMtozDWAw1Rav+HzPGeTqPKX8/UMujG2eRByWbWE3odt5+lCrEkMDpc7i2GUaVFPK7uOH3 p8vPHFGLMlRsSB7MWRad9XeNLojOz0WukEGsASZLDnHsGt5OrZImRfYk4WWm1MsJngx3LD 2kpyS2mCt9Q9LbFIm6WxgVpkPa4MRuE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=EbnwuiRgNY/kqdziXwSmOdmeqiqTjUlKsqwm+bsd9UQ=; b=fQ8QVSw82wR8gDnaD0q3Fsb51N fJQQlLr9/BuTuDG7Vmoaq1qvSQQqmwPIae+4VAur/zUIiJ4zpRxPjh5BqIImXvdDbO+xi2+THRzT4 swV+Cj1aagOR/SgGZfuD7LWhBMunyOWTVjE7Koyb88EPFmAltTS7GQV4SNiTSeIguXDLvSNNExQIB 9CcQs1R+crQKnHTXLGGFR5/4GX3dmuSo3jgX/JaHRezvdsG6MglxC4qkadhJuz7F/U03qHB07RTNY vI9HJUmoVPf/1fIZ4IJZKQOeOB9sYF1p7KdDzFgyUW5tG6KgOojjJMmvHcbZ30NuvEsRKa65edP8f 1cSjE39w==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZ8vR-005IJU-V3; Mon, 06 Mar 2023 11:22:42 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 9076130013F; Mon, 6 Mar 2023 12:22:40 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 6C6A323B53549; Mon, 6 Mar 2023 12:22:40 +0100 (CET) Date: Mon, 6 Mar 2023 12:22:40 +0100 From: Peter Zijlstra To: Marcelo Tosatti Cc: Christoph Lameter , Aaron Tomlin , Frederic Weisbecker , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Russell King , Huacai Chen , Heiko Carstens , x86@kernel.org Subject: Re: [PATCH v4 05/12] this_cpu_cmpxchg: x86: switch this_cpu_cmpxchg to locked, add _local function Message-ID: <20230306112240.GB1267364@hirez.programming.kicks-ass.net> References: <20230305133657.255737580@redhat.com> <20230305134053.537803923@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230305134053.537803923@redhat.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8770A1C001B X-Rspam-User: X-Stat-Signature: dy5smu6p7dn3fy4fhuhw7y6twsiwnan5 X-HE-Tag: 1678101773-438046 X-HE-Meta: U2FsdGVkX1+kerb/eClpbANZhfLFnCiCFA78jHGVyYSa0lNB7SU7XFfVjxMqCzIFj6y1k2VYNWiJ7r15CbJGoO4YC/BgHNrhHquzIei6kD9rFyi/zK8KLpZ1HfX5jnzQv2Hv0g1DylH2t125VxSUkQjkQ07woxmpwwYp8nyYZM9MEphRGiqQFmai9tZ3+NPyPtacvBNuBdktWnyozk5k6UfQwCBZofKHS5t7BgVJfosK279tBPcLxMdFOtoDjxB5rwap7MBNGMdFD7u68poxMbNKEdX0nVwWFKJmQhW7BkpQkqieb9DFR0TLtc9jrqoXWrxynDB5mXG1yfqPwln6LccF2Crh4MK6w9fdB30L88zBQE7sMitMBOp1TcdEq/dojQPNx5Wi1kaDIzSqeLgNxXxvuBLeSIkUalwn6w25ptjFzRgoi/gkRqKLGbFrLYV4sBKcsBjv+d/IvjO/X27rJR+V7iPrkgrYm3fska7iVndqxvKUHBe3SaqUpyMAE/6pAQwBAChb6v7smra2gX+OZiOBm3j2xUUOmeSdHH/Ej7q5PHlvYw5YByyzZGZSGBuXhxTZpurVtMUvNzTr4EkHDFc2Fgc88o3TH/mo9crkPn0l13UzUCU38baxExaRJqEluch07yJBCoqfduUx+GT+bJpHfJy71J4JurikT88yWyBRCChoTaaTd0I33Opg3fr8Bgk8hQfUhBFa78D3shWnjWxQWqy9TTMugSC2Bditpy6Dr0PyhmPp+nVl3c9k08M5U8qdqLzDTwEflJfnC/MeGFfbI2vO55AHjeFkAtH3SByXLrGU0/mMhYDaX3u3RF39RxQlh1NXubexos/4XAPIdoLo2RkRHc/ClEHk2kmVSumW87Hq4F/vSi6+bD62JxigBGCwQIe1VAI6/j33j8YdGl9BHnWp45DJ+qe+LxequXFiIY2zQEbRw0qTON6F4omeH4Jbbm0ncdfpauchQvw 58tOoV77 pAPVdfPkHuQe4ft+qpEyJCVM9sWP6wr4WRxlgPZKVuJ9xaResyRG6H1U7IDjuVzasQm8DHeczqe5//RaQB1I8of1ktT74qEEc+Q63J+G/KOpl7pIboD+humxQDlIQlF1Ns7kzGXCqjYIATk6lQzwyOF/wBxqDjP2YGsafYRl+EOTRbBQhu3alFV6Z7i7ttc8bWDvAWHUjgvSg24E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Mar 05, 2023 at 10:37:02AM -0300, Marcelo Tosatti wrote: > Goal is to have vmstat_shepherd to transfer from > per-CPU counters to global counters remotely. For this, > an atomic this_cpu_cmpxchg is necessary. > > Following the kernel convention for cmpxchg/cmpxchg_local, > change x86's this_cpu_cmpxchg_ helpers to be atomic. > and add this_cpu_cmpxchg_local_ helpers which are not atomic. Urgh.. much hate for this. this_cpu_*() is local, per definition, always.