From: Peter Zijlstra <peterz@infradead.org>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Christoph Lameter <cl@linux.com>,
Aaron Tomlin <atomlin@atomlin.com>,
Frederic Weisbecker <frederic@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Russell King <linux@armlinux.org.uk>,
Huacai Chen <chenhuacai@kernel.org>,
Heiko Carstens <hca@linux.ibm.com>,
x86@kernel.org
Subject: Re: [PATCH v4 05/12] this_cpu_cmpxchg: x86: switch this_cpu_cmpxchg to locked, add _local function
Date: Mon, 6 Mar 2023 12:22:40 +0100 [thread overview]
Message-ID: <20230306112240.GB1267364@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20230305134053.537803923@redhat.com>
On Sun, Mar 05, 2023 at 10:37:02AM -0300, Marcelo Tosatti wrote:
> Goal is to have vmstat_shepherd to transfer from
> per-CPU counters to global counters remotely. For this,
> an atomic this_cpu_cmpxchg is necessary.
>
> Following the kernel convention for cmpxchg/cmpxchg_local,
> change x86's this_cpu_cmpxchg_ helpers to be atomic.
> and add this_cpu_cmpxchg_local_ helpers which are not atomic.
Urgh.. much hate for this. this_cpu_*() is local, per definition,
always.
next prev parent reply other threads:[~2023-03-06 11:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-05 13:36 [PATCH v4 00/12] fold per-CPU vmstats remotely Marcelo Tosatti
2023-03-05 13:36 ` [PATCH v4 01/12] mm/vmstat: remove remote node draining Marcelo Tosatti
2023-03-09 17:11 ` Vlastimil Babka
2023-03-13 16:41 ` Marcelo Tosatti
2023-03-05 13:36 ` [PATCH v4 02/12] this_cpu_cmpxchg: ARM64: switch this_cpu_cmpxchg to locked, add _local function Marcelo Tosatti
2023-03-05 13:37 ` [PATCH v4 03/12] this_cpu_cmpxchg: loongarch: " Marcelo Tosatti
2023-03-05 13:37 ` [PATCH v4 04/12] this_cpu_cmpxchg: S390: " Marcelo Tosatti
2023-03-05 13:37 ` [PATCH v4 05/12] this_cpu_cmpxchg: x86: " Marcelo Tosatti
2023-03-06 11:22 ` Peter Zijlstra [this message]
2023-03-08 21:42 ` Marcelo Tosatti
2023-03-05 13:37 ` [PATCH v4 06/12] add this_cpu_cmpxchg_local and asm-generic definitions Marcelo Tosatti
2023-03-05 13:37 ` [PATCH v4 07/12] convert this_cpu_cmpxchg users to this_cpu_cmpxchg_local Marcelo Tosatti
2023-03-05 13:37 ` [PATCH v4 08/12] mm/vmstat: switch counter modification to cmpxchg Marcelo Tosatti
2023-03-05 13:37 ` [PATCH v4 09/12] vmstat: switch per-cpu vmstat counters to 32-bits Marcelo Tosatti
2023-03-05 13:37 ` [PATCH v4 10/12] mm/vmstat: use xchg in cpu_vm_stats_fold Marcelo Tosatti
2023-03-05 13:37 ` [PATCH v4 11/12] mm/vmstat: switch vmstat shepherd to flush per-CPU counters remotely Marcelo Tosatti
2023-03-05 13:37 ` [PATCH v4 12/12] mm/vmstat: refresh stats remotely instead of via work item Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230306112240.GB1267364@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=atomlin@atomlin.com \
--cc=chenhuacai@kernel.org \
--cc=cl@linux.com \
--cc=frederic@kernel.org \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@armlinux.org.uk \
--cc=mtosatti@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox