From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3475C678DB for ; Mon, 6 Mar 2023 02:50:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B8DD6B0072; Sun, 5 Mar 2023 21:50:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 568BB6B0073; Sun, 5 Mar 2023 21:50:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 431726B0074; Sun, 5 Mar 2023 21:50:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 34B876B0072 for ; Sun, 5 Mar 2023 21:50:48 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EDE66408BE for ; Mon, 6 Mar 2023 02:50:47 +0000 (UTC) X-FDA: 80536945734.25.9BA0801 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf09.hostedemail.com (Postfix) with ESMTP id 3637B140019 for ; Mon, 6 Mar 2023 02:50:45 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=DZX7UT6a; spf=pass (imf09.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com; dmarc=pass (policy=reject) header.from=shopee.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678071046; a=rsa-sha256; cv=none; b=YGqEe+NK8yS+p0u6QkZa7N26osiB0O8Pety7Si/plyQt8IjVYttcD4eOvAHzSApggquxaz cPbfYYual07Qn6EFeedaiz4FzCjmPsBz0ZtS7HLHDntA0z4VVtw+yOWTRmOQre2zUJwQHG YUyaPucjcDQfF8WrKdHMnKcDUo0eXFw= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=DZX7UT6a; spf=pass (imf09.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com; dmarc=pass (policy=reject) header.from=shopee.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678071046; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=EVGjMrclCEaMIMZKUYlnh2axdze/uTIR/Mv0pCsUOmU=; b=xcyanppaPgJsELIEhcy/033BLN7tlZE1Si84cVuXF1NfamtzwYs96M2Ct2EDA8i/yoGkNO XPTEQRWtAc/B3EL5RuOaozR+4+YjkovnL7CozR12CTNB+KDK8Ws+KJbbpEWeyhfJexnUey ZKAiel2uhynmDPWbbBYWWeLClDP2qJE= Received: by mail-pj1-f45.google.com with SMTP id kb15so8388516pjb.1 for ; Sun, 05 Mar 2023 18:50:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopee.com; s=shopee.com; t=1678071045; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=EVGjMrclCEaMIMZKUYlnh2axdze/uTIR/Mv0pCsUOmU=; b=DZX7UT6aDv2BtYbLOycfYuulqo/XjuiHjzkPqawXrF7CBrhYSSHwBkP8oP0itHuZw2 pE8d47n571CFwzX3S5XQFKDPMN5WsSjV34ezRN9uyhq2JD7Rahx69rFI151jcxOLXchm 1Rn91tCQASUfxtMAOS9m1sKLkak64Pc0qI/7hAaN5b8QjCDHgz9GroQboQ5LsB2nyp2n 0PfBYq7uJytXjWjkHq6fbZ4JaVU6PVAQ7y5adi1XAzUiwm2ws/nPSZJ7si5040d/pbCk ziCTixd+4nTd3oKlB89e+0czAORVMdJQxUC82tTP4BIB8rkZs9NArYw1pI9Czi5P1KM7 gErg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678071045; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EVGjMrclCEaMIMZKUYlnh2axdze/uTIR/Mv0pCsUOmU=; b=GCGH4RvIoh9VtzEjQfW+NO/KlIX1LRzQrdgbKGA4SjcoexYB+02Q1PFyqVcpMbrxBa B83GrfMq7MZmZJRU0T0dDtXjujZvsu//y3CDDDYhWKAWvv1j5bo+ty1SPAG1Cusm4T5p 2jbEmiWWGZ6V0xn0LjgnW/zik4mhfUOmZlsyNsneNjXQZLOGoPJmJSErJeQx09J9yYzd h7qEaot8hcpJkpLgeV/knPKm11RMKPKPoUswmEI8aZLWXgSKVRPqda2Rv8TdOebCnLu9 gicUquT8PZobHm23x4WM/hyIkZBP63ZADFgpgS0fUgkbasHt5FYzmAPdW7qMnpKwuVre or5w== X-Gm-Message-State: AO0yUKWh/5UbojbM1SOJmEtzxVsAxyqaKgF6HKOM5b66z+PHGRdA38Pz hUX0TH1jyPlDM7EN4YSFsCoZSg== X-Google-Smtp-Source: AK7set9e7d7qkcNATE0CxLdkmohjf1AnrDBZzru+g85JjNK6/SRy6qsFF3ePYSHoqpPPBOiOEiuicQ== X-Received: by 2002:a17:903:1209:b0:19d:1bd6:4b80 with SMTP id l9-20020a170903120900b0019d1bd64b80mr9987196plh.42.1678071044951; Sun, 05 Mar 2023 18:50:44 -0800 (PST) Received: from ubuntu-haifeng.default.svc.cluster.local ([101.127.248.173]) by smtp.gmail.com with ESMTPSA id u3-20020a170902e80300b0019a6e8ceb49sm5348879plg.259.2023.03.05.18.50.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Mar 2023 18:50:44 -0800 (PST) From: Haifeng Xu To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Haifeng Xu Subject: [PATCH] mm: remove redundant check in handle_mm_fault Date: Mon, 6 Mar 2023 02:49:59 +0000 Message-Id: <20230306024959.131468-1-haifeng.xu@shopee.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 3637B140019 X-Rspamd-Server: rspam01 X-Stat-Signature: zwkqgzsbfexujir3akdgeyk6z777ndqc X-HE-Tag: 1678071045-695918 X-HE-Meta: U2FsdGVkX1/VHRSoI3IiN92jcRS0S8+7LjM8Ufc+hq3K6nr29UpNLut6F4e7bvcNlK4c4qGTZa/ODtAxvJBN2ZVj3PfR8Z0+BJzh6k1bzikMXImg11TyrzKYSL28kkW76rQHJylxW+ZMVvuVixS7+ZpQDb078Ca+3MkvJdaFDQ0VY9NMQzh2bC/EUdxrK7k7P0INfWrGjtrTJWlWxO4Gp84smljuWQbxd2/xaNA4b1lKhsaFbvsmUvyZbjWojxHwxbQzTsG/Rni93Dq+sWXIc1hXCzgEPqERw6dcuTm8c4JVugxLCv6YoZRRcP+HXgjJdIH86sLL35YXubZJ7Y8EIl2Ftm1A3RVkE035/STvJKSZi4C04o3XvV0ApCZ55j0KlUsWMa10QlOnskEnLzWFx1xOCCAynaqmVgJOcJVDWG6ZXgiMks7vKuNvB9jD4LAG1kle7CHJf59nwJs8pfu2lVpsfq3x6Zi0e2Dd3+iTVOM9fnm/7QmlhqtvEViw7WYOVA7sufWFk0a55oRk1hWvFJ1vAel0JH1IFfWhu7oVrvG3/xRe0hqIjeDeUs5ERJ69f0SNFAUS9fuoBFJLHfdepDz35EUWMl7hjddDCXef2axMNOOvHvNIPPUp7NO2CmQCWR9C2vgvlMVPD/X8q40X37OYfg664wRGcQ6n1H3Tvb0dPVOlc/XJrsBzOZF0Pc7VQlmOjOQ3uQ5r+IFkoMdm/OT+PPuN6yNXxZafPG/SlssIqMaLeV9cUZ1RDDaxdGkNoZe4mTkW0cthWmO5/mOBIMrQ+/ym+feLDhqj4kY1w8pvW6osK5azNe++7I79HSDcChRh0KeZT0C2We9+Ny8l5iDLKlCktQBMyMq39KZu1E4aYFgjFEEKVlijW6Klx3ErtpNlvHlQYiCIl+32p7QSmfNZaxteAJXfLEdhgs29Va2kTvF1qVXB+SXGDXSjNCuahZ3Au8CbwjzC0vLqrD1 ZxajVOwB WIfJsPq1Me5Uue0Eh4QzNvtpj57yGhQPcx0j+ABImZqllzg3twKUIwQWowcClx+A95xtzGGaCyxNeDc5DfVnEzcnXM0mvORWCkA5odniCexErWbL3vtgeHi1h989j1xCpkEghBLhd3qKaZ5BVWTbA4bEFXYlAGz5WzjP0ce2sla7fOfTzEA84VJwNl998TMkm0M9O8OekIo7hshHr2eLm1WWGHpCyNF6+DDPfLWD5iKSnkk/xJuaAOv+SQZxhijstrnXMOy0ESZKmlu1yj46os5WxldPGDGR8tyTdf7m9F7elJVN580W8B417QxrYB+MKn7mtySKDCWDe3JBqtip/MpREe8I7T92RWlbDrSstmobgiFXqzd5ZTmNvyF7GdkGUzlBuwLsVFIErQz+LsjTih71X08AuckHdHtYn3HZaoAPQqtwnqEijKHEkKbp/ojpGu8u8Aq0+b7tVm4JHjeHgQfxhZA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000015, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: mem_cgroup_oom_synchronize() has checked whether current memcg_in_oom is set or not, so remove the check in handle_mm_fault(). Signed-off-by: Haifeng Xu --- mm/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memory.c b/mm/memory.c index f456f3b5049c..e066d974c27b 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -5206,7 +5206,7 @@ vm_fault_t handle_mm_fault(struct vm_area_struct *vma, unsigned long address, * VM_FAULT_OOM), there is no need to kill anything. * Just clean up the OOM state peacefully. */ - if (task_in_memcg_oom(current) && !(ret & VM_FAULT_OOM)) + if (!(ret & VM_FAULT_OOM)) mem_cgroup_oom_synchronize(false); } -- 2.25.1