From: Haifeng Xu <haifeng.xu@shopee.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Haifeng Xu <haifeng.xu@shopee.com>
Subject: [PATCH] mm: remove redundant check in handle_mm_fault
Date: Mon, 6 Mar 2023 02:49:59 +0000 [thread overview]
Message-ID: <20230306024959.131468-1-haifeng.xu@shopee.com> (raw)
mem_cgroup_oom_synchronize() has checked whether current memcg_in_oom is
set or not, so remove the check in handle_mm_fault().
Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
---
mm/memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memory.c b/mm/memory.c
index f456f3b5049c..e066d974c27b 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -5206,7 +5206,7 @@ vm_fault_t handle_mm_fault(struct vm_area_struct *vma, unsigned long address,
* VM_FAULT_OOM), there is no need to kill anything.
* Just clean up the OOM state peacefully.
*/
- if (task_in_memcg_oom(current) && !(ret & VM_FAULT_OOM))
+ if (!(ret & VM_FAULT_OOM))
mem_cgroup_oom_synchronize(false);
}
--
2.25.1
next reply other threads:[~2023-03-06 2:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 2:49 Haifeng Xu [this message]
2023-03-06 13:49 ` David Hildenbrand
2023-03-07 2:36 ` Haifeng Xu
2023-03-07 2:48 ` Matthew Wilcox
2023-03-07 3:20 ` Haifeng Xu
2023-03-08 9:03 ` Haifeng Xu
2023-03-08 9:13 ` David Hildenbrand
2023-03-09 2:33 ` Haifeng Xu
2023-03-14 8:05 ` Haifeng Xu
2023-03-14 9:09 ` David Hildenbrand
2023-03-14 10:29 ` Haifeng Xu
2023-03-14 12:40 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230306024959.131468-1-haifeng.xu@shopee.com \
--to=haifeng.xu@shopee.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox