From: Marcelo Tosatti <mtosatti@redhat.com>
To: Christoph Lameter <cl@linux.com>
Cc: Aaron Tomlin <atomlin@atomlin.com>,
Frederic Weisbecker <frederic@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Russell King <linux@armlinux.org.uk>,
Huacai Chen <chenhuacai@kernel.org>,
Heiko Carstens <hca@linux.ibm.com>,
x86@kernel.org, Peter Xu <peterx@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>
Subject: [PATCH v3 07/11] convert this_cpu_cmpxchg users to this_cpu_cmpxchg_local
Date: Fri, 03 Mar 2023 16:58:48 -0300 [thread overview]
Message-ID: <20230303195908.926950608@redhat.com> (raw)
In-Reply-To: <20230303195841.310844446@redhat.com>
this_cpu_cmpxchg was modified to atomic version, which
can be more costly than non-atomic version.
Switch users of this_cpu_cmpxchg to this_cpu_cmpxchg_local
(which preserves pre-non-atomic this_cpu_cmpxchg behaviour).
Acked-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Index: linux-vmstat-remote/kernel/fork.c
===================================================================
--- linux-vmstat-remote.orig/kernel/fork.c
+++ linux-vmstat-remote/kernel/fork.c
@@ -203,7 +203,7 @@ static bool try_release_thread_stack_to_
unsigned int i;
for (i = 0; i < NR_CACHED_STACKS; i++) {
- if (this_cpu_cmpxchg(cached_stacks[i], NULL, vm) != NULL)
+ if (this_cpu_cmpxchg_local(cached_stacks[i], NULL, vm) != NULL)
continue;
return true;
}
Index: linux-vmstat-remote/kernel/scs.c
===================================================================
--- linux-vmstat-remote.orig/kernel/scs.c
+++ linux-vmstat-remote/kernel/scs.c
@@ -83,7 +83,7 @@ void scs_free(void *s)
*/
for (i = 0; i < NR_CACHED_SCS; i++)
- if (this_cpu_cmpxchg(scs_cache[i], 0, s) == NULL)
+ if (this_cpu_cmpxchg_local(scs_cache[i], 0, s) == NULL)
return;
kasan_unpoison_vmalloc(s, SCS_SIZE, KASAN_VMALLOC_PROT_NORMAL);
next prev parent reply other threads:[~2023-03-03 20:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 19:58 [PATCH v3 00/11] fold per-CPU vmstats remotely Marcelo Tosatti
2023-03-03 19:58 ` [PATCH v3 01/11] mm/vmstat: remove remote node draining Marcelo Tosatti
2023-03-03 19:58 ` [PATCH v3 02/11] this_cpu_cmpxchg: ARM64: switch this_cpu_cmpxchg to locked, add _local function Marcelo Tosatti
2023-03-03 19:58 ` [PATCH v3 03/11] this_cpu_cmpxchg: loongarch: " Marcelo Tosatti
2023-03-03 19:58 ` [PATCH v3 04/11] this_cpu_cmpxchg: S390: " Marcelo Tosatti
2023-03-03 19:58 ` [PATCH v3 05/11] this_cpu_cmpxchg: x86: " Marcelo Tosatti
2023-03-03 19:58 ` [PATCH v3 06/11] add this_cpu_cmpxchg_local and asm-generic definitions Marcelo Tosatti
2023-03-03 19:58 ` Marcelo Tosatti [this message]
2023-03-03 19:58 ` [PATCH v3 08/11] mm/vmstat: switch counter modification to cmpxchg Marcelo Tosatti
2023-03-03 19:58 ` [PATCH v3 09/11] mm/vmstat: use xchg in cpu_vm_stats_fold Marcelo Tosatti
2023-03-03 19:58 ` [PATCH v3 10/11] mm/vmstat: switch vmstat shepherd to flush per-CPU counters remotely Marcelo Tosatti
2023-03-03 19:58 ` [PATCH v3 11/11] mm/vmstat: refresh stats remotely instead of via work item Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230303195908.926950608@redhat.com \
--to=mtosatti@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=atomlin@atomlin.com \
--cc=chenhuacai@kernel.org \
--cc=cl@linux.com \
--cc=frederic@kernel.org \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@armlinux.org.uk \
--cc=peterx@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox