From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE39FC64EC4 for ; Fri, 3 Mar 2023 18:41:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 896BF6B0073; Fri, 3 Mar 2023 13:41:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8486F6B0075; Fri, 3 Mar 2023 13:41:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70E956B0078; Fri, 3 Mar 2023 13:41:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5F7096B0073 for ; Fri, 3 Mar 2023 13:41:50 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 30D5EAB989 for ; Fri, 3 Mar 2023 18:41:50 +0000 (UTC) X-FDA: 80528455980.15.ACC2BD2 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id 7954CA0013 for ; Fri, 3 Mar 2023 18:41:48 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Wu5csu7J; spf=pass (imf25.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677868908; a=rsa-sha256; cv=none; b=u3QyrFlP3B/V6PrblZBIpIPte6NIjo4ItGZyhgEmgyRV2KFzjTe8W6ZHr/6TSAqBnc7coE MaRC3CTW4zscCPf258AVoUCbqQb/sdjfDwGTRuatDnmQa4alJALB5kywaQ7HDBCd64s+8S jBcBC5R3dn3NQrCgGBP9c6ksvXt2AxA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Wu5csu7J; spf=pass (imf25.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677868908; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CuwCvJ7+ifYT599WLCBgm+3YhPil9/YJpPIgNCASKw0=; b=WCqz+WTAwVkUmVlgILAzqhIInkj3nji/9dMT9x9JLe+fV/BXNJKXJzeDARt9IFPv1BvGJK 4NXRrvZhi1RTa6PFkTGG9zII4ygH2joKixm53lAUb76Pb4skaDcQNayH525ArHpPnqb3g8 dJjANJKnzNvnyzscF6WAU0qAg9O+LSk= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9C03B6185F; Fri, 3 Mar 2023 18:41:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7BE2EC433EF; Fri, 3 Mar 2023 18:41:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677868907; bh=YTrv0VxcIMi4UDOxc6sliKnvGTbGdzcIKG2y0EaQ0W8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Wu5csu7JO0yWOcDEu9wXeHhz/I46yK3UjEg93H94QSLd5zc91edXbqOgHsxmNqqO7 Y82fkgje0ZfO4nijhPhnmFjbDBHjK/p149bgYrpSTi3ccU9sx/GkWUMvvV+l2gvjRR ULuNcamxXSGCwoOybmhb7o/E7PVLDFwCS4iSrfTbXFLsr9cipRbmu36RHxGvLIvVsF iht5PQR2MPvI7cG+rZG3Gi2vqv+DMe0FsF1bHwJOu2mvtbTyu4SMklBmhGN5XYXovH YiNxXUXqnJseABO/3E5HwmZL5/uiej4KrSw7yhW1IDShUBIm8w3u+zRESlno3m/Lx7 HJ2pbdXprz8bQ== From: SeongJae Park To: Kefeng Wang Cc: SeongJae Park , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, damon@lists.linux.dev Subject: Re: [PATCH v2 1/3] mm/damon/paddr: minor refactor of damon_pa_pageout() Date: Fri, 3 Mar 2023 18:41:45 +0000 Message-Id: <20230303184145.113640-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230303084343.171958-2-wangkefeng.wang@huawei.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 7954CA0013 X-Rspamd-Server: rspam01 X-Stat-Signature: pptfr6dcxn63mrfb5mfn3hxyrcf51kp6 X-HE-Tag: 1677868908-196435 X-HE-Meta: U2FsdGVkX18K2AkhOgx/puvbJWqQG2lIVm/FowGcVygtvjd50ldbARTEn+ukhNZU+UtWApyJUA+47gYFKKIqBkrG6tplDGfJUNZi5RBoHHMU0QQhlhRj6LixlAtAZWbyVJm9Ft2V00e6Wov7xmekLCZMceLJ3ODL5bSJkGwlcmyZFkcZDAdmzC+O2xJOy2sEuhFYdQeXDosabY+30tXUlFDuGI26ZUFRj4I3ds2bGjqZhAEOFb5RkAtKm7owyVS4xY/gxeDzatN76R1hE7sw1kgZITbV5uCoFYJBh1+qeRzNUuwIMScHc/Ni8HfkTAgPwzSV5LnMQxPJwJiU/DknvJ8QQ/Kn78ot+jFALbPvHJGUa8CmX3bRejvGHmMSQgmYH/A8ALar/Ir47BfqtBx4pfeoseDEjUR3hXyLYlU6t3+Pcx3C8R24c9ZSppcVejoItb3qsxHC6eRhT2pvJRVp18AwbZcKW6vK5q5nealgJcyhmIPGQmz6QZpZ5SnLAmZ1RGULo+RjTHrvUDpugIhpr/o/N3NK7ADppKLsNMtGxxy3Wx/TAExV/H1hxSXDm9lqq/6AX8QKvlGl/jxDbxV1X8KN5e9kJXRZ5ju+aVixeV5voilUFnBDdTTg7K1gInkUTb4PJ4U+kQ9iS5u19Qf06xCe7+3a74YGn0U9LIxW/dZbP7I3jF4dGooEkkK3tcH7Lyn/I0Ex0+IpLRc6+dRVz/rQE0CAdxjgRtLz5RGuDDcWroYvVg9SJ0mPwEWSzFNPfzolCNv3iuuqOUkTXGzoZv/nhsNUkrszfw/i42R8y96neYtxBomPEE5ewnhl8yLCaKX0lmu8pi6Gd2oOLeUYIO23kJ6i1HRdcKz3SeF2ucqcX5jIMYI2p9Qmw+BmdgmVHquqKyAZpVQgOWNXebjSTqNorGzarJBR5dao6NyVfFikNHqYM7b/t2G2EL4+EuT6IIvBBHZO3lVms9/CGSu CyTWIDTZ ZJWLGuh34XoGHtUrfjISVajD/qOUavfLjlxtDCkPWIqXulTP45D7SzN8pCWBzpdT8/8cMCKuld4edRCpgmQDceeSLfBu6VY/3LZ3R4VqG0Y+Hm5TfRwet6tjeint7m0OhYUjWMSF76TmpbKjVR+MVu7ndeRZITlAby5YZ9gyh6uPo/7GSHjdWoKo992MYgmLYLVkgec5cLuhhhxyCM0iH8RDsf4SYlF4FlWfAhTZkEvNPBfcdsu/CTLoVYBAIj7QZbSkY884/yYydGLh9wfhNcbgXtq5KR/p0Yt2TaWSMZJkMWhuAj1zJSanwfdB11tmoBAvkNUEstIIJ4Mkysazs26+sQKbFaDh5wRs/GcTjOreD8uqhuvg2m+C/ct5UrvJKXCQkBxQx350hpTVQJjQhLVoiPcpOk9z794BqkFQZ1vFam/I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 3 Mar 2023 16:43:41 +0800 Kefeng Wang wrote: > Omit three lines by unified folio_put(), and make code more clear. > > Signed-off-by: Kefeng Wang Reviewed-by: SeongJae Park Thanks, SJ > --- > mm/damon/paddr.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c > index 6c655d9b5639..3fda00a0f786 100644 > --- a/mm/damon/paddr.c > +++ b/mm/damon/paddr.c > @@ -239,21 +239,18 @@ static unsigned long damon_pa_pageout(struct damon_region *r, struct damos *s) > if (!folio) > continue; > > - if (damos_pa_filter_out(s, folio)) { > - folio_put(folio); > - continue; > - } > + if (damos_pa_filter_out(s, folio)) > + goto put_folio; > > folio_clear_referenced(folio); > folio_test_clear_young(folio); > - if (!folio_isolate_lru(folio)) { > - folio_put(folio); > - continue; > - } > + if (!folio_isolate_lru(folio)) > + goto put_folio; > if (folio_test_unevictable(folio)) > folio_putback_lru(folio); > else > list_add(&folio->lru, &folio_list); > +put_folio: > folio_put(folio); > } > applied = reclaim_pages(&folio_list); > -- > 2.35.3 > >