From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DCBFC7EE2D for ; Fri, 3 Mar 2023 18:39:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA1F66B0071; Fri, 3 Mar 2023 13:39:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D2A4D6B0072; Fri, 3 Mar 2023 13:39:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCAC16B0073; Fri, 3 Mar 2023 13:39:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A95556B0071 for ; Fri, 3 Mar 2023 13:39:30 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 78C60C117A for ; Fri, 3 Mar 2023 18:39:30 +0000 (UTC) X-FDA: 80528450100.17.F0E01E6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id D89981C000B for ; Fri, 3 Mar 2023 18:39:28 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jTwfs1Y4; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677868768; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Kk/cDAxeODH0r1xQ43SZKvuXEYFh0OHPlnhkJsCQntQ=; b=fla1uhFtvwHpQ6ikLhB6CNnuzjF4C0NlSqqAuP/ppyeso2b2RbTkaCgSus8giokhexeQv3 5wNVPH6JAv8W9oVuV75Gk9+hEIkj9h7/H6fdKfBHEwVl8jSKUixMucgQvE3FvryKucI5mC hE6dC5Tof8pn+DlBbAMqrQfAZLSt/a8= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jTwfs1Y4; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677868768; a=rsa-sha256; cv=none; b=yiTMQpyYv5MUH6dcZi/QmWuJ1tP6+DwPAzmoaWGNRkJT3/sOYqZx9hiVePPkMfaw4eSeax aPqWVHN+K+WO0euZIaEymbmPnnuFc803Jna1CUBLW/AY1d9aopX/U+J1DzC0qjgVdm4uej j2/fr3e5MSUacSpbwrd8a7wWUJnuCUs= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F0F716186E; Fri, 3 Mar 2023 18:39:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA85CC433D2; Fri, 3 Mar 2023 18:39:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677868767; bh=36+kEvSJeBiUlpNBhd6ZwIz+6aGArhfdJdUvPOwybOM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jTwfs1Y4oppNchmdXTk0x1fbjKInybQafPdgm4lcOZBZ9Z8434cwj3WqdHaU7ftPM faBmxklDElDTzu90emvaI4k25GIT6PpUFLLAhpruObd4YKelT7lZoIhv1F3RLGux2Q cImLi+jaCCFfkoWw85+0Kdi842UuD/Cy+yAcJOqQ47aPN/0YStqSAh9aw+EBMfB29d YiglP88TNaE3yI5jbyAMXZ2ANWyKHA6uAz/gBRTVH03B+UK0iZb74ZwGB+WjFIgjvL us5xb6GYlwdjsrHoWC2TUIZNGdW60vAibIuVENMS/tpuPrLWHpTpe3OSfmMqN5yNV3 0HiuZBxzE7icw== From: SeongJae Park To: Kefeng Wang Cc: SeongJae Park , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, damon@lists.linux.dev Subject: Re: [PATCH v2 2/3] mm/damon/paddr: minor refactor of damon_pa_young() Date: Fri, 3 Mar 2023 18:39:25 +0000 Message-Id: <20230303183925.113520-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230303084343.171958-3-wangkefeng.wang@huawei.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: D89981C000B X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: srqpn1ef9hyb4pqhd9ooheocqyoac5mr X-HE-Tag: 1677868768-745991 X-HE-Meta: U2FsdGVkX18OcAS1UMwzOT1dSHub3Ju2ekWS2/T45U190alyd/A5kUQA635Ri8+1Ub/JJbmUtcDWWn2KscyXQy5aBUUl0u5RC8gB7/MtOm+z/zLWyeXMfQuIqnbP/LIciq8tpHpqSqtAIR3Yr6Yj8vdu99XbiP/CwGMgcqoW5x4z/zZEQKWPFLubHMbUs3SMcPUTtI0Ta8uCC3ANNshtSiLh5PPlVpHd9jFnWHjzkIccx9dD8c6JRj1cQuvGaDxYtN7IQXcmk4d8mlg084fpcFO/6KgVY+edU3RZ/d0rXNLQmz5yThvgsqHN1f00JKFpBPU8Vbj5WCFPD+NEmpgkcLaVEdVtR5v4VrstmvfPTrD9BKDQiOaESwxTljpex06/9jamc6L03WzXzSBEAbpI6bZu6rl7ydmDawr5t1Mx+9fIpDXbk95+wchBxeTI3mh4ucqx6Ia5Qa1K6Q2MhkZYeI9BxQvi9mxULt3y2EgMz3RANBR2QFk9LQMqP6esZk2WBlA/5PFVtIP43O8RZF6CH/XHYdkYePTqE4GSgGCjjQStyL4d4p9+8OrH9tbbQfdwmbm97NWmNrYhiMovxxdcF7x09nvuR55ojK1jp/mSJFb6/IfK5xJfh2AQuwb3lpfd4LpbxkFvixMRfCRVszCIguMq0TdG2UKlhYZUJDYIzd3+/iypKG0XRkZaSfOFpz8pOwSYvmFFJjG0zqtlxsG6jMD04/+Iy2sFxQlyw2H8TS2WgDtG/M0QUQs7pEn5t+7HXNX9DhuGWSUI0H95Xfb73jB7wBRXN1p1BdI32v8Gja51TmP2UnOoLjTmQUkYJ6BvJswf8y5caVBQ3ti8Eea49kayLIu10gFkGQ8tg8sEtJQk9Cs367flQT+fJW+y2dNZqCsbp6RizsUfp/XWk1HS6y8R3RbaBBW2xEmJ8p/4+BQSu1y+CLHhrPeQgR6oV7TNKjBuY6UFsPFmkhv/4G3 gA1eJrJw TiOCNtjgrIL5PZaHRYMAMxK6MLeqRK8/5q2FAkNqmNkbf/zDB3BhK6Xp5b+zC0MT/TiNZLcpntDUm6f/IAQAsvNTS1W9K5tdPGNPQMJYUModk0J3yWK88MziLDFPSFKiqHVuazPPfRFJQrXjBA/F6/phnzb/VYgB+y4BKqqxfbI9licJ9xScgPYWsD4admx0YefrqiLs6tcDLokeRuCLeIvR9n9EIIIXUt4gwpSU00DUGNqsR6h874XaOeIBC5a+T3VmFu7yUc1bmia5g6dafR5cYA4lPEX8HCvb8118US3PeyObEvMHg926MnupkAc/ufBySs+P7/u4e/gS5Ee/OR8zvbk7sP5e6KzBH0UmdtI0kEGk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Kefeng, On Fri, 3 Mar 2023 16:43:42 +0800 Kefeng Wang wrote: > Omit three lines by unified folio_put(), and make code more clear. > > Signed-off-by: Kefeng Wang > --- > mm/damon/paddr.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c > index 3fda00a0f786..2ef9db0189ca 100644 > --- a/mm/damon/paddr.c > +++ b/mm/damon/paddr.c > @@ -130,24 +130,21 @@ static bool damon_pa_young(unsigned long paddr, unsigned long *folio_sz) > accessed = false; > else > accessed = true; > - folio_put(folio); > goto out; Because you moved 'out' label to not include *folio_sz setting, folio_sz will not set in this case. It should be set. > } > > need_lock = !folio_test_anon(folio) || folio_test_ksm(folio); > - if (need_lock && !folio_trylock(folio)) { > - folio_put(folio); > - return false; > - } > + if (need_lock && !folio_trylock(folio)) > + goto out; > > rmap_walk(folio, &rwc); > > if (need_lock) > folio_unlock(folio); > - folio_put(folio); > > -out: > *folio_sz = folio_size(folio); > +out: > + folio_put(folio); Before this change, folio_size() is called after folio_put(). Shouldn't it be called before folio_put()? If so, could we make a separate fix for that first, and then make this change on top of it, so that it can be easily applied to relevant stable kernels? Thanks, SJ > return accessed; > } > > -- > 2.35.3 > >